D 2018-09-16T20:33:15.580
J icomment Further\sinformation:\r\n\r\nThe\sassert()\sseems\sharmless.\s\sBut\safter\sremoving\sit\sthe\sALTER\sTABLE\sstatement\r\nreturns\san\serror.\r\n\r\nIn\sversion\s3.25.0,\sthe\sALTER\sTABLE\sstatement\shas\sbeen\senhanced\sto\srun\sa\r\ntest-parse\sof\sthe\swhole\sschema\safter\sit\salters\sthe\sschema,\sto\smake\ssure\sthat\r\nthe\sedits\sit\sperformed\son\sthe\sschema\sdidn't\sbreak\sanything.\s\sThere\sis\sa\sbug\r\nin\sthis\stest-parse\slogic\sthat\sgives\sa\sfalse\spositive\swhen\sa\svirtual\stable\sis\r\nused\sinside\sthe\sbody\sof\sa\strigger.\r\n\r\nSo,\sthe\sALTER\sTABLE\sstatement\sseemed\sto\swork\scorrectly,\sbut\sthe\sextra\ssanity\r\nchecking\slogic\sthat\sruns\sat\sthe\send\sfound\sa\sfalse-positive\swhich\scauses\sthe\r\nALTER\sTABLE\sto\srollback.\s\sThis\smakes\sALTER\sTABLE\sunusable\sfor\sschemas\sthat\r\nhave\striggers\sin\swhich\svirtual\stables\sare\sused\sin\sthe\sbody\sof\sthe\strigger.\r\nBecause\sthe\sfailed\sALTER\sTABLE\sis\srun\sinside\sa\snested\stransaction\swhich\r\nrollbacks\safter\sthe\sfailure,\sthe\sfailure\sdoes\snot\scause\scorruption\sor\sotherwise\r\nharm\sthe\sdatabase\sfile\sin\sany\sway.\s\sThe\sALTER\sTABLE\ssimply\sfails\sto\swork.
J login drh
J mimetype text/x-fossil-wiki
J priority Immediate
J resolution Open
J subsystem Unknown
K b41031ea2b5372378cb3d2d43cf9fe2a4a5c2510
U drh
Z 6b226c8d2249b8dec0c6bc333cee7042