/ Check-in [f51248dc]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fix the "Synopsis" on the OP_Lt, OP_Le, OP_Gt, and OP_Ge opcodes, which has been backwards for time out of mind.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | rowvalue
Files: files | file ages | folders
SHA1:f51248dcfa22e989dacde41021e96a65f12c5ca8
User & Date: drh 2016-08-27 01:41:53
Context
2016-08-27
14:13
Merge updates from trunk. check-in: 082fd5f8 user: drh tags: rowvalue
01:41
Fix the "Synopsis" on the OP_Lt, OP_Le, OP_Gt, and OP_Ge opcodes, which has been backwards for time out of mind. check-in: f51248dc user: drh tags: rowvalue
2016-08-26
22:09
Fix a minor problem in sqlite3FindInIndex() related to rowids being used as part of the index. check-in: 829f802b user: drh tags: rowvalue
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to src/vdbe.c.

  1877   1877     UPDATE_MAX_BLOBSIZE(pIn1);
  1878   1878     if( rc ) goto abort_due_to_error;
  1879   1879     break;
  1880   1880   }
  1881   1881   #endif /* SQLITE_OMIT_CAST */
  1882   1882   
  1883   1883   /* Opcode: Eq P1 P2 P3 P4 P5
  1884         -** Synopsis: IF r[P1]==r[P3]
         1884  +** Synopsis: IF r[P3]==r[P1]
  1885   1885   **
  1886   1886   ** Compare the values in register P1 and P3.  If reg(P3)==reg(P1) then
  1887   1887   ** jump to address P2.  Or if the SQLITE_STOREP2 flag is set in P5, then
  1888   1888   ** store the result of comparison in register P2.
  1889   1889   **
  1890   1890   ** The SQLITE_AFF_MASK portion of P5 must be an affinity character -
  1891   1891   ** SQLITE_AFF_TEXT, SQLITE_AFF_INTEGER, and so forth. An attempt is made 
................................................................................
  1911   1911   ** If neither operand is NULL the result is the same as it would be if
  1912   1912   ** the SQLITE_NULLEQ flag were omitted from P5.
  1913   1913   **
  1914   1914   ** If both SQLITE_STOREP2 and SQLITE_KEEPNULL flags are set then the
  1915   1915   ** content of r[P2] is only set to 1 (true) if it was not previously NULL.
  1916   1916   */
  1917   1917   /* Opcode: Ne P1 P2 P3 P4 P5
  1918         -** Synopsis: IF r[P1]!=r[P3]
         1918  +** Synopsis: IF r[P3]!=r[P1]
  1919   1919   **
  1920   1920   ** This works just like the Eq opcode except that the jump is taken if
  1921   1921   ** the operands in registers P1 and P3 are not equal.  See the Eq opcode for
  1922   1922   ** additional information.
  1923   1923   **
  1924   1924   ** If both SQLITE_STOREP2 and SQLITE_KEEPNULL flags are set then the
  1925   1925   ** content of r[P2] is only set to 0 (false) if it was not previously NULL.
  1926   1926   */
  1927   1927   /* Opcode: Lt P1 P2 P3 P4 P5
  1928         -** Synopsis: IF r[P1]<r[P3]
         1928  +** Synopsis: IF r[P3]<r[P1]
  1929   1929   **
  1930   1930   ** Compare the values in register P1 and P3.  If reg(P3)<reg(P1) then
  1931   1931   ** jump to address P2.  Or if the SQLITE_STOREP2 flag is set in P5 store
  1932   1932   ** the result of comparison (0 or 1 or NULL) into register P2.
  1933   1933   **
  1934   1934   ** If the SQLITE_JUMPIFNULL bit of P5 is set and either reg(P1) or
  1935   1935   ** reg(P3) is NULL then the take the jump.  If the SQLITE_JUMPIFNULL 
................................................................................
  1950   1950   ** P4 is  used to do the comparison.  If P4 is not specified then
  1951   1951   ** memcmp() is used to compare text string.  If both values are
  1952   1952   ** numeric, then a numeric comparison is used. If the two values
  1953   1953   ** are of different types, then numbers are considered less than
  1954   1954   ** strings and strings are considered less than blobs.
  1955   1955   */
  1956   1956   /* Opcode: Le P1 P2 P3 P4 P5
  1957         -** Synopsis: IF r[P1]<=r[P3]
         1957  +** Synopsis: IF r[P3]<=r[P1]
  1958   1958   **
  1959   1959   ** This works just like the Lt opcode except that the jump is taken if
  1960   1960   ** the content of register P3 is less than or equal to the content of
  1961   1961   ** register P1.  See the Lt opcode for additional information.
  1962   1962   */
  1963   1963   /* Opcode: Gt P1 P2 P3 P4 P5
  1964         -** Synopsis: IF r[P1]>r[P3]
         1964  +** Synopsis: IF r[P3]>r[P1]
  1965   1965   **
  1966   1966   ** This works just like the Lt opcode except that the jump is taken if
  1967   1967   ** the content of register P3 is greater than the content of
  1968   1968   ** register P1.  See the Lt opcode for additional information.
  1969   1969   */
  1970   1970   /* Opcode: Ge P1 P2 P3 P4 P5
  1971         -** Synopsis: IF r[P1]>=r[P3]
         1971  +** Synopsis: IF r[P3]>=r[P1]
  1972   1972   **
  1973   1973   ** This works just like the Lt opcode except that the jump is taken if
  1974   1974   ** the content of register P3 is greater than or equal to the content of
  1975   1975   ** register P1.  See the Lt opcode for additional information.
  1976   1976   */
  1977   1977   case OP_Eq:               /* same as TK_EQ, jump, in1, in3 */
  1978   1978   case OP_Ne:               /* same as TK_NE, jump, in1, in3 */