/ Check-in [e554a4c3]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Rename the OP_MX_JUMP macro to SQLITE_MX_JUMP_OPCODE to avoid confusing the opcode name generator.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: e554a4c38bda9c73bf129bb7c665c53ccc4d96a8
User & Date: drh 2016-04-11 16:35:05
Context
2016-04-11
16:43
Simplification and performance improvements in sqlite3ExprDup() and its subroutines. More work is possible in this area. check-in: 476cc283 user: drh tags: trunk
16:35
Rename the OP_MX_JUMP macro to SQLITE_MX_JUMP_OPCODE to avoid confusing the opcode name generator. check-in: e554a4c3 user: drh tags: trunk
14:49
Performance improvement in sqlite3ExprDelete(). check-in: 60ad80e3 user: drh tags: trunk
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to src/vdbeaux.c.

   560    560     pOp = &p->aOp[p->nOp-1];
   561    561     while(1){
   562    562   
   563    563       /* Only JUMP opcodes and the short list of special opcodes in the switch
   564    564       ** below need to be considered.  The mkopcodeh.tcl generator script groups
   565    565       ** all these opcodes together near the front of the opcode list.  Skip
   566    566       ** any opcode that does not need processing by virtual of the fact that
   567         -    ** it is larger than OP_MX_JUMP, as a performance optimization.
          567  +    ** it is larger than SQLITE_MX_JUMP_OPCODE, as a performance optimization.
   568    568       */
   569         -    if( pOp->opcode<=OP_MX_JUMP ){
          569  +    if( pOp->opcode<=SQLITE_MX_JUMP_OPCODE ){
   570    570         /* NOTE: Be sure to update mkopcodeh.tcl when adding or removing
   571    571         ** cases from this switch! */
   572    572         switch( pOp->opcode ){
   573    573           case OP_Transaction: {
   574    574             if( pOp->p2!=0 ) p->readOnly = 0;
   575    575             /* fall thru */
   576    576           }

Changes to tool/mkopcodeh.tcl.

   256    256   puts ""
   257    257   puts "/* The sqlite3P2Values() routine is able to run faster if it knows"
   258    258   puts "** the value of the largest JUMP opcode.  The smaller the maximum"
   259    259   puts "** JUMP opcode the better, so the mkopcodeh.tcl script that"
   260    260   puts "** generated this include file strives to group all JUMP opcodes"
   261    261   puts "** together near the beginning of the list."
   262    262   puts "*/"
   263         -puts "#define OP_MX_JUMP  $mxJump  /* Maximum JUMP opcode */"
          263  +puts "#define SQLITE_MX_JUMP_OPCODE  $mxJump  /* Maximum JUMP opcode */"