/ Check-in [841cf7a7]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Remove an over-zealous call to memAboutToChange() from OP_MustBeInt. OP_MustBeInt will never invalidate the Mem.z pointer so the memAboutToChange() call is not necessary.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: 841cf7a7dbf0947cb7bde864609a8d3294f78689
User & Date: drh 2010-12-03 18:57:18
Context
2010-12-04
18:20
Fix a memory leak in fts3 that can occur in an OOM condition. check-in: 507027b7 user: dan tags: trunk
2010-12-03
18:57
Remove an over-zealous call to memAboutToChange() from OP_MustBeInt. OP_MustBeInt will never invalidate the Mem.z pointer so the memAboutToChange() call is not necessary. check-in: 841cf7a7 user: drh tags: trunk
15:41
Version 3.7.4 release candidate 1 check-in: 2e800cb8 user: drh tags: trunk
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to src/vdbe.c.

  1510   1510   ** Force the value in register P1 to be an integer.  If the value
  1511   1511   ** in P1 is not an integer and cannot be converted into an integer
  1512   1512   ** without data loss, then jump immediately to P2, or if P2==0
  1513   1513   ** raise an SQLITE_MISMATCH exception.
  1514   1514   */
  1515   1515   case OP_MustBeInt: {            /* jump, in1 */
  1516   1516     pIn1 = &aMem[pOp->p1];
  1517         -  memAboutToChange(p, pIn1);
  1518   1517     applyAffinity(pIn1, SQLITE_AFF_NUMERIC, encoding);
  1519   1518     if( (pIn1->flags & MEM_Int)==0 ){
  1520   1519       if( pOp->p2==0 ){
  1521   1520         rc = SQLITE_MISMATCH;
  1522   1521         goto abort_due_to_error;
  1523   1522       }else{
  1524   1523         pc = pOp->p2 - 1;