/ Timeline
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

104 check-ins related to "mistake"

2018-01-10
13:44
Checked into the wrong branch. Closed-Leaf check-in: 55116dc3 user: drh tags: mistake
11:56
Fix a problem in os_unix.c causing it to return SQLITE_CANTOPEN instead of SQLITE_READONLY_RECOVERY. check-in: 6a16f554 user: dan tags: trunk
2017-12-26
14:12
Add options to speedtest1.c and speed-check.sh for testing performance of floating-point computatations. Closed-Leaf check-in: b3c61051 user: drh tags: mistake
14:11
Fix crashes that could occur if SQL NULL values were passed to the built-in FTS5 snippet function. Edit: breaks amalgamation builds. check-in: 553a3ad3 user: dan tags: mistake
2017-12-25
13:43
Fix an assertion fault on a syntax error input caused by check-in [6b2ff26c25bb9da3]. Problem discovered by OSSFuzz. check-in: 90d6e4f1 user: drh tags: trunk
2017-10-27
23:28
I was a little concerned about this check-in. Though I could not generate a failure myself, I thought it was risky. I checked it in for further testing. Then, overnight, OSSFuzz found a failure case for me. So the change is now moved out into a deadend branch. Was: Use OP_SCopy rather than OP_Copy to transfer results from a co-routine to its consumer. This undoes an earlier fix for ticket [98825a79ce] by check-in [ec6a06246e] because that problem no longer occurs due to WHERE clause push-down. Closed-Leaf check-in: 0926df09 user: drh tags: mistake
18:24
Fix a Pager ref-count leak in the sqlite_dbpage virtual table. check-in: c063bb04 user: drh tags: trunk
2017-08-22
19:44
mksourceid still does not work right. Leaf check-in: ca5dcb4a user: drh tags: mistake
19:43
Attempting to fix the source-id generator so that it works for out-of-tree builds. check-in: 5a037ac2 user: drh tags: mksourceid
15:21
Fix error tests in seldom-used compile-time branches of the unix backend. check-in: 885c2b44 user: drh tags: trunk
2017-06-16
10:15
Failed version 3.18.1. Somehow I managed to omit the bug fix which was the entire purpose of 3.18.1 in the first place! Leaf check-in: e3038fbf user: drh tags: mistake
2017-06-15
07:47
Increase the version number to 3.18.1. check-in: 4be2eba8 user: drh tags: branch-3.18
2017-02-15
16:04
Bummer. Checked this in as a branch off of the wrong branch.... Was: Add the companion "carray_asc" table-valued function to the carray extension. Closed-Leaf check-in: 396b9d99 user: drh tags: mistake
15:11
Remove the CLANG_VERSION macro, since we have learned that version numbers in clang are "marketing" and are inconsistent and unreliable. Builds using clang will still use the GCC_VERSION macro since clang works hard to be gcc compatible. check-in: 8d3f485d user: drh tags: branch-3.17
2016-09-02
17:27
The previous commit could miss an SQLITE_NOMEM error. This commit catches it. Closed-Leaf check-in: 3a9f4750 user: dan tags: mistake
17:18
Within a backup operation, ensure that a read-transaction is opened on the source database before its page size is read. This ensures the page-size used to write to the backup database is the same as its actual page-size, which is important for ZipVFS databases. check-in: 7908fc60 user: dan tags: trunk
2016-05-11
18:20
Remove a redundant condition from pcache.c. Add an OPTIMIZATION-IF-TRUE comment to another condition that requires it. Closed-Leaf check-in: 4533ed35 user: dan tags: mistake
15:41
Remove some a small amount of redundant code related to PCache.pSynced from pcache.c. check-in: 9cc8cad7 user: dan tags: trunk
2016-04-18
15:51
Faulty check-in. Extraneous edits that were not logically part of the check-in. Closed-Leaf check-in: abf9d602 user: drh tags: mistake
2016-04-08
15:09
Version 3.12.1 check-in: fe7d3b75 user: drh tags: release, branch-3.12.0, version-3.12.1
2016-04-05
18:24
Oops. Branched from the wrong baseline. Ignore this one. Closed-Leaf check-in: 8f1f300c user: drh tags: mistake
2016-02-15
17:29
Version 3.11.0 check-in: 3d862f20 user: drh tags: trunk, release, version-3.11.0
2015-09-29
17:51
This condition was not always true after all.....    Change an always-true condition in the virtual table transaction interface into an assert(). Closed-Leaf check-in: 3e15dea5 user: drh tags: mistake
17:20
Use symbolic names XN_ROWID and XN_EXPR in place of the (-1) and (-2) magic numbers in Index.aiColumn[]. Add asserts to help verify that Index.aiColumn[] is always used correctly. Fix one place in FK processing where Index.aiColumn[] was not being used correctly. check-in: 7d272aa6 user: drh tags: trunk
2015-09-02
12:52
This change is not correct for the boundary case of nCellKey==0. Was: Small performance gain and size reduction in sqlite3VdbeIdxKeyCompare(). Closed-Leaf check-in: 6e0298cd user: drh tags: mistake
2015-09-01
23:51
Very minor optimizations in the unix VFS. check-in: 6db3ff45 user: drh tags: trunk
2015-04-28
13:11
Oops - the deephemerialization needs to occur before the move, not after. Was: Rather than try to keep track of the parent of an ephermeral register when the register moves, just deephemeralize all registers touched by the OP_Move opcode. Closed-Leaf check-in: 091cfe8e user: drh tags: mistake
12:44
Shift the Mem.pScopyFrom pointer in the correct direction in OP_Move. Fix for a defective check-in [a2135ad13049] and ticket [d6352363751]. Debugging code only - does not affect normal operation. check-in: add4e043 user: drh tags: trunk
2015-04-16
12:09
Checked in the wrong fix. Closed-Leaf check-in: 4b0f4484 user: drh tags: mistake
08:54
Fix a problem in test file e_reindex.test. check-in: 5b3de939 user: dan tags: trunk
2015-03-30
19:56
Optimize CREATE INDEX, REINDEX and VACUUM statements by taking better advantage of the fact that index keys are being inserted into b-trees in sorted order. Leaf check-in: 763d2bc7 user: dan tags: mistake
12:06
Improve performance of multi-field sorts where the first field has a low cardinality. check-in: 601e7b6b user: dan tags: sorter-opt
2014-11-22
16:14
Unintentional edits mistakenly checked in. Was: Remove an obsolete and incorrect comment from the whereLoopOutputAdjust() routine in the query planner. No changes to working code. Closed-Leaf check-in: e1f893c6 user: drh tags: mistake
12:22
Remove a redundant test case (probably a copy/paste error). Add an assert() to where.c to ensure that automatic indexes do not have there output row counts adjusted downward by supplementary constraints. check-in: eea47933 user: drh tags: trunk
2014-08-29
14:20
Not a fault after all, rather a testing mistake. Move this change back to trunk. Was: Avoid an unnecessary OP_Move operation for expression subqueries. check-in: 2a74129a user: drh tags: trunk
12:29
Contains a fault. Was: Avoid an unnecessary OP_Move operation for expression subqueries. Closed-Leaf check-in: 462f42af user: drh tags: mistake
2014-08-28
19:38
Improved WHERETRACE messages for the estimated output row reductions from range scans. check-in: fdd478bb user: drh tags: trunk
2014-05-28
09:56
Moved to "mistake" because this commit contains a typo causing a test to fail. Was: Add an extra test to further verify that the FTS notindexed option is working properly. Leaf check-in: 7d445e59 user: dan tags: mistake
03:23
Revise how OSTRACE reports logically boolean results in the Win32 VFS. check-in: c405f971 user: mistachkin tags: trunk
2014-04-02
14:16
Incorrect change to a comment. Closed-Leaf check-in: abbdb925 user: drh tags: mistake
2014-04-01
18:41
When sorting data for a CREATE INDEX statement in single-threaded mode, assume that keys are delivered to the sorter in primary key order. Also fix various comments that had fallen out of date. check-in: 821d1ac4 user: dan tags: threads
2014-03-11
14:44
Forgot to change the VERSION file. Closed-Leaf check-in: 04caffce user: drh tags: mistake
09:19
Add a test to see what happens if an rtree constructor encounters an SQLITE_BUSY error. No changes to code. check-in: 5527e236 user: dan tags: trunk
2013-01-07
17:31
Merge updates from trunk. check-in: bf90f1fb user: mistachkin tags: configReadOnly
13:26
Do not raise an error if an unknown SQL function is found in a CHECK constraint while parsing the schema of an existing database. This version causes a run-time error when processing STAT3 tables. Closed-Leaf check-in: 0a1207c8 user: dan tags: mistake
2013-01-05
17:17
More bug fixes to the test_regexp.c module. Bring test_regexp.c into alignment with the regexp.c file in the Fossil sources. check-in: 7695b88f user: drh tags: trunk
2012-12-04
05:21
Add a test to ensure that the fix in [b0c1ba655d] has worked. Closed-Leaf check-in: 59c23394 user: dan tags: mistake
2012-12-03
17:04
Make sure that the optimization that set the maximum column that will be used on a particular query does not mistakenly change an opcode other than OP_OpenRead or OP_OpenWrite. In particular, make sure it does not overwrite the P4 field of an OP_SorterOpen. check-in: b0c1ba65 user: drh tags: trunk
2012-09-18
17:32
This change generates incorrect code when there are two or more IN operators in the WHERE clause that are both used by the same index. Was: Omit an unnecessary OP_IfNull that immediately follows an OP_Rowid. Closed-Leaf check-in: 2be661a4 user: drh tags: mistake
17:08
Enhancements to the comments on sqlite3FindInIndex(). No code changes. check-in: b1a4c394 user: drh tags: trunk
2012-08-21
17:36
Cherry-pick [555fc07]: Changes to the thread routines to disable them when threading is turned off using sqlite3_config(). Also merge all recent trunk changes. check-in: c92b0fe1 user: drh tags: threads
13:08
Update the spellfix virtual table so that all OOM errors are reported out to the application. ERROR: A single edit was missed in spellfix1 which means that this particular check-in won't build "make test". Closed-Leaf check-in: c2cf4985 user: drh tags: mistake
2012-08-20
17:24
Add the SQLITE_DISABLE_FTS4_DEFERRED compile time option. check-in: e799222f user: dan tags: trunk
2012-05-20
20:23
Fix a test case so that it works even with very long pathnames. check-in: ecd4a063 user: drh tags: trunk
20:14
Check-in included unrelated debugging code by mistake. Was: Fix a test case in the shell1.test script so that it works even for very long pathnames. Closed-Leaf check-in: 0c0a0398 user: drh tags: mistake
2012-05-15
12:49
Add assert()s to verify that Table objects in the schema never use lookaside memory. check-in: 736d6ea6 user: drh tags: trunk
2012-03-28
15:44
This change turned out to the code slower. Side track it. Was: Tweaks to the OP_Column opcode for clarity of presentation. Closed-Leaf check-in: 4d516240 user: drh tags: mistake
13:41
Improvements to comments. Minor changes to code in the hot path of OP_Column - with the hope of get a few cycles of performance improvement. check-in: ca093103 user: drh tags: faster-typeof-and-length
2011-09-22
03:13
Merge the cache-stats enhancement into trunk. Closed-Leaf check-in: 646db971 user: drh tags: mistake
00:56
Update the version number to 3.7.9. check-in: 14e28eb9 user: drh tags: trunk
2011-09-20
15:53
Add SQLITE_STMTSTATUS_CACHE_HIT/MISS and SQLITE_DB_STATUS_CACHE_HIT/MISS. For querying the number of pager cache hits and misses on a statement or connection basis. Closed-Leaf check-in: 89272357 user: dan tags: cache-stats
2011-05-13
17:11
Rather than document goofy behavior, it seems better to make the behavior less goofy. (Was: Updates to the sqlite3_last_insert_rowid() documentation - to make it clear that the function does not work for virtual tables.) Closed-Leaf check-in: f88dfac3 user: drh tags: mistake
17:11
Also add fts3_term.c to main.mk. check-in: 966f2d2c user: drh tags: trunk
2011-05-10
14:52
Provide the ability to specify an alternative mutex subsystem at compile-time. - This check-in should have gone on the trunk, not on the 3.7.6 branch. Closed-Leaf check-in: 489c453d user: drh tags: mistake
2011-04-17
17:25
Version 3.7.6.2 check-in: 154ddbc1 user: drh tags: release, version-3.7.6.2, branch-3.7.6
2011-02-23
13:53
The robust_flock() fix that accidently included some unrelated, though harmless changes. I should follow my own checklist! Closed-Leaf check-in: e701efbd user: drh tags: mistake
13:33
Retry selected system calls on unix when they fail with EINTR. check-in: b9d29ea3 user: drh tags: trunk
2011-01-28
17:02
Bogus release candidate. Closed-Leaf check-in: 38ca1daa user: drh tags: mistake
15:46
Change pager_truncate() to a different method for extending files while also ensuring that writes are page-size and page-aligned. check-in: 874bc884 user: drh tags: trunk
2010-10-28
15:49
This was suppose to go on "trunk" but got committed to the wrong branch. Add new "dynamic_triggers" test case to threadtest3.c. Closed-Leaf check-in: d9e588ef user: dan tags: mistake
2010-10-27
19:23
Add tail recursion to the sqlite3ExprDelete() routine in order to keep down stack space usage for really, really large expressions. Later: The tail recursion is dangerous since the recursion might happen after the expression has been freed. check-in: 7324c7f2 user: drh tags: mistake
19:08
Avoid trying to allocate a negative number of bytes of memory in the test wrapper for sqlite3_blob_read(). check-in: 739b5d9a user: dan tags: trunk
2010-10-01
15:11
Not true: For a zeroblob, the Mem.z pointer can be null: The Mem.z pointer can never been NULL for a string or blob, even a zero-length string or blob. Assert this fact. Closed-Leaf check-in: efda3104 user: drh tags: mistake
13:28
Updates to the showjournal.c utility in order to bring it up to version 3. check-in: fa97d895 user: drh tags: trunk
2010-07-03
13:50
Fix an assert in pager.c. And various test cases that fail with the in-memory journal permutation. check-in: 622378db user: dan tags: trunk
13:45
Fix an assert in pager.c. And various test cases that fail with the in-memory journal permutation. Closed-Leaf check-in: 78fc35ff user: dan tags: mistake
12:31
Cherry-pick the correct changes out of the recent "mistake" branch while omitting the bugs. check-in: 48bf3093 user: drh tags: trunk
12:26
Remove dead code from the pager. check-in: 7cbe175a user: drh tags: mistake
12:00
Print the SQLite source_id() string when running speed tests. check-in: 6d7640ed user: drh tags: mistake
10:00
Fix an assert() in pager.c added by the previous commit. And various problems with test scripts in autovacuum and in-memory journal mode. check-in: 62a10101 user: dan tags: mistake
08:01
Do not attempt to open a WAL file for an in-memory or temporary database. Even if the database header suggests that it is a WAL database. check-in: 0fd80924 user: dan tags: mistake
05:56
Change code in OP_Rewind to avoid a valgrind warning following an error in the btree layer. This change does not fix any bug, just a warning. check-in: 4f62dbcf user: dan tags: mistake
01:44
Fix a buffer overrun in the where.c. Problem detected by valgrind. check-in: 15bb6233 user: drh tags: mistake
2010-07-02
19:49
Changes to os_win.c to have it return same error code as os_unix.c. check-in: 33b6f069 user: shaneh tags: mistake
19:36
Omit the OP_JournalMode opcode from the VDBE when SQLITE_OMIT_PRAGMA is defined. check-in: 565ff65c user: drh tags: mistake
19:04
Fix a bug in test_vfs.c causing an assert to fail. Changes to test code only. check-in: 336ce7d2 user: dan tags: mistake
18:58
Do not run the tests in notify3.test unless the unlock-notify API is available. check-in: 0d7fd6fe user: dan tags: mistake
18:44
Take out the incomplete initializer on the constant "dummy" in sqlite3VdbeGetOp(). Add a comment that the MSVC warning there should be ignored. check-in: 452ccaa9 user: drh tags: mistake
18:15
Fix a couple more compiler warnings under MSVC. check-in: 26bc27e3 user: shaneh tags: mistake
17:10
Fix compiler warnings in the proxy locking code. check-in: 26c7689c user: drh tags: mistake
17:07
Remove a couple of C++ style comments from pager.c. check-in: 4f12e8eb user: drh tags: mistake
17:05
Fix some warnings when compiling under MSVC. check-in: 70833877 user: shaneh tags: mistake
16:36
Add initializers for the xShmXXX() members to an sqlite3_io_methods structure in journal.c. This doesn't fix any real problem, just prevents a compiler warning. check-in: dafb3577 user: dan tags: trunk
2010-06-09
11:02
Fix for race condition in WAL locking code. Closed-Leaf check-in: 7c102c7b user: dan tags: mistake
2010-06-08
15:50
Close database opened by tester.tcl when it is sourced in all.test. Because test scripts are now run in slave interpreters, this connection was not being closed by the first script run as it was previously. check-in: b072e9f6 user: dan tags: trunk
2010-05-13
09:40
Remerge mistaken test_osinst.c changes. check-in: e8c10d3c user: dan tags: trunk
09:32
Fix mistake in test_osinst.c. Closed-Leaf check-in: 4c3e1378 user: dan tags: mistake
2010-05-12
19:02
(Moved to the mistake branch due to compile errors in test_osinst.c.) Change the vfs instrumentation code in test_osinst.c to make it easier to deploy. Add a vtab implementation for reading the binary log file format. check-in: ee13c884 user: dan tags: mistake
13:50
Remove the OP_Variable optimization of check-in [48b77b04935d894] since it can lead to malfunctions as described in ticket [26ff0c82d1e90]. check-in: 7838163d user: drh tags: trunk
2010-03-04
22:36
Second thoughts: Let Tiger users set SQLITE_ENABLE_LOCKING_STYLE=0. Was: Change SQLITE_ENABLE_LOCKING_STYLE to default off, even on Macs, since older Macs (Tiger) cannot compile the latest proxy locking sources. Closed-Leaf check-in: 1a0fa8d1 user: drh tags: mistake
17:58
Fix for [9abd6aa831]. Do not overread a buffer used for an %q or %w conversion with a precision specifier. check-in: 5e472896 user: dan tags: trunk
2010-03-03
08:18
Fix another instance of the same warning-inducing expression in util.c. Closed-Leaf check-in: 80c64e16 user: dan tags: mistake
08:12
Silence a compiler warning by using a constant value instead of a constant expression that some compilers mistakenly believe causes bitshift overflow. check-in: 587109c8 user: dan tags: mistake
00:02
When TEMP files are in memory, also put the massive TEMP file used by the VACUUM command in memory. This is a cherry-pick merge of [9daf4e7d07] check-in: e5342234 user: drh tags: branch-3.6.22