Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
Comment: | Add tests for some lock-contention cases. |
---|---|
Downloads: | Tarball | ZIP archive |
Timelines: | family | ancestors | descendants | both | trunk |
Files: | files | file ages | folders |
SHA1: |
f0fcb9c9a67e2bf7bbedbedbc27791b6 |
User & Date: | dan 2010-05-06 12:15:48.000 |
Context
2010-05-06
| ||
13:36 | Unset a tcl variable before reusing it in wal.test. (check-in: e83efb232f user: dan tags: trunk) | |
12:15 | Add tests for some lock-contention cases. (check-in: f0fcb9c9a6 user: dan tags: trunk) | |
11:56 | Remove the noop-mutex implementations of mutex_held() and mutex_notheld() since they are both unreachable. (check-in: 6767b62a9a user: drh tags: trunk) | |
Changes
Changes to src/test_vfs.c.
︙ | ︙ | |||
383 384 385 386 387 388 389 390 391 392 393 394 395 396 | int eCode; const char *zCode; } aCode[] = { { SQLITE_OK, "SQLITE_OK" }, { SQLITE_ERROR, "SQLITE_ERROR" }, { SQLITE_IOERR, "SQLITE_IOERR" }, { SQLITE_LOCKED, "SQLITE_LOCKED" }, }; const char *z; int i; z = Tcl_GetStringResult(p->interp); for(i=0; i<ArraySize(aCode); i++){ | > | 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 | int eCode; const char *zCode; } aCode[] = { { SQLITE_OK, "SQLITE_OK" }, { SQLITE_ERROR, "SQLITE_ERROR" }, { SQLITE_IOERR, "SQLITE_IOERR" }, { SQLITE_LOCKED, "SQLITE_LOCKED" }, { SQLITE_BUSY, "SQLITE_BUSY" }, }; const char *z; int i; z = Tcl_GetStringResult(p->interp); for(i=0; i<ArraySize(aCode); i++){ |
︙ | ︙ |
Changes to src/wal.c.
︙ | ︙ | |||
215 216 217 218 219 220 221 222 223 224 225 226 227 228 | ** When changing the lock status to SQLITE_SHM_READ, store the ** type of reader lock (either SQLITE_SHM_READ or SQLITE_SHM_READ_FULL) ** in pWal->readerType. */ static int walSetLock(Wal *pWal, int desiredStatus){ int rc, got; if( pWal->lockState==desiredStatus ) return SQLITE_OK; rc = pWal->pVfs->xShmLock(pWal->pVfs, pWal->pWIndex, desiredStatus, &got); pWal->lockState = got; if( got==SQLITE_SHM_READ_FULL || got==SQLITE_SHM_READ ){ pWal->readerType = got; pWal->lockState = SQLITE_SHM_READ; } return rc; | > | 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 | ** When changing the lock status to SQLITE_SHM_READ, store the ** type of reader lock (either SQLITE_SHM_READ or SQLITE_SHM_READ_FULL) ** in pWal->readerType. */ static int walSetLock(Wal *pWal, int desiredStatus){ int rc, got; if( pWal->lockState==desiredStatus ) return SQLITE_OK; got = pWal->lockState; rc = pWal->pVfs->xShmLock(pWal->pVfs, pWal->pWIndex, desiredStatus, &got); pWal->lockState = got; if( got==SQLITE_SHM_READ_FULL || got==SQLITE_SHM_READ ){ pWal->readerType = got; pWal->lockState = SQLITE_SHM_READ; } return rc; |
︙ | ︙ |
Changes to test/wal2.test.
︙ | ︙ | |||
229 230 231 232 233 234 235 236 237 238 239 | } execsql { SELECT count(a), sum(a) FROM t1 } db2 } $res1 } db close db2 close tvfs delete file delete -force test.db test.db-wal test.db-journal finish_test | > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > | 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 | } execsql { SELECT count(a), sum(a) FROM t1 } db2 } $res1 } db close db2 close tvfs delete file delete -force test.db test.db-wal test.db-journal #------------------------------------------------------------------------- # This test case - wal2-3.* - tests the response of the library to an # SQLITE_BUSY when attempting to obtain a READ or RECOVER lock. # # wal2-3.0 - 2: SQLITE_BUSY when obtaining a READ lock # wal2-3.3 - 6: SQLITE_BUSY when obtaining a RECOVER lock # do_test wal2-3.0 { proc tvfs_cb {method args} { if {$method == "xShmLock"} { if {[info exists ::locked]} { return SQLITE_BUSY } } return SQLITE_OK } proc busyhandler x { if {$x>3} { unset -nocomplain ::locked } return 0 } testvfs tvfs tvfs_cb sqlite3 db test.db -vfs tvfs db busy busyhandler execsql { PRAGMA journal_mode = WAL; CREATE TABLE t1(a); INSERT INTO t1 VALUES(1); INSERT INTO t1 VALUES(2); INSERT INTO t1 VALUES(3); INSERT INTO t1 VALUES(4); } set ::locked 1 info exists ::locked } {1} do_test wal2-3.1 { execsql { SELECT count(a), sum(a) FROM t1 } } {4 10} do_test wal2-3.2 { info exists ::locked } {0} do_test wal2-3.3 { proc tvfs_cb {method args} { if {$method == "xShmLock"} { if {[info exists ::sabotage]} { unset -nocomplain ::sabotage incr_tvfs_hdr [lindex $args 0] 1 1 } if {[info exists ::locked] && [lindex $args 2] == "RECOVER"} { return SQLITE_BUSY } } return SQLITE_OK } set ::sabotage 1 set ::locked 1 list [info exists ::sabotage] [info exists ::locked] } {1 1} do_test wal2-3.4 { execsql { SELECT count(a), sum(a) FROM t1 } } {4 10} do_test wal2-3.5 { list [info exists ::sabotage] [info exists ::locked] } {0 0} db close tvfs delete file delete -force test.db test.db-wal test.db-journal finish_test |