Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
Comment: | Disable the "SELECT max(rowid) ..." optimization for virtual tables. Ticket #2250. (CVS 3669) |
---|---|
Downloads: | Tarball | ZIP archive |
Timelines: | family | ancestors | descendants | both | trunk |
Files: | files | file ages | folders |
SHA1: |
ddb4d0af5770c7030fe6e92119972c95 |
User & Date: | danielk1977 2007-03-02 07:27:00.000 |
Context
2007-03-02
| ||
08:12 | Handle the case where the estimated cost of a virtual table scan is larger than SQLITE_BIG_DBL. Ticket #2253. (CVS 3670) (check-in: 52885ed8b7 user: danielk1977 tags: trunk) | |
07:27 | Disable the "SELECT max(rowid) ..." optimization for virtual tables. Ticket #2250. (CVS 3669) (check-in: ddb4d0af57 user: danielk1977 tags: trunk) | |
06:24 | Minor fixes so that testfixture builds without IO tracing enabled. (CVS 3668) (check-in: 8d3829cdb3 user: danielk1977 tags: trunk) | |
Changes
Changes to src/select.c.
︙ | ︙ | |||
8 9 10 11 12 13 14 | ** May you find forgiveness for yourself and forgive others. ** May you share freely, never taking more than you give. ** ************************************************************************* ** This file contains C code routines that are called by the parser ** to handle SELECT statements in SQLite. ** | | | 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 | ** May you find forgiveness for yourself and forgive others. ** May you share freely, never taking more than you give. ** ************************************************************************* ** This file contains C code routines that are called by the parser ** to handle SELECT statements in SQLite. ** ** $Id: select.c,v 1.330 2007/03/02 07:27:00 danielk1977 Exp $ */ #include "sqliteInt.h" /* ** Delete all the content of a Select structure but do not deallocate ** the select structure itself. |
︙ | ︙ | |||
2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 | return 0; } pExpr = pList->a[0].pExpr; if( pExpr->op!=TK_COLUMN ) return 0; iCol = pExpr->iColumn; pTab = pSrc->a[0].pTab; /* If we get to here, it means the query is of the correct form. ** Check to make sure we have an index and make pIdx point to the ** appropriate index. If the min() or max() is on an INTEGER PRIMARY ** key column, no index is necessary so set pIdx to NULL. If no ** usable index is found, return 0. */ | > > | 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 | return 0; } pExpr = pList->a[0].pExpr; if( pExpr->op!=TK_COLUMN ) return 0; iCol = pExpr->iColumn; pTab = pSrc->a[0].pTab; /* This optimization cannot be used with virtual tables. */ if( IsVirtual(pTab) ) return 0; /* If we get to here, it means the query is of the correct form. ** Check to make sure we have an index and make pIdx point to the ** appropriate index. If the min() or max() is on an INTEGER PRIMARY ** key column, no index is necessary so set pIdx to NULL. If no ** usable index is found, return 0. */ |
︙ | ︙ |
Added test/vtab8.test.
> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 | # 2006 August 29 # # The author disclaims copyright to this source code. In place of # a legal notice, here is a blessing: # # May you do good and not evil. # May you find forgiveness for yourself and forgive others. # May you share freely, never taking more than you give. # #*********************************************************************** # This file implements regression tests for SQLite library. The # focus of this file inserting into virtual tables from a SELECT # statement. # # $Id: vtab8.test,v 1.1 2007/03/02 07:27:01 danielk1977 Exp $ set testdir [file dirname $argv0] source $testdir/tester.tcl ifcapable !vtab { finish_test return } register_echo_module [sqlite3_connection_pointer db] # See ticket #2244 # do_test vtab1.2244-1 { execsql { CREATE TABLE t2244(a, b); CREATE VIRTUAL TABLE t2244e USING echo(t2244); INSERT INTO t2244 VALUES('AA', 'BB'); INSERT INTO t2244 VALUES('CC', 'DD'); SELECT rowid, * FROM t2244e; } } {1 AA BB 2 CC DD} do_test vtab1.2244-2 { execsql { SELECT * FROM t2244e WHERE rowid = 10; } } {} do_test vtab1.2244-3 { execsql { UPDATE t2244e SET a = 'hello world' WHERE 0; SELECT rowid, * FROM t2244e; } } {1 AA BB 2 CC DD} do_test vtab1-2250-2 { execsql { CREATE TABLE t2250(a, b); INSERT INTO t2250 VALUES(10, 20); CREATE VIRTUAL TABLE t2250e USING echo(t2250); select max(rowid) from t2250; select max(rowid) from t2250e; } } {1 1} # See ticket #2260 (note: this test doesn't trigger the bug yet - it's a # work in progress). # do_test vtab1.2260-1 { execsql { CREATE TABLE t2260a_real(a, b); CREATE TABLE t2260b_real(a, b); CREATE INDEX i2260 ON t2260a_real(a); CREATE INDEX i2260x ON t2260b_real(a); CREATE VIRTUAL TABLE t2260a USING echo(t2260a_real); CREATE VIRTUAL TABLE t2260b USING echo(t2260b_real); SELECT * FROM t2260a, t2260b WHERE t2260a.a = t2260b.a AND t2260a.a > 101; } } {} unset -nocomplain echo_module_begin_fail finish_test |