/ Check-in [b4980a07]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Add a missing VdbeCoverage() macro on an OP_Found opcode added in the previous check-in.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | without-rowid-or-opt
Files: files | file ages | folders
SHA1:b4980a07e287480beddb2c6633c733520e05d074
User & Date: drh 2014-05-26 20:25:34
Context
2014-05-26
22:01
Minor enhancements to comments and clarification of the code. Closed-Leaf check-in: cbec30d0 user: drh tags: without-rowid-or-opt
20:25
Add a missing VdbeCoverage() macro on an OP_Found opcode added in the previous check-in. check-in: b4980a07 user: drh tags: without-rowid-or-opt
20:06
Enable the OR optimization for WITHOUT ROWID tables. Use a temp table instead of the RowSet object to track the rows that have already been included in the result set. check-in: 2c7e277b user: dan tags: without-rowid-or-opt
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to src/where.c.

3446
3447
3448
3449
3450
3451
3452

3453
3454
3455
3456
3457
3458
3459
              ** is zero, assume that the key cannot already be present in
              ** the temp table. And if iSet is -1, assume that there is no 
              ** need to insert the key into the temp table, as it will never 
              ** be tested for.  */ 
              if( iSet ){
                addr = sqlite3VdbeCurrentAddr(v) + 2 + ((iSet>0) ? 2 : 0);
                sqlite3VdbeAddOp4Int(v, OP_Found, regRowset, addr, r, nPk);

              }
              if( iSet>=0 ){
                sqlite3VdbeAddOp3(v, OP_MakeRecord, r, nPk, regRowid);
                sqlite3VdbeAddOp3(v, OP_IdxInsert, regRowset, regRowid, 0);
                if( iSet ) sqlite3VdbeChangeP5(v, OPFLAG_USESEEKRESULT);
              }








>







3446
3447
3448
3449
3450
3451
3452
3453
3454
3455
3456
3457
3458
3459
3460
              ** is zero, assume that the key cannot already be present in
              ** the temp table. And if iSet is -1, assume that there is no 
              ** need to insert the key into the temp table, as it will never 
              ** be tested for.  */ 
              if( iSet ){
                addr = sqlite3VdbeCurrentAddr(v) + 2 + ((iSet>0) ? 2 : 0);
                sqlite3VdbeAddOp4Int(v, OP_Found, regRowset, addr, r, nPk);
                VdbeCoverage(v);
              }
              if( iSet>=0 ){
                sqlite3VdbeAddOp3(v, OP_MakeRecord, r, nPk, regRowid);
                sqlite3VdbeAddOp3(v, OP_IdxInsert, regRowset, regRowid, 0);
                if( iSet ) sqlite3VdbeChangeP5(v, OPFLAG_USESEEKRESULT);
              }