Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
Comment: | Fix a compiler warning when STAT2 is off. More test cases. Fix legacy tests to deal with the new STAT2 logic. |
---|---|
Downloads: | Tarball | ZIP archive |
Timelines: | family | ancestors | descendants | both | query-planner-tweaks |
Files: | files | file ages | folders |
SHA1: |
7e914aa999d9f3f7be58a4494d33a787 |
User & Date: | drh 2011-08-06 01:22:50.386 |
Context
2011-08-06
| ||
02:03 | Merge together the fork in the query-planner-tweaks branch. (check-in: 2daab6bd42 user: drh tags: query-planner-tweaks) | |
01:22 | Fix a compiler warning when STAT2 is off. More test cases. Fix legacy tests to deal with the new STAT2 logic. (check-in: 7e914aa999 user: drh tags: query-planner-tweaks) | |
2011-08-05
| ||
22:31 | Bug fixes to the sample-count logic for STAT2. A few test cases added. (check-in: e93c248c84 user: drh tags: query-planner-tweaks) | |
Changes
Changes to src/analyze.c.
︙ | ︙ | |||
129 130 131 132 133 134 135 136 137 138 139 140 | int regNext = iMem++; /* Index of next sample to record */ int regSampleIdx = iMem++; /* Index of next sample */ int regReady = iMem++; /* True if ready to store a stat2 entry */ int regGosub = iMem++; /* Register holding subroutine return addr */ int regSample2 = iMem++; /* Number of samples to acquire times 2 */ int regCount = iMem++; /* Number of rows in the table */ int regCount2 = iMem++; /* regCount*2 */ #endif int regCol = iMem++; /* Content of a column in analyzed table */ int regRec = iMem++; /* Register holding completed record */ int regTemp = iMem++; /* Temporary use register */ int regRowid = iMem++; /* Rowid for the inserted record */ | > < | 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 | int regNext = iMem++; /* Index of next sample to record */ int regSampleIdx = iMem++; /* Index of next sample */ int regReady = iMem++; /* True if ready to store a stat2 entry */ int regGosub = iMem++; /* Register holding subroutine return addr */ int regSample2 = iMem++; /* Number of samples to acquire times 2 */ int regCount = iMem++; /* Number of rows in the table */ int regCount2 = iMem++; /* regCount*2 */ int once = 1; /* One-time initialization */ #endif int regCol = iMem++; /* Content of a column in analyzed table */ int regRec = iMem++; /* Register holding completed record */ int regTemp = iMem++; /* Temporary use register */ int regRowid = iMem++; /* Rowid for the inserted record */ v = sqlite3GetVdbe(pParse); if( v==0 || NEVER(pTab==0) ){ return; } if( pTab->tnum==0 ){ |
︙ | ︙ |
Changes to test/analyze2.test.
︙ | ︙ | |||
69 70 71 72 73 74 75 | for {set i 0} {$i < 1000} {incr i} { execsql { INSERT INTO t1 VALUES($i) } } execsql { ANALYZE; SELECT tbl, idx, sampleno, sample FROM sqlite_stat2; } | | | | | | | | | | | | | | 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 | for {set i 0} {$i < 1000} {incr i} { execsql { INSERT INTO t1 VALUES($i) } } execsql { ANALYZE; SELECT tbl, idx, sampleno, sample FROM sqlite_stat2; } } [list t1 sqlite_autoindex_t1_1 0 50 \ t1 sqlite_autoindex_t1_1 1 150 \ t1 sqlite_autoindex_t1_1 2 250 \ t1 sqlite_autoindex_t1_1 3 350 \ t1 sqlite_autoindex_t1_1 4 450 \ t1 sqlite_autoindex_t1_1 5 550 \ t1 sqlite_autoindex_t1_1 6 650 \ t1 sqlite_autoindex_t1_1 7 750 \ t1 sqlite_autoindex_t1_1 8 850 \ t1 sqlite_autoindex_t1_1 9 950 \ ] do_test analyze2-1.2 { execsql { DELETE FROM t1 WHERE x>20; ANALYZE; SELECT tbl, idx, group_concat(sample, ' ') FROM sqlite_stat2; } } {t1 sqlite_autoindex_t1_1 {1 3 5 7 9 11 13 15 17 19}} do_test analyze2-1.3 { execsql { DELETE FROM t1 WHERE x>8; ANALYZE; SELECT * FROM sqlite_stat2; } } {} |
︙ | ︙ | |||
185 186 187 188 189 190 191 | execsql ANALYZE execsql { SELECT tbl,idx,group_concat(sample,' ') FROM sqlite_stat2 WHERE idx = 't1_x' GROUP BY tbl,idx } | | | | | | | 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 | execsql ANALYZE execsql { SELECT tbl,idx,group_concat(sample,' ') FROM sqlite_stat2 WHERE idx = 't1_x' GROUP BY tbl,idx } } {t1 t1_x {100 300 500 700 900 baa daa faa haa jaa}} do_test analyze2-3.2 { execsql { SELECT tbl,idx,group_concat(sample,' ') FROM sqlite_stat2 WHERE idx = 't1_y' GROUP BY tbl,idx } } {t1 t1_y {100 300 500 700 900 baa daa faa haa jaa}} do_eqp_test 3.3 { SELECT * FROM t1 WHERE x BETWEEN 100 AND 500 AND y BETWEEN 'a' AND 'b' } { 0 0 0 {SEARCH TABLE t1 USING INDEX t1_y (y>? AND y<?) (~25 rows)} } do_eqp_test 3.4 { SELECT * FROM t1 WHERE x BETWEEN 100 AND 400 AND y BETWEEN 'a' AND 'h' } { 0 0 0 {SEARCH TABLE t1 USING INDEX t1_x (x>? AND x<?) (~100 rows)} } do_eqp_test 3.5 { SELECT * FROM t1 WHERE x<'a' AND y>'h' } { 0 0 0 {SEARCH TABLE t1 USING INDEX t1_y (y>?) (~133 rows)} } do_eqp_test 3.6 { SELECT * FROM t1 WHERE x<444 AND y>'h' } { 0 0 0 {SEARCH TABLE t1 USING INDEX t1_y (y>?) (~133 rows)} } do_eqp_test 3.7 { SELECT * FROM t1 WHERE x<221 AND y>'g' } { 0 0 0 {SEARCH TABLE t1 USING INDEX t1_x (x<?) (~66 rows)} } |
︙ | ︙ | |||
245 246 247 248 249 250 251 | PRAGMA automatic_index=OFF; SELECT tbl,idx,group_concat(sample,' ') FROM sqlite_stat2 WHERE idx = 't3a' GROUP BY tbl,idx; PRAGMA automatic_index=ON; } | | | | 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 | PRAGMA automatic_index=OFF; SELECT tbl,idx,group_concat(sample,' ') FROM sqlite_stat2 WHERE idx = 't3a' GROUP BY tbl,idx; PRAGMA automatic_index=ON; } } {t3 t3a {AfA bfA CfA dfA EfA ffA GfA hfA IfA jfA}} do_test analyze2-4.3 { execsql { SELECT tbl,idx,group_concat(sample,' ') FROM sqlite_stat2 WHERE idx = 't3b' GROUP BY tbl,idx } } {t3 t3b {AbA CbA EbA GbA IbA bbA dbA fbA hbA jbA}} do_eqp_test 4.4 { SELECT * FROM t3 WHERE a > 'A' AND a < 'C' AND b > 'A' AND b < 'C' } { 0 0 0 {SEARCH TABLE t3 USING INDEX t3b (b>? AND b<?) (~11 rows)} } do_eqp_test 4.5 { |
︙ | ︙ | |||
293 294 295 296 297 298 299 | do_test analyze2-5.2 { execsql { SELECT tbl,idx,group_concat(sample,' ') FROM sqlite_stat2 WHERE tbl = 't4' GROUP BY tbl,idx } | | | 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 | do_test analyze2-5.2 { execsql { SELECT tbl,idx,group_concat(sample,' ') FROM sqlite_stat2 WHERE tbl = 't4' GROUP BY tbl,idx } } {t4 t4x {afa bfa cfa dfa efa ffa gfa hfa ifa jfa}} do_eqp_test 5.3 { SELECT * FROM t4 WHERE x>'ccc' } {0 0 0 {SEARCH TABLE t4 USING COVERING INDEX t4x (x>?) (~800 rows)}} do_eqp_test 5.4 { SELECT * FROM t4 AS t41, t4 AS t42 WHERE t41.x>'ccc' AND t42.x>'ggg' } { 0 0 1 {SEARCH TABLE t4 AS t42 USING COVERING INDEX t4x (x>?) (~300 rows)} |
︙ | ︙ |
Changes to test/analyze8.test.
︙ | ︙ | |||
84 85 86 87 88 89 90 | execsql {INSERT INTO t1 VALUES(0,999)} } execsql { ANALYZE; SELECT sample, cnt FROM sqlite_stat2 WHERE idx='t1x' ORDER BY sampleno; } } {0 200 0 200 0 200 10 1 70 1 130 1 190 1 999 200 999 200 999 200} | > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > | 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 | execsql {INSERT INTO t1 VALUES(0,999)} } execsql { ANALYZE; SELECT sample, cnt FROM sqlite_stat2 WHERE idx='t1x' ORDER BY sampleno; } } {0 200 0 200 0 200 10 1 70 1 130 1 190 1 999 200 999 200 999 200} do_test analyze8-3.0 { execsql { BEGIN; DROP TABLE t1; CREATE TABLE t1(a,b); CREATE INDEX t1all ON t1(a,b); INSERT INTO t1 VALUES(0,1); INSERT INTO t1 VALUES(0,2); INSERT INTO t1 VALUES(0,3); INSERT INTO t1 VALUES(1,4); INSERT INTO t1 SELECT a+2, b+4 FROM t1; INSERT INTO t1 SELECT a+4, b+8 FROM t1; INSERT INTO t1 SELECT a+8, b+16 FROM t1; COMMIT; ANALYZE; SELECT sample, cnt FROM sqlite_stat2 WHERE idx='t1all' ORDER BY sampleno; } } {0 3 2 3 4 3 5 1 6 3 8 3 10 3 12 3 13 1 14 3} do_test analyze8-3.1 { execsql { DELETE FROM t1; INSERT INTO t1 VALUES(1,1); INSERT INTO t1 VALUES(2,2); INSERT INTO t1 SELECT a+2, b+2 FROM t1; INSERT INTO t1 SELECT a+4, b+4 FROM t1; INSERT INTO t1 SELECT a+8, b+8 FROM t1; INSERT INTO t1 SELECT a+16, b+16 FROM t1; DELETE FROM t1 WHERE a>21; ANALYZE; SELECT sample, cnt FROM sqlite_stat2 WHERE idx='t1all' ORDER BY sampleno; } } {2 1 4 1 6 1 8 1 10 1 12 1 14 1 16 1 18 1 20 1} do_test analyze8-3.2 { execsql { UPDATE t1 SET a=123; ANALYZE; SELECT sample, cnt FROM sqlite_stat2 WHERE idx='t1all' ORDER BY sampleno; } } {123 21 123 21 123 21 123 21 123 21 123 21 123 21 123 21 123 21 123 21} do_test analyze8-3.3 { execsql { DELETE FROM t1 WHERE b=1 OR b=2; ANALYZE; SELECT count(*) FROM t1; SELECT sample, cnt FROM sqlite_stat2 WHERE idx='t1all' ORDER BY sampleno; } } {19} do_test analyze8-3.4 { execsql { UPDATE t1 SET a=b; INSERT INTO t1 VALUES(1,1); INSERT INTO t1 VALUES(2,2); INSERT INTO t1 SELECT a, b FROM t1; ANALYZE; SELECT sample, cnt FROM sqlite_stat2 WHERE idx='t1all' ORDER BY sampleno; } } {2 2 4 2 6 2 8 2 10 2 12 2 14 2 16 2 18 2 20 2} do_test analyze8-3.5 { execsql { UPDATE t1 SET a=1 WHERE b<20; ANALYZE; SELECT sample, cnt FROM sqlite_stat2 WHERE idx='t1all' ORDER BY sampleno; } } {1 38 1 38 1 38 1 38 1 38 1 38 1 38 1 38 1 38 20 2} do_test analyze8-3.6 { execsql { UPDATE t1 SET a=b; UPDATE t1 SET a=20 WHERE b>2; ANALYZE; SELECT sample, cnt FROM sqlite_stat2 WHERE idx='t1all' ORDER BY sampleno; } } {2 2 20 38 20 38 20 38 20 38 20 38 20 38 20 38 20 38 20 38} |
Changes to test/tkt-cbd054fa6b.test.
︙ | ︙ | |||
31 32 33 34 35 36 37 38 39 | INSERT INTO t1 VALUES (NULL, 'C'); INSERT INTO t1 VALUES (NULL, 'D'); INSERT INTO t1 VALUES (NULL, 'E'); INSERT INTO t1 VALUES (NULL, 'F'); INSERT INTO t1 VALUES (NULL, 'G'); INSERT INTO t1 VALUES (NULL, 'H'); INSERT INTO t1 VALUES (NULL, 'I'); SELECT count(*) FROM t1; } | > > > > > > > > > > | | > > > > > > > > > > | | | 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 | INSERT INTO t1 VALUES (NULL, 'C'); INSERT INTO t1 VALUES (NULL, 'D'); INSERT INTO t1 VALUES (NULL, 'E'); INSERT INTO t1 VALUES (NULL, 'F'); INSERT INTO t1 VALUES (NULL, 'G'); INSERT INTO t1 VALUES (NULL, 'H'); INSERT INTO t1 VALUES (NULL, 'I'); INSERT INTO t1 VALUES (NULL, 'J'); INSERT INTO t1 VALUES (NULL, 'K'); INSERT INTO t1 VALUES (NULL, 'L'); INSERT INTO t1 VALUES (NULL, 'M'); INSERT INTO t1 VALUES (NULL, 'N'); INSERT INTO t1 VALUES (NULL, 'O'); INSERT INTO t1 VALUES (NULL, 'P'); INSERT INTO t1 VALUES (NULL, 'Q'); INSERT INTO t1 VALUES (NULL, 'R'); INSERT INTO t1 VALUES (NULL, 'S'); SELECT count(*) FROM t1; } } {20} do_test tkt-cbd05-1.2 { db eval { ANALYZE; } } {} do_test tkt-cbd05-1.3 { execsql { SELECT tbl,idx,group_concat(sample,' ') FROM sqlite_stat2 WHERE idx = 't1_x' GROUP BY tbl,idx } } {t1 t1_x {A C E G I K M O Q S}} do_test tkt-cbd05-2.1 { db eval { DROP TABLE t1; CREATE TABLE t1(a INTEGER PRIMARY KEY, b BLOB UNIQUE NOT NULL); CREATE INDEX t1_x ON t1(b); INSERT INTO t1 VALUES(NULL, X''); INSERT INTO t1 VALUES(NULL, X'41'); INSERT INTO t1 VALUES(NULL, X'42'); INSERT INTO t1 VALUES(NULL, X'43'); INSERT INTO t1 VALUES(NULL, X'44'); INSERT INTO t1 VALUES(NULL, X'45'); INSERT INTO t1 VALUES(NULL, X'46'); INSERT INTO t1 VALUES(NULL, X'47'); INSERT INTO t1 VALUES(NULL, X'48'); INSERT INTO t1 VALUES(NULL, X'49'); INSERT INTO t1 VALUES(NULL, X'4A'); INSERT INTO t1 VALUES(NULL, X'4B'); INSERT INTO t1 VALUES(NULL, X'4C'); INSERT INTO t1 VALUES(NULL, X'4D'); INSERT INTO t1 VALUES(NULL, X'4E'); INSERT INTO t1 VALUES(NULL, X'4F'); INSERT INTO t1 VALUES(NULL, X'50'); INSERT INTO t1 VALUES(NULL, X'51'); INSERT INTO t1 VALUES(NULL, X'52'); INSERT INTO t1 VALUES(NULL, X'53'); SELECT count(*) FROM t1; } } {20} do_test tkt-cbd05-2.2 { db eval { ANALYZE; } } {} do_test tkt-cbd05-2.3 { execsql { SELECT tbl,idx,group_concat(sample,' ') FROM sqlite_stat2 WHERE idx = 't1_x' GROUP BY tbl,idx } } {t1 t1_x {A C E G I K M O Q S}} finish_test |