SQLite

Check-in [6b618b18f7]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fix test cases in wal2.test due to the fact that Darwin checks to see if the SHM file is writable before attempting to open in read/write.
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | apple-osx
Files: files | file ages | folders
SHA3-256: 6b618b18f7bac4c62d9907240f938cd8655d2b37056a6aaaf4012d62ded041d5
User & Date: drh 2017-07-07 22:39:28.022
Context
2017-07-07
22:58
Merge in all the latest trunk enhancements. (check-in: 7f48f6ab2a user: drh tags: apple-osx)
22:39
Fix test cases in wal2.test due to the fact that Darwin checks to see if the SHM file is writable before attempting to open in read/write. (check-in: 6b618b18f7 user: drh tags: apple-osx)
20:33
Avoid even trying to open a SHM file read/write in WAL mode if we know that the file is read-only. This avoids scare security log messages. (check-in: d9d9278140 user: drh tags: apple-osx)
Changes
Unified Diff Ignore Whitespace Patch
Changes to test/wal2.test.
1190
1191
1192
1193
1194
1195
1196




1197
1198
1199
1200
1201
1202
1203
    set r(1) {0 ok}
    set r(0) {1 {unable to open database file}}
    do_test wal2-13.$tn.2 {
      list [catch {sqlite3 db test.db ; set {} ok} msg] $msg
    } $r($can_open)

    if {$can_open} {





      # If $can_read is true, then the client should be able to read from
      # the database file. If $can_read is false, attempting to read should
      # throw the "unable to open database file" exception. 
      #
      set a(0) {1 {unable to open database file}}
      set a(1) {0 {3.14 2.72}}







>
>
>
>







1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
    set r(1) {0 ok}
    set r(0) {1 {unable to open database file}}
    do_test wal2-13.$tn.2 {
      list [catch {sqlite3 db test.db ; set {} ok} msg] $msg
    } $r($can_open)

    if {$can_open} {
      # Different behavior, because Darwin does an access() call prior
      # to attempting to open the SHM in read/write mode and demotes to
      # read-only if the SHM is read-only.
      if {$tn==4 && $::tcl_platform(os)=="Darwin"} {set can_read 1}

      # If $can_read is true, then the client should be able to read from
      # the database file. If $can_read is false, attempting to read should
      # throw the "unable to open database file" exception. 
      #
      set a(0) {1 {unable to open database file}}
      set a(1) {0 {3.14 2.72}}