Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
| Comment: | Remove a NEVER() in pager that can in fact be reached in obscure failure cases. |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | trunk |
| Files: | files | file ages | folders |
| SHA1: |
42b8bd1c70d8dbbc4a59e2fdee8654c4 |
| User & Date: | drh 2010-06-26 19:02:34 |
Context
|
2010-06-26
| ||
| 19:03 | Add test file tkt-d11f09d36e.test. check-in: 6e469b63 user: dan tags: trunk | |
| 19:02 | Remove a NEVER() in pager that can in fact be reached in obscure failure cases. check-in: 42b8bd1c user: drh tags: trunk | |
| 17:15 | Fix a case where the doNotSyncSpill flag may remain permanently set following an IO error. check-in: 56c7d111 user: dan tags: trunk | |
Changes
Changes to src/pager.c.
5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289 5290 5291 5292 5293 |
/* This routine should not be called if a prior error has occurred. ** But if (due to a coding error elsewhere in the system) it does get ** called, just return the same error code without doing anything. */ if( NEVER(pPager->errCode) ) return pPager->errCode; /* This function should not be called if the pager is not in at least ** PAGER_RESERVED state. And indeed SQLite never does this. But it is ** nice to have this defensive test here anyway. */ if( NEVER(pPager->state<PAGER_RESERVED) ) return SQLITE_ERROR; /* An optimization. If the database was not actually modified during ** this transaction, the pager is running in exclusive-mode and is ** using persistent journals, then this function is a no-op. ** ** The start of the journal file currently contains a single journal ** header with the nRec field set to 0. If such a journal is used as |
| | > | |
5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289 5290 5291 5292 5293 5294 |
/* This routine should not be called if a prior error has occurred. ** But if (due to a coding error elsewhere in the system) it does get ** called, just return the same error code without doing anything. */ if( NEVER(pPager->errCode) ) return pPager->errCode; /* This function should not be called if the pager is not in at least ** PAGER_RESERVED state. **FIXME**: Make it so that this test always ** fails - make it so that we never reach this point if we do not hold ** all necessary locks. */ if( pPager->state<PAGER_RESERVED ) return SQLITE_ERROR; /* An optimization. If the database was not actually modified during ** this transaction, the pager is running in exclusive-mode and is ** using persistent journals, then this function is a no-op. ** ** The start of the journal file currently contains a single journal ** header with the nRec field set to 0. If such a journal is used as |