Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
Comment: | Added test cases for PRAGMA foreign_key_check. Fixed a bug that appears when the column order of the child and parent differ. |
---|---|
Downloads: | Tarball | ZIP archive |
Timelines: | family | ancestors | descendants | both | foreign-key-check |
Files: | files | file ages | folders |
SHA1: |
25411f83f99803e39feee368703fd20b |
User & Date: | drh 2012-12-17 22:32:14.381 |
Context
2012-12-20
| ||
00:32 | Remove an unreachable branch operation from the foreign_key_check pragma. (Closed-Leaf check-in: b5a8f3160b user: drh tags: foreign-key-check) | |
2012-12-17
| ||
22:32 | Added test cases for PRAGMA foreign_key_check. Fixed a bug that appears when the column order of the child and parent differ. (check-in: 25411f83f9 user: drh tags: foreign-key-check) | |
20:57 | Add to the foreign_key_check pragma an extra output column "parent" that contains the name of the parent table for the constraint that failed. (check-in: 97f7f73772 user: drh tags: foreign-key-check) | |
Changes
Changes to src/pragma.c.
︙ | ︙ | |||
1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 | HashElem *k; /* Loop counter: Next table in schema */ int x; /* result variable */ int regResult; /* 3 registers to hold a result row */ int regKey; /* Register to hold key for checking the FK */ int regRow; /* Registers to hold a row from pTab */ int addrTop; /* Top of a loop checking foreign keys */ int addrOk; /* Jump here if the key is OK */ if( sqlite3ReadSchema(pParse) ) goto pragma_out; regResult = pParse->nMem+1; pParse->nMem += 4; regKey = ++pParse->nMem; regRow = ++pParse->nMem; v = sqlite3GetVdbe(pParse); | > | 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 | HashElem *k; /* Loop counter: Next table in schema */ int x; /* result variable */ int regResult; /* 3 registers to hold a result row */ int regKey; /* Register to hold key for checking the FK */ int regRow; /* Registers to hold a row from pTab */ int addrTop; /* Top of a loop checking foreign keys */ int addrOk; /* Jump here if the key is OK */ int *aiCols; /* child to parent column mapping */ if( sqlite3ReadSchema(pParse) ) goto pragma_out; regResult = pParse->nMem+1; pParse->nMem += 4; regKey = ++pParse->nMem; regRow = ++pParse->nMem; v = sqlite3GetVdbe(pParse); |
︙ | ︙ | |||
1179 1180 1181 1182 1183 1184 1185 | if( pFK ) break; if( pParse->nTab<i ) pParse->nTab = i; addrTop = sqlite3VdbeAddOp1(v, OP_Rewind, 0); for(i=1, pFK=pTab->pFKey; pFK; i++, pFK=pFK->pNextFrom){ pParent = sqlite3LocateTable(pParse, 0, pFK->zTo, zDb); assert( pParent!=0 ); pIdx = 0; | > | | | > | 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 | if( pFK ) break; if( pParse->nTab<i ) pParse->nTab = i; addrTop = sqlite3VdbeAddOp1(v, OP_Rewind, 0); for(i=1, pFK=pTab->pFKey; pFK; i++, pFK=pFK->pNextFrom){ pParent = sqlite3LocateTable(pParse, 0, pFK->zTo, zDb); assert( pParent!=0 ); pIdx = 0; aiCols = 0; x = sqlite3FkLocateIndex(pParse, pParent, pFK, &pIdx, &aiCols); assert( x==0 ); addrOk = sqlite3VdbeMakeLabel(v); if( pIdx==0 ){ int iKey = pFK->aCol[0].iFrom; if( iKey>=0 && iKey!=pTab->iPKey ){ sqlite3VdbeAddOp3(v, OP_Column, 0, iKey, regRow); sqlite3ColumnDefault(v, pTab, iKey, regRow); sqlite3VdbeAddOp2(v, OP_IsNull, regRow, addrOk); sqlite3VdbeAddOp2(v, OP_MustBeInt, regRow, sqlite3VdbeCurrentAddr(v)+3); }else{ sqlite3VdbeAddOp2(v, OP_Rowid, 0, regRow); } sqlite3VdbeAddOp3(v, OP_NotExists, i, 0, regRow); sqlite3VdbeAddOp2(v, OP_Goto, 0, addrOk); sqlite3VdbeJumpHere(v, sqlite3VdbeCurrentAddr(v)-2); }else{ for(j=0; j<pFK->nCol; j++){ sqlite3ExprCodeGetColumnOfTable(v, pTab, 0, aiCols ? aiCols[j] : pFK->aCol[0].iFrom, regRow+j); sqlite3VdbeAddOp2(v, OP_IsNull, regRow+j, addrOk); } sqlite3VdbeAddOp3(v, OP_MakeRecord, regRow, pFK->nCol, regKey); sqlite3VdbeChangeP4(v, -1, sqlite3IndexAffinityStr(v,pIdx), P4_TRANSIENT); sqlite3VdbeAddOp4Int(v, OP_Found, i, addrOk, regKey, 0); } sqlite3VdbeAddOp2(v, OP_Rowid, 0, regResult+1); sqlite3VdbeAddOp4(v, OP_String8, 0, regResult+2, 0, pFK->zTo, P4_TRANSIENT); sqlite3VdbeAddOp2(v, OP_Integer, i-1, regResult+3); sqlite3VdbeAddOp2(v, OP_ResultRow, regResult, 4); sqlite3VdbeResolveLabel(v, addrOk); sqlite3DbFree(db, aiCols); } sqlite3VdbeAddOp2(v, OP_Next, 0, addrTop+1); sqlite3VdbeJumpHere(v, addrTop); } }else #endif /* !defined(SQLITE_OMIT_FOREIGN_KEY) */ |
︙ | ︙ |
Added test/fkey5.test.
> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 | # 2012 December 17 # # The author disclaims copyright to this source code. In place of # a legal notice, here is a blessing: # # May you do good and not evil. # May you find forgiveness for yourself and forgive others. # May you share freely, never taking more than you give. # #*********************************************************************** # This file implements regression tests for SQLite library. # # This file tests the PRAGMA foreign_key_check command. # set testdir [file dirname $argv0] source $testdir/tester.tcl ifcapable {!foreignkey} { finish_test return } do_test fkey5-1.1 { db eval { CREATE TABLE p1(a INTEGER PRIMARY KEY); INSERT INTO p1 VALUES(88),(89); CREATE TABLE p2(a INT PRIMARY KEY); INSERT INTO p2 VALUES(77),(78); CREATE TABLE p3(a TEXT PRIMARY KEY); INSERT INTO p3 VALUES(66),(67),('alpha'),('BRAVO'); CREATE TABLE p4(a TEXT PRIMARY KEY COLLATE nocase); INSERT INTO p4 VALUES('alpha'),('BRAVO'),('55'),('Delta'),('ECHO'); CREATE TABLE p5(a INTEGER PRIMARY KEY, b, c, UNIQUE(b,c)); INSERT INTO p5 VALUES(1,'Alpha','abc'),(2,'beta','def'); CREATE TABLE p6(a INTEGER PRIMARY KEY, b TEXT COLLATE nocase, c TEXT COLLATE rtrim, UNIQUE(b,c)); INSERT INTO p6 VALUES(1,'Alpha','abc '),(2,'bETA','def '); CREATE TABLE c1(x INTEGER PRIMARY KEY references p1); CREATE TABLE c2(x INTEGER PRIMARY KEY references p2); CREATE TABLE c3(x INTEGER PRIMARY KEY references p3); CREATE TABLE c4(x INTEGER PRIMARY KEY references p4); CREATE TABLE c5(x INT references p1); CREATE TABLE c6(x INT references p2); CREATE TABLE c7(x INT references p3); CREATE TABLE c8(x INT references p4); CREATE TABLE c9(x TEXT UNIQUE references p1); CREATE TABLE c10(x TEXT UNIQUE references p2); CREATE TABLE c11(x TEXT UNIQUE references p3); CREATE TABLE c12(x TEXT UNIQUE references p4); CREATE TABLE c13(x TEXT COLLATE nocase references p3); CREATE TABLE c14(x TEXT COLLATE nocase references p4); CREATE TABLE c15(x, y, FOREIGN KEY(x,y) REFERENCES p5(b,c)); CREATE TABLE c16(x, y, FOREIGN KEY(x,y) REFERENCES p5(c,b)); CREATE TABLE c17(x, y, FOREIGN KEY(x,y) REFERENCES p6(b,c)); CREATE TABLE c18(x, y, FOREIGN KEY(x,y) REFERENCES p6(c,b)); CREATE TABLE c19(x TEXT COLLATE nocase, y TEXT COLLATE rtrim, FOREIGN KEY(x,y) REFERENCES p5(b,c)); CREATE TABLE c20(x TEXT COLLATE nocase, y TEXT COLLATE rtrim, FOREIGN KEY(x,y) REFERENCES p5(c,b)); CREATE TABLE c21(x TEXT COLLATE nocase, y TEXT COLLATE rtrim, FOREIGN KEY(x,y) REFERENCES p6(b,c)); CREATE TABLE c22(x TEXT COLLATE nocase, y TEXT COLLATE rtrim, FOREIGN KEY(x,y) REFERENCES p6(c,b)); PRAGMA foreign_key_check; } } {} do_test fkey5-1.2 { db eval { INSERT INTO c1 VALUES(90),(87),(88); PRAGMA foreign_key_check; } } {c1 87 p1 0 c1 90 p1 0} do_test fkey5-1.3 { db eval { PRAGMA foreign_key_check(c1); } } {c1 87 p1 0 c1 90 p1 0} do_test fkey5-1.4 { db eval { PRAGMA foreign_key_check(c2); } } {} do_test fkey5-2.0 { db eval { INSERT INTO c5 SELECT x FROM c1; DELETE FROM c1; PRAGMA foreign_key_check; } } {c5 1 p1 0 c5 3 p1 0} do_test fkey5-2.1 { db eval { PRAGMA foreign_key_check(c5); } } {c5 1 p1 0 c5 3 p1 0} do_test fkey5-2.2 { db eval { PRAGMA foreign_key_check(c1); } } {} do_test fkey5-3.0 { db eval { INSERT INTO c9 SELECT x FROM c5; DELETE FROM c5; PRAGMA foreign_key_check; } } {c9 1 p1 0 c9 3 p1 0} do_test fkey5-3.1 { db eval { PRAGMA foreign_key_check(c9); } } {c9 1 p1 0 c9 3 p1 0} do_test fkey5-3.2 { db eval { PRAGMA foreign_key_check(c5); } } {} do_test fkey5-4.0 { db eval { DELETE FROM c9; INSERT INTO c2 VALUES(79),(77),(76); PRAGMA foreign_key_check; } } {c2 76 p2 0 c2 79 p2 0} do_test fkey5-4.1 { db eval { PRAGMA foreign_key_check(c2); } } {c2 76 p2 0 c2 79 p2 0} do_test fkey5-4.2 { db eval { INSERT INTO c6 SELECT x FROM c2; DELETE FROM c2; PRAGMA foreign_key_check; } } {c6 1 p2 0 c6 3 p2 0} do_test fkey5-4.3 { db eval { PRAGMA foreign_key_check(c6); } } {c6 1 p2 0 c6 3 p2 0} do_test fkey5-4.4 { db eval { INSERT INTO c10 SELECT x FROM c6; DELETE FROM c6; PRAGMA foreign_key_check; } } {c10 1 p2 0 c10 3 p2 0} do_test fkey5-4.5 { db eval { PRAGMA foreign_key_check(c10); } } {c10 1 p2 0 c10 3 p2 0} do_test fkey5-5.0 { db eval { DELETE FROM c10; INSERT INTO c3 VALUES(68),(67),(65); PRAGMA foreign_key_check; } } {c3 65 p3 0 c3 68 p3 0} do_test fkey5-5.1 { db eval { PRAGMA foreign_key_check(c3); } } {c3 65 p3 0 c3 68 p3 0} do_test fkey5-5.2 { db eval { INSERT INTO c7 SELECT x FROM c3; INSERT INTO c7 VALUES('Alpha'),('alpha'),('foxtrot'); DELETE FROM c3; PRAGMA foreign_key_check; } } {c7 1 p3 0 c7 3 p3 0 c7 4 p3 0 c7 6 p3 0} do_test fkey5-5.3 { db eval { PRAGMA foreign_key_check(c7); } } {c7 1 p3 0 c7 3 p3 0 c7 4 p3 0 c7 6 p3 0} do_test fkey5-5.4 { db eval { INSERT INTO c11 SELECT x FROM c7; DELETE FROM c7; PRAGMA foreign_key_check; } } {c11 1 p3 0 c11 3 p3 0 c11 4 p3 0 c11 6 p3 0} do_test fkey5-5.5 { db eval { PRAGMA foreign_key_check(c11); } } {c11 1 p3 0 c11 3 p3 0 c11 4 p3 0 c11 6 p3 0} do_test fkey5-6.0 { db eval { DELETE FROM c11; INSERT INTO c4 VALUES(54),(55),(56); PRAGMA foreign_key_check; } } {c4 54 p4 0 c4 56 p4 0} do_test fkey5-6.1 { db eval { PRAGMA foreign_key_check(c4); } } {c4 54 p4 0 c4 56 p4 0} do_test fkey5-6.2 { db eval { INSERT INTO c8 SELECT x FROM c4; INSERT INTO c8 VALUES('Alpha'),('ALPHA'),('foxtrot'); DELETE FROM c4; PRAGMA foreign_key_check; } } {c8 1 p4 0 c8 3 p4 0 c8 6 p4 0} do_test fkey5-6.3 { db eval { PRAGMA foreign_key_check(c8); } } {c8 1 p4 0 c8 3 p4 0 c8 6 p4 0} do_test fkey5-6.4 { db eval { INSERT INTO c12 SELECT x FROM c8; DELETE FROM c8; PRAGMA foreign_key_check; } } {c12 1 p4 0 c12 3 p4 0 c12 6 p4 0} do_test fkey5-6.5 { db eval { PRAGMA foreign_key_check(c12); } } {c12 1 p4 0 c12 3 p4 0 c12 6 p4 0} do_test fkey5-7.1 { db eval { INSERT OR IGNORE INTO c13 SELECT * FROM c12; INSERT OR IGNORE INTO C14 SELECT * FROM c12; DELETE FROM c12; PRAGMA foreign_key_check; } } {c14 1 p4 0 c14 3 p4 0 c14 6 p4 0 c13 1 p3 0 c13 2 p3 0 c13 3 p3 0 c13 4 p3 0 c13 5 p3 0 c13 6 p3 0} do_test fkey5-7.2 { db eval { PRAGMA foreign_key_check(c14); } } {c14 1 p4 0 c14 3 p4 0 c14 6 p4 0} do_test fkey5-7.3 { db eval { PRAGMA foreign_key_check(c13); } } {c13 1 p3 0 c13 2 p3 0 c13 3 p3 0 c13 4 p3 0 c13 5 p3 0 c13 6 p3 0} do_test fkey5-8.0 { db eval { DELETE FROM c13; DELETE FROM c14; INSERT INTO c19 VALUES('alpha','abc'); PRAGMA foreign_key_check(c19); } } {c19 1 p5 0} do_test fkey5-8.1 { db eval { DELETE FROM c19; INSERT INTO c19 VALUES('Alpha','abc'); PRAGMA foreign_key_check(c19); } } {} do_test fkey5-8.2 { db eval { INSERT INTO c20 VALUES('Alpha','abc'); PRAGMA foreign_key_check(c20); } } {c20 1 p5 0} do_test fkey5-8.3 { db eval { DELETE FROM c20; INSERT INTO c20 VALUES('abc','Alpha'); PRAGMA foreign_key_check(c20); } } {} do_test fkey5-8.4 { db eval { INSERT INTO c21 VALUES('alpha','abc '); PRAGMA foreign_key_check(c21); } } {} do_test fkey5-8.5 { db eval { DELETE FROM c21; INSERT INTO c19 VALUES('Alpha','abc'); PRAGMA foreign_key_check(c21); } } {} do_test fkey5-8.6 { db eval { INSERT INTO c22 VALUES('Alpha','abc'); PRAGMA foreign_key_check(c22); } } {c22 1 p6 0} do_test fkey5-8.7 { db eval { DELETE FROM c22; INSERT INTO c22 VALUES('abc ','ALPHA'); PRAGMA foreign_key_check(c22); } } {} finish_test |