/ Check-in [8bfe8344]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fix a minor and harmless memory leak in fuzzcheck. Adjust the makefiles to run fuzzcheck with --quiet on valgrind tests.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: 8bfe834432b37f94779da6c71fc369651f024590
User & Date: drh 2015-05-27 18:19:50
Context
2015-05-27
19:35
The fuzzoomtest makefile target is no longer supported, so update releasetest.tcl accordingly. check-in: 06959d4a user: drh tags: trunk
18:19
Fix a minor and harmless memory leak in fuzzcheck. Adjust the makefiles to run fuzzcheck with --quiet on valgrind tests. check-in: 8bfe8344 user: drh tags: trunk
18:13
All bytes of a page are initialized, even bytes that follow a 2-byte cell on a malformed page. check-in: 7373a004 user: drh tags: trunk
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to Makefile.in.

   998    998   test:	$(TESTPROGS) fuzztest
   999    999   	./testfixture$(TEXE) $(TOP)/test/veryquick.test
  1000   1000   
  1001   1001   # Run a test using valgrind.  This can take a really long time
  1002   1002   # because valgrind is so much slower than a native machine.
  1003   1003   #
  1004   1004   valgrindtest:	$(TESTPROGS) fuzzcheck$(TEXE)
  1005         -	valgrind -v ./fuzzcheck$(TEXE) --cell-size-check $(FUZZDATA)
         1005  +	valgrind -v ./fuzzcheck$(TEXE) --cell-size-check --quiet $(FUZZDATA)
  1006   1006   	OMIT_MISUSE=1 valgrind -v ./testfixture$(TEXE) $(TOP)/test/permutations.test valgrind
  1007   1007   
  1008   1008   # A very fast test that checks basic sanity.  The name comes from
  1009   1009   # the 60s-era electronics testing:  "Turn it on and see if smoke
  1010   1010   # comes out."
  1011   1011   #
  1012   1012   smoketest:	$(TESTPROGS) fuzzcheck$(TEXE)

Changes to main.mk.

   679    679   test:	$(TESTPROGS) fuzztest
   680    680   	./testfixture$(EXE) $(TOP)/test/veryquick.test
   681    681   
   682    682   # Run a test using valgrind.  This can take a really long time
   683    683   # because valgrind is so much slower than a native machine.
   684    684   #
   685    685   valgrindtest:	$(TESTPROGS) fuzzcheck$(EXE) $(FUZZDATA)
   686         -	valgrind -v ./fuzzcheck$(EXE) --cell-size-check $(FUZZDATA)
          686  +	valgrind -v ./fuzzcheck$(EXE) --cell-size-check --quiet $(FUZZDATA)
   687    687   	OMIT_MISUSE=1 valgrind -v ./testfixture$(EXE) $(TOP)/test/permutations.test valgrind
   688    688   
   689    689   # A very fast test that checks basic sanity.  The name comes from
   690    690   # the 60s-era electronics testing:  "Turn it on and see if smoke
   691    691   # comes out."
   692    692   #
   693    693   smoketest:	$(TESTPROGS) fuzzcheck$(EXE)

Changes to test/fuzzcheck.c.

   871    871     if( !quietFlag ){
   872    872       sqlite3_int64 iElapse = timeOfDay() - iBegin;
   873    873       printf("fuzzcheck: 0 errors out of %d tests in %d.%03d seconds\n"
   874    874              "SQLite %s %s\n",
   875    875              nTest, (int)(iElapse/1000), (int)(iElapse%1000),
   876    876              sqlite3_libversion(), sqlite3_sourceid());
   877    877     }
          878  +  free(azSrcDb);
   878    879     return 0;
   879    880   }