/ Check-in [45247c7f]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Add a hyperlink to the ticket on the code comment for the fix to ticket [7fa8049685b50b5aeb0c2].
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: 45247c7f291bc0cc42600a4aa4ff7cdcd0a703fdfadcb0e12174c5250e70d503
User & Date: drh 2018-04-24 14:18:49
Context
2018-04-24
16:41
All the OR optimization to proceed even if the OR is also converted into an IN operator. check-in: e252c654 user: drh tags: trunk
14:18
Add a hyperlink to the ticket on the code comment for the fix to ticket [7fa8049685b50b5aeb0c2]. check-in: 45247c7f user: drh tags: trunk
14:05
Do not attempt to read values from indexes-on-expressions if the index is on the RHS of a LEFT JOIN. This won't work if the index cursor points at a null-row. Fix for [7fa80496]. check-in: b8ef967a user: dan tags: trunk
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to src/wherecode.c.

  1749   1749       ** all the expressions in pWInfo and try to transform matching expressions
  1750   1750       ** into reference to index columns.
  1751   1751       **
  1752   1752       ** Do not do this for the RHS of a LEFT JOIN. This is because the 
  1753   1753       ** expression may be evaluated after OP_NullRow has been executed on
  1754   1754       ** the cursor. In this case it is important to do the full evaluation,
  1755   1755       ** as the result of the expression may not be NULL, even if all table
  1756         -    ** column values are.
         1756  +    ** column values are.  https://www.sqlite.org/src/info/7fa8049685b50b5a
  1757   1757       */
  1758   1758       if( pLevel->iLeftJoin==0 ){
  1759   1759         whereIndexExprTrans(pIdx, iCur, iIdxCur, pWInfo);
  1760   1760       }
  1761   1761   
  1762   1762       /* Record the instruction used to terminate the loop. */
  1763   1763       if( pLoop->wsFlags & WHERE_ONEROW ){