Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
141 events for the month beginning 2019-10-01 by user drh
Following month ↑|
2019-10-31
| ||
| 20:58 | • Ticket [b9befa4b] Segfault in table with generated column and foreign key status still Fixed with 3 other changes (artifact: 59afd142 user: drh) ... 1 similar event omitted. | |
| 20:54 | Correctly generate pre-UPDATE content for virtual columns that are used by foreign key constraints. Ticket [b9befa4b83a660cc] (check-in: 40d3282e user: drh tags: trunk) | |
| 17:13 | Add a few simple TCL test cases for generated columns. (Full test coverage of the generated column logic is provided separately by TH3.) (check-in: acedb5c7 user: drh tags: trunk) | |
| 13:16 | • Fixed ticket [1d2a8efc]: VACUUM on table with generated column that uses TYPEOF results in an error plus 6 other changes (artifact: 6088e629 user: drh) | |
| 13:16 | Ignore differences in Expr.op2 in sqlite3ExprCompare() in cases where it does not matter. Ticket [1d2a8efc6c3a595a]. (check-in: 32982067 user: drh tags: trunk) | |
| 12:30 | Enhance the TreeView logic to show information about Expr.op2 for FUNCTION and COLUMN nodes. (check-in: aceeaf9e user: drh tags: trunk) | |
|
2019-10-30
| ||
| 18:50 | • Fixed ticket [830277d9]: Non-deterministic date/time functions allowed in CHECK constraints plus 3 other changes (artifact: cfa6b870 user: drh) | |
| 18:50 | Always disallow the use of non-deterministic functions in CHECK constraints, even date/time functions that use the 'now' or similar keywords. Provide improved error messages when this requirement is not met. Ticket [830277d9db6c3ba1] (check-in: 2978b65e user: drh tags: trunk) | |
| 16:29 | Simplify the bytecode generation for SQL function calls such that the OP_Function or OP_PureFunc opcodes are coded directly, rather than using the intermediate OP_Function0 or OP_PureFunc0 - opcodes that are now removed. (check-in: 84e02d77 user: drh tags: trunk) | |
| 13:00 | New tokens ALWAYS, GENERATED, and STORED used by generated columns should all be fallback tokens. (check-in: 13fe6978 user: drh tags: trunk) | |
| 10:33 | • Ticket [830277d9] Non-deterministic date/time functions allowed in CHECK constraints status still Open with 6 other changes (artifact: e6974b73 user: drh) ... 1 similar event omitted. | |
|
2019-10-29
| ||
| 16:19 | • Fixed ticket [6484e6ce]: VACUUM on table with generated column results in an error plus 6 other changes (artifact: 56f2a7d5 user: drh) | |
| 16:18 | Remove the legacy_file_format PRAGMA. In its place, provide the SQLITE_DBCONFIG_LEGACY_FILE_FORMAT option to sqlite3_db_config(). Fix for ticket [6484e6ce678fffab] (check-in: 4d424f30 user: drh tags: trunk) | |
| 03:39 | • Fixed ticket [166347c6]: VACUUM issue on table with generated column plus 6 other changes (artifact: 637c9317 user: drh) | |
| 03:39 | Tighten the generated column requirement such that every table must have at least one non-generated column. Ticket [166347c6fc994155]. (check-in: 4fba090e user: drh tags: trunk) | |
| 03:30 | • Fixed ticket [9621dd78]: Segfault when updating table with generated columns plus 5 other changes (artifact: 2ffdd4bb user: drh) | |
| 03:30 | Add a missing translation from table column numbers to storage table numbers while processing constraints on an UPDATE statement. Ticket [9621dd78a024d07a] (check-in: 361ea81a user: drh tags: trunk) | |
| 01:26 | Disallow tables that have only virtual columns. (check-in: 59197321 user: drh tags: trunk) | |
|
2019-10-28
| ||
| 13:07 | Remove a NEVER() comparison from sqlite3ExprCompare(). (check-in: f4285297 user: drh tags: trunk) | |
| 04:20 | ALWAYS macro added for coverage. (check-in: a1e1ba91 user: drh tags: trunk) | |
|
2019-10-27
| ||
| 22:22 | • Fixed ticket [91e86951]: Segfault in table with generated columns plus 6 other changes (artifact: fee5eb53 user: drh) | |
| 22:22 | Improved detection of attempts to use a generated column as part of the primary key. Ticket [91e86951016a6802] (check-in: 6d1bbba9 user: drh tags: trunk) | |
|
2019-10-26
| ||
| 23:52 | • Fixed ticket [3ea17551]: REINDEX causes "UNIQUE constraint failed" error for generated column plus 4 other changes (artifact: 9377cbb6 user: drh) | |
| 23:51 | Remove code from the constraint checker that generates virtual column values with the incorrect time. Turns out the the regular code for all other columns works correctly and so the incorrect special-case code is not actually needed. Fix for ticket [3ea175512444b0d1]. (check-in: 5b4c0f2d user: drh tags: trunk) | |
| 20:24 | • Ticket [3ea17551] REINDEX causes "UNIQUE constraint failed" error for generated column status still Open with 7 other changes (artifact: be09321c user: drh) | |
| 18:56 | Remove redundant code resulting from a merge error on the previous check-in. (check-in: 713fe86b user: drh tags: trunk) | |
| 18:47 | Add support for generated columns. (check-in: b855acf1 user: drh tags: trunk) | |
| 17:08 | Performance optimization on sqlite3GenerateConstraintChecks() - bypass the loop that checks each column for NOT NULL constraints if it is known in advance that the table has no NOT NULL constraints. (check-in: e3c3f4d7 user: drh tags: trunk) | |
| 16:39 | • Fixed ticket [c1e19e12]: Trigger causes query to compute incorrect result plus 4 other changes (artifact: 03ce838d user: drh) | |
| 16:38 | Clarify some comments and add assert() and testcase() macros to the replace-trigger recheck logic for ticket [c1e19e12046d23fe] (check-in: 8c0042bd user: drh tags: trunk) | |
| 16:02 | Fix a problem in the legacy ".explain on" formatting when it is used on a query with more than 8 output columns. (check-in: 070b4982 user: drh tags: trunk) | |
| 15:40 | Minor changes to help ensure the pointer returned by sqlite3VdbeGetOp() is not used after it becomes invalid. (check-in: 346bdd49 user: drh tags: trunk) | |
| 12:27 | Overnight, OSSFuzz helpfully pointed out a potential use-after-free bug in yesterdays changes, involving continued use of a pointer after the memory pointed to had been realloc()-ed. Thanks Google. (check-in: c422afb5 user: drh tags: trunk) | |
| 01:43 | Add missing VdbeCoverage() macro. Fix an off-by-one error in partial index handling. New test cases. Ticket [c1e19e12046d23fe] (check-in: 41cc8e3d user: drh tags: trunk) | |
| 00:04 | If replace triggers are run during uniqueness checking, then rerun all uniqueness checks a second time using the ABORT algorithm. Fix for ticket [c1e19e12046d23fe] (check-in: fbac0c65 user: drh tags: trunk) | |
|
2019-10-25
| ||
| 23:56 | • Ticket [c1e19e12] Trigger causes query to compute incorrect result status still Open with 3 other changes (artifact: 9fe96f0f user: drh) | |
| 14:46 | Performance optimization in sqlite3BtreeCursor(). (check-in: ea068b09 user: drh tags: trunk) | |
| 13:15 | • Ticket [c1e19e12] Trigger causes query to compute incorrect result status still Open with 6 other changes (artifact: d3b0913b user: drh) | |
|
2019-10-24
| ||
| 23:43 | Merge fixes from trunk. (Closed-Leaf check-in: 4ec57d88 user: drh tags: generated-columns) | |
| 21:02 | The previous fix was incomplete. It is also necessary to disable the Expr.y.pTab field when making the translation. (check-in: b99d5701 user: drh tags: generated-columns) | |
| 20:29 | Fix handling of covering indexes that use virtual columns. (check-in: e0f7e321 user: drh tags: generated-columns) | |
| 19:37 | • Fixed ticket [50c09fc2]: Crash on REPLACE INTO of a table with an AFTER DELETE trigger. plus 3 other changes (artifact: 24cd9b60 user: drh) | |
| 19:35 | Correction to check-in [bec5b6d4d083556d] so that it detects *all* triggers that might perturb the insertion cursor. Ticket [50c09fc2cf0d91ce]. (check-in: 521f1d36 user: drh tags: trunk) | |
| 19:33 | • Ticket [50c09fc2] Crash on REPLACE INTO of a table with an AFTER DELETE trigger. status still Open with 6 other changes (artifact: 6e1ee2af user: drh) ... 1 similar event omitted. | |
| 01:04 | Do not allow ALTER TABLE ADD COLUMN for a STORED column. (check-in: 42fc08bc user: drh tags: generated-columns) | |
|
2019-10-23
| ||
| 21:00 | Add an experimental set of UUID processing functions as the uuid.c extension in ext/misc/uuid.c. (check-in: 1a6e0093 user: drh tags: trunk) | |
| 18:09 | • Fixed ticket [135c9da7]: Comparison of row values with COLLATE NOCASE yields incorrect result plus 6 other changes (artifact: 8f2a03f8 user: drh) | |
| 18:09 | When a vector comparison appears in the WHERE clause and the constraint side has a COLLATE clause on the first term of the vector, be sure to honor that COLLATE clause. Ticket [135c9da7513e5a97]. (check-in: 978b2d20 user: drh tags: trunk) | |
| 15:47 | Minor adjustments for clarity and test coverage. (check-in: 30065716 user: drh tags: generated-columns) | |
| 03:53 | Fix incorrect arguments to testcase() macros. (check-in: 812467fb user: drh tags: generated-columns) | |
| 00:31 | Fix the foreign key logic to be compatible with generated columns. (check-in: 3de57145 user: drh tags: generated-columns) | |
|
2019-10-22
| ||
| 21:01 | Take the declared column time into account when computing the values for generated columns, and apply appropriate affinity. (check-in: 9e04ba22 user: drh tags: generated-columns) | |
| 20:16 | Merge the row-value fix from trunk. (check-in: 1fbd7438 user: drh tags: generated-columns) | |
| 19:51 | • Fixed ticket [6ef984af]: Row value comparison yields incorrect result plus 5 other changes (artifact: 52b4cb44 user: drh) | |
| 19:51 | Disqualify row-value comparisons for use by an index if the right-hand side has an affinity that does not match the index. Fix for ticket [6ef984af8972c2eb] (check-in: 5c118617 user: drh tags: trunk) | |
| 15:45 | Do not allow generated columns in the PRIMARY KEY. (check-in: 1a54743a user: drh tags: generated-columns) | |
| 13:59 | In UPDATE processing, include generated columns in the set of columns being updated if and only if their generator expressions reference some other column that is being updated. (check-in: d38176e9 user: drh tags: generated-columns) | |
| 13:01 | New testcase() macros. Fix a problem with INSERT when the IPK is to the right of generated columns. (check-in: 412799fc user: drh tags: generated-columns) | |
| 12:02 | Merge changes on trunk into the generated-columns branch. (check-in: ba123b8c user: drh tags: generated-columns) | |
| 11:29 | Previous check-in to fix [b47e3627ecaadbde] was incomplete. This check-in completes the fix and adds a test cases. (check-in: c7da1c01 user: drh tags: trunk) | |
| 01:00 | Move the sqlite3LocateCollSeq(), sqlite3FindCollSeq(), and sqlite3GetCollSeq() routines so that they are all beside one another in the callback.c source file. No logic changes. (check-in: 9ff80a9b user: drh tags: trunk) | |
| 00:03 | • Fixed ticket [b47e3627]: Comparison of row values results in incorrect result plus 5 other changes (artifact: f7f3b529 user: drh) | |
| 00:03 | When flipping ("commuting") a comparison operator, set the new EP_Commuted bit rather than adding extra EP_Collate bits, to single later processing that the order of precedence for COLLATE operators is inverted. Fix for ticket [b47e3627ecaadbde] (check-in: 90f7c477 user: drh tags: trunk) | |
|
2019-10-21
| ||
| 23:41 | Add a VdbeCoverage() macro that was omitted from check-in [eea1e7aa57e74c43]. (check-in: cd2317d0 user: drh tags: trunk) | |
| 16:15 | Try to fix a harmless compiler warning reported by ICC. (check-in: 7f41b44c user: drh tags: trunk) | |
| 01:04 | Changes to the INSERT logic to make it simpler and faster and so that it works with generated columns and BEFORE triggers. (check-in: bc368cb0 user: drh tags: generated-columns) | |
|
2019-10-19
| ||
| 18:47 | Work toward getting generated columns to work with triggers. Still more work to do in this area. (check-in: 932a3727 user: drh tags: generated-columns) | |
| 15:01 | Add testcase macros. (check-in: fb9c9bb2 user: drh tags: generated-columns) | |
| 13:29 | Refactor names of column index transformation functions, for clarity. Get generated columns working with ALTER TABLE RENAME COLUMN. (check-in: 27ab41c9 user: drh tags: generated-columns) | |
|
2019-10-18
| ||
| 18:33 | Fixes for WITHOUT ROWID tables with VIRTUAL columns and an INTEGER PRIMARY KEY. (check-in: 86074da0 user: drh tags: generated-columns) | |
| 17:47 | Merge trunk enhancements into the generated-columns branch. (check-in: 85bc4524 user: drh tags: generated-columns) | |
| 17:42 | Get generated columns working for WITHOUT ROWID tables. (check-in: 9f409649 user: drh tags: generated-columns) | |
| 15:58 | Enhance the ".imposter" command in the CLI so that the first argument can be an existing WITHOUT ROWID table instead of an index. The resulting imposter is the same table, but with columns in storage order and with all constraints removed. (check-in: 9dc0d345 user: drh tags: trunk) | |
| 12:52 | Claw back some performance from the sqlite3ExprGetColumnOfTable() routine. (check-in: e8426acb user: drh tags: generated-columns) | |
| 12:14 | Fix sqlite3ColumnOfIndex() to account for virtual columns. (check-in: 44727112 user: drh tags: generated-columns) | |
| 10:05 | Get indexes working on virtual columns. (check-in: 450c4876 user: drh tags: generated-columns) | |
| 02:19 | STORED columns can now reference other STORED columns, in any order, as long as there are not loops. (check-in: 0d236698 user: drh tags: generated-columns) | |
|
2019-10-17
| ||
| 18:35 | In the Table object, change the nVCol field to nNVCol - the number of non-virtual columns, as that is the quantity that we need most. (check-in: 4ad66af0 user: drh tags: generated-columns) | |
| 18:07 | Bug fix with INSERT using an explicit column list on a table with a non-final STORED column. (check-in: 61b4459a user: drh tags: generated-columns) | |
| 17:54 | Some (but not all) INSERT and UPDATE statements now work for STORED columns. (check-in: fe7517bf user: drh tags: generated-columns) | |
| 16:16 | Fix the xfer optimization for generated columns, so that VACUUM works again. (check-in: 8f67b89b user: drh tags: generated-columns) | |
| 15:59 | • Edit [c21959d4eb5d742a|c21959d4]: Edit check-in comment. (artifact: 0394570b user: drh) | |
| 15:59 | Basic UPDATE functionality working for VIRTUAL columns. (check-in: c21959d4 user: drh tags: generated-columns) | |
| 14:21 | Bug fixes so that "make test" once against runs with no errors. (check-in: 7bfe0f67 user: drh tags: generated-columns) | |
| 13:15 | Fix the table_info and table_xinfo pragmas so that they work with virtual columns. Table_info omits virtual columns. Table_xinfo gives them a "hidden" flag of 2, and 3 for STORED columns. (check-in: 069351b8 user: drh tags: generated-columns) | |
|
2019-10-16
| ||
| 22:01 | INSERT with named columns for a table with generated columns. (check-in: 64db39f9 user: drh tags: generated-columns) | |
| 20:05 | ALTER TABLE is able to add a VIRTUAL column. (check-in: 120c6b78 user: drh tags: generated-columns) | |
| 19:31 | Simple INSERT and SELECT operations working with VIRTUAL columns. (check-in: 7f9f90b1 user: drh tags: generated-columns) | |
| 14:56 | • Fixed ticket [a8a4847a]: Trigger inserts duplicate value in UNIQUE column plus 6 other changes (artifact: 077f1b97 user: drh) | |
| 14:56 | If an AFTER DELETE trigger fires when a conflict row is deleted by REPLACE conflict resolution, make sure the conflict really has been resolved and that the trigger did not recreate the row before continuing. Ticket [a8a4847a2d96f5de] (check-in: eea1e7aa user: drh tags: trunk) | |
| 12:18 | Initial experimental code for generated column support. Non-functional. (check-in: 11d472c1 user: drh tags: generated-columns) | |
|
2019-10-15
| ||
| 19:01 | Formatting change on a multi-line conditional, for improved clarity. No logic changes. (check-in: 7248e347 user: drh tags: trunk) | |
|
2019-10-14
| ||
| 20:32 | Futher improvements to the IN operator for row-values on virtual tables. (check-in: bc751fb6 user: drh tags: trunk) | |
| 15:24 | New test cases in test/fuzzdata8.db. (check-in: 344d9cb0 user: drh tags: trunk) | |
|
2019-10-12
| ||
| 23:38 | When Select-Trace is enabled (in debugging builds only) do not show the result of Window function tree rewrites if there are no window functions. (check-in: d1acf72a user: drh tags: trunk) | |
|
2019-10-11
| ||
| 17:26 | • Fixed ticket [278ac142]: FTS integrity_check fails when inserting x'00' plus 6 other changes (artifact: 85b9e38f user: drh) | |
| 17:25 | • Edit [629e20c9880acc2c|629e20c9]: Edit check-in comment. (artifact: 77445473 user: drh) | |
| 17:14 | Futher improvements to LEFT JOIN strength reduction. (check-in: 8a39167b user: drh tags: trunk) | |
| 16:31 | • Edit [7833feecfe745e23|7833feec]: Edit check-in comment. (artifact: 0aa59d95 user: drh) | |
| 16:01 | Improvements to the LEFT JOIN strength reduction optimization. (check-in: 548082df user: drh tags: trunk) | |
| 14:25 | Increase the version number to 3.31.0 for the next release cycle. (check-in: ffd4c306 user: drh tags: trunk) | |
| 14:21 | Faster response to sqlite3_interrupt() in the OP_IntegrityCk and OP_Count opcodes. (check-in: bf875dc5 user: drh tags: trunk) | |
| 11:21 | Merge the 3.30.1 changes into reuse-schema. (Leaf check-in: eff7cd7f user: drh tags: reuse-schema-3.30) | |
|
2019-10-10
| ||
| 20:19 | Version 3.30.1 (check-in: 18db032d user: drh tags: release, version-3.30.1, branch-3.30) | |
| 16:21 | Avoid assuming that an expression that contains the sub-expression (? IS FALSE) or (? IS TRUE) may only be true if ? is non-null. Fix for [a976c487]. (check-in: c6cc2390 user: drh tags: branch-3.30) | |
| 16:10 | Fix a problem with running ALTER TABLE ADD COLUMN statements within a transaction that writes to one or more virtual tables. Fix for [8fe768e9]. (check-in: a4974a0f user: drh tags: branch-3.30) | |
| 15:57 | Fix the OP_SeekRowid opcode so that it works correctly with a Real argument without damaging the value in the register that is the argument. Ticket [b2d4edaffdc156cc]. Test cases in TH3. (check-in: b02630fe user: drh tags: branch-3.30) | |
| 15:48 | Be sure to rewrite column references inside FILTER clauses and window frame definitions when flattening queries. Fix for [1079ad19]. (check-in: df2060f3 user: drh tags: branch-3.30) | |
| 15:42 | Version number to 3.30.1. (check-in: 12e28cc7 user: drh tags: branch-3.30) | |
|
2019-10-09
| ||
| 17:38 | Merge recent fixes and enhancements from trunk. (check-in: 553258c2 user: drh tags: 2-size-lookaside) | |
| 15:37 | An improved fix for the dbsqlfuzz-discovered ALWAYS() failure following OOM in sqlite3ExprCollSeq(). This time with a test case (engineered by Dan). (check-in: 907f7965 user: drh tags: trunk) | |
| 15:08 | Remove the "fastfuzztest" makefile target. Use only "fuzztest". (check-in: e17571c7 user: drh tags: trunk) | |
| 15:03 | New test cases added to test/fuzzdata8.db. (check-in: b68d21e9 user: drh tags: trunk) | |
| 15:00 | Change sqlite3SelectDup() to always return NULL if an OOM has occurred. (check-in: 01ba4641 user: drh tags: trunk) | |
| 13:52 | Use the "fuzztest" target in place of "fastfuzztest". (Closed-Leaf check-in: 7129e468 user: drh tags: makefile-cleanup) | |
| 13:49 | • Edit [3d44f1ee0f606409|3d44f1ee]: Move to branch makefile-cleanup. (artifact: fed98b9c user: drh) | |
| 13:12 | Remove the obsolete "fastfuzztest" target from the makefiles. (check-in: 3d44f1ee user: drh tags: makefile-cleanup) | |
| 01:19 | Save CPU cycles in sqlite3Prepare() by, among other things, shifting the EXPLAIN column label logic over to sqlite3VdbeMakeReady(). (check-in: 1ca5ef84 user: drh tags: trunk) | |
|
2019-10-07
| ||
| 20:33 | Omit a pointless memory allocation in vdbeSorterSort(). (check-in: 5d76dbc5 user: drh tags: trunk) | |
| 13:26 | Fix a faulty assert() statement in the sqlite3VdbeMemExpandBlob() routine. (check-in: 69a26ead user: drh tags: trunk) | |
| 01:07 | • Fixed ticket [b2d4edaf]: Comparison on view malfunctions plus 6 other changes (artifact: ce5528e0 user: drh) | |
| 01:05 | Fix the OP_SeekRowid opcode so that it works correctly with a Real argument without damaging the value in the register that is the argument. Ticket [b2d4edaffdc156cc]. Test cases in TH3. (check-in: 3cde82c8 user: drh tags: trunk) | |
|
2019-10-05
| ||
| 19:53 | Omit the check for conflicting shared-cache locks in sqlite3Prepare() if the database connection uses no shared cache. We might be able to go back and remove this code completely, due to the newer Schema.iGeneration logic, but that will take more analysis. This check-in gives the speed benefit but not the reduction in code size. (check-in: 0b73a092 user: drh tags: trunk) | |
| 19:24 | Optimization to sqlite3VtabUnlockList() for the common case when there is no work to do. (check-in: fc8d4508 user: drh tags: trunk) | |
| 18:33 | Call sqlite3Prepare() directly, rather than going through sqlite3_prepare(), when processing the sqlite_master.sql column for a schema. (check-in: cc49380e user: drh tags: trunk) | |
| 15:28 | Reorder two comparisons for a small performance gain in OP_Transaction. (check-in: d7667f65 user: drh tags: trunk) | |
| 14:39 | Performance optimization to the lookaside-memory disabling mechanism. (check-in: 17ce1c49 user: drh tags: trunk) | |
|
2019-10-04
| ||
| 16:24 | Bring the begin-concurrent-pnu-wal2 branch up-to-date with 3.30.0. (check-in: dd09f7ce user: drh tags: begin-concurrent-pnu-wal2) | |
| 16:15 | Bring the wal2 branch up to date with version 3.30.0 (check-in: 16e1dced user: drh tags: wal2) | |
| 16:08 | Bring the begin-concurrent-pnu branch up-to-date with version 3.30.0. (check-in: a4d26bcf user: drh tags: begin-concurrent-pnu) | |
| 15:52 | Bring the begin-concurrent branch up-to-date with the 3.30.0 release. (check-in: abd1b4df user: drh tags: begin-concurrent) | |
| 15:41 | Bring the apple-osx branch up-to-date with the 3.30.0 release. (check-in: 76b26aca user: drh tags: apple-osx) | |
| 15:31 | Bring the reuse-schema branch up-to-date with version 3.30.0. (check-in: 6e09afec user: drh tags: reuse-schema) | |
| 15:03 | Version 3.30.0 (check-in: c20a3533 user: drh tags: trunk, release, version-3.30.0) | |
|
2019-10-03
| ||
| 14:51 | Increase the precision of floating point value display in VDBE debugging output. No changes to normally deployed code. (check-in: a561a656 user: drh tags: trunk) | |
|
2019-10-02
| ||
| 19:44 | Update error detection logic in releasetest.tcl to account for new output formats in USAN. (check-in: 3f36b988 user: drh tags: trunk) | |
| 00:25 | Disable sqlite3_drop_module() tests when virtual tables are omitted from the build. (check-in: 9f4035f9 user: drh tags: trunk) | |
|
2019-10-01
| ||
| 21:31 | Remove references to test scripts analyzeA.test and analyzeB.test from permutations.test, since those test modules no longer exist. (check-in: 23948796 user: drh tags: trunk) | |