Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
113 events for the month beginning 2010-05-01 by user drh
Following month ↑|
2010-05-31
| ||
| 20:28 | Fix issues with locking_mode=EXCLUSIVE in WAL. (check-in: 8deba0ce user: drh tags: wal-incr-ckpt) | |
| 18:24 | Add an "isInit" field in the wal-index header that must be non-zero for a valid header. Use this to detect an uninitialized wal-index. (check-in: a16fde19 user: drh tags: wal-incr-ckpt) | |
| 16:56 | Fix an inconsistent #ifdef in wal.c. Fix os_unix.c so that it does not allow moving an SHM lock directly exclusive to shared without going through unlocked. (check-in: 552658da user: drh tags: wal-incr-ckpt) | |
| 16:10 | Get the new xShmLock interface design working on os_win.c. (check-in: 149a7082 user: drh tags: wal-incr-ckpt) | |
| 14:39 | Make sure WAL alway requests enough shared-memory space. (check-in: 138f1283 user: drh tags: wal-incr-ckpt) | |
| 14:28 | Remove the tests that enable tracing based on the existance of the "vdbe_*" files when in SQLITE_DEBUG mode. (check-in: cdbb4e7c user: drh tags: wal-incr-ckpt) | |
| 13:11 | Change WAL test cases to account for the improved concurrency in the new checkpoint logic. (check-in: 2d6f2485 user: drh tags: wal-incr-ckpt) | |
| 12:30 | Do not fail a checkpoint just because active readers prevent backfill. (check-in: 9aa4243e user: drh tags: wal-incr-ckpt) | |
| 12:15 | Add WALTRACE() macros to help with debugging and analysis. (check-in: 765c3318 user: drh tags: wal-incr-ckpt) | |
| 01:41 | WAL runs but quickly deadlocks. (check-in: ace58acb user: drh tags: wal-incr-ckpt) | |
|
2010-05-30
| ||
| 19:55 | Initial code for incremental checkpoint in WAL mode. This check-in compiles on unix and runs as long as you do not engage WAL mode. WAL mode crashes and burns. Consider this check-in a baseline implementation for getting the new capability up and running. (check-in: ef3ba7a1 user: drh tags: wal-incr-ckpt) | |
|
2010-05-26
| ||
| 17:31 | Make sure the wal-index mapping is always large enough to cover the entire active area of the wal-index. (check-in: 42705bab user: drh tags: trunk) | |
| 15:06 | Change the semantics of xShmGet() such that it will never increase the size of shared memory. xShmSize() must be used to grow the size of shared memory. A shared memory segment size cannot be shrunk (except by dropping it). (check-in: 72de0073 user: drh tags: trunk) | |
|
2010-05-25
| ||
| 15:53 | Updated header comments in wal.c. No functional code changes. (check-in: 687632a6 user: drh tags: trunk) | |
| 13:40 | Update header comments in wal.c to correctly describe the WAL file format. Update the locking region offsets in os_unix.c and os_win.c and add assert() statement to verify that the locking region offsets are correct. (check-in: 40030c07 user: drh tags: trunk) | |
| 02:24 | Remove unreachable code associated with WAL from the pager. (check-in: 54c1718e user: drh tags: trunk) | |
|
2010-05-24
| ||
| 20:27 | OOM errors during an auto-checkpoint are benign. (check-in: 3d252ce5 user: drh tags: trunk) | |
| 20:24 | Remove the walmode.test case from the inmemory_journal test of permutations.test. (check-in: 27ba9c21 user: drh tags: trunk) | |
| 17:00 | Fix the wal2.test script so that it works in auto_vacuum mode. (check-in: 6a818afb user: drh tags: trunk) | |
| 13:28 | Make sure a WAL frame of all zeros is detected as an invalid frame. (check-in: 02d99ad4 user: drh tags: trunk) | |
| 12:34 | Fix up test_osinst.c to work with SQLITE_OMIT_VIRTUALTABLE. (check-in: 51fd3815 user: drh tags: trunk) | |
|
2010-05-22
| ||
| 00:55 | Add several EXPENSIVE_ASSERT code blocks to validate the wal-index hash table. Fix the bugs that these code blocks fine. Rename walClearHash() to walCleanupHash() and simplify its interface. (check-in: 7aade899 user: drh tags: trunk) | |
|
2010-05-21
| ||
| 18:24 | Comment out the SQLITE_FCNTL_SIZE_HINT from os_unix.c since it does not seem to provide any performance gain there. (check-in: 7d01309d user: drh tags: trunk) | |
| 13:16 | Fix the wal-index header read routine so that it correctly detects a zero header as being malformed and in need of a wal-index rebuild. (check-in: 1a4eb3a3 user: drh tags: trunk) | |
|
2010-05-20
| ||
| 23:51 | Add a new xShmBarrier method to the VFS - a shared-memory fence operation. Implement the same in both unix and win32. Use it to make the WAL subsystem more robust. (check-in: 1bd011c9 user: drh tags: trunk) | |
| 21:21 | Make use of the extra information in the WAL header and frame header to enhance robustness. (check-in: 9580ecb7 user: drh tags: trunk) | |
| 16:45 | Convert the wal-header and frame-header to 24 bytes. Extra information in both headers is designed to enhance robustness after crashes, though the extra information is currently unused. This is a snapshot of a work in progress. (check-in: 66970643 user: drh tags: trunk) | |
|
2010-05-19
| ||
| 22:09 | Cherry-pick the SQLITE_FCNTL_SIZE_HINT patch (check-in [2b7e3b4a30d6a7c4a8] and bump the version number to 3.6.23.2. (check-in: 776679af user: drh tags: branch-3.6.23) | |
| 20:30 | Disable the corruptE test which SQLITE_OVERSIZE_CELL_CHECK is enabled. This is a cherrypick merge from check-in [1dc4f9fe9b83467ba]. (check-in: a40d080c user: drh tags: branch-3.6.23) | |
| 19:39 | Add the SQLITE_FCNTL_SIZE_HINT to the os_win.c VFS. (check-in: 9894118d user: drh tags: trunk) | |
| 19:26 | Add the SQLITE_FCNTL_SIZE_HINT operator to sqlite3_file_control() and use it to give the VFS hints about the ultimate size of a database file when the file is growing. (check-in: 2b7e3b4a user: drh tags: trunk) | |
| 19:09 | Fix a bug in the new checkpoint computation. Also update the checkpoint algorithm in the test scripts to align with the new implementation. (check-in: 8b6056f2 user: drh tags: trunk) | |
| 18:08 | Revise the checksumming algorithm in wal.c. More variable refactoring. (check-in: 542b90eb user: drh tags: trunk) | |
| 17:49 | Refactoring some variable names in wal.c. (check-in: 1d201ff5 user: drh tags: trunk) | |
| 16:24 | • Edit [97d88a86e45e7a42|97d88a86]: Change branch background color to "#c0c0c0". Move to branch branch-3.6.1-exp. Edit check-in comment. Timestamp 2010-05-18 12:37:05. (artifact: e1da89a9 user: drh) | |
| 01:53 | Add a large comment to wal.c describing the WAL and wal-index file formats. (check-in: a71a22b5 user: drh tags: trunk) | |
|
2010-05-18
| ||
| 23:29 | Update the wal-index hash format so that hash-table space is reused following a rollback, thus preventing hash table overflows. Add assert()s to verify that hash tables do not overfill. Further refactoring of the wal-index code. (check-in: ada9a8c7 user: drh tags: trunk) | |
| 18:01 | Refactoring of the WalIterator implementation. (check-in: b5b60fdc user: drh tags: trunk) | |
| 13:27 | Mark the shared-memory in the WAL implementation as volatile. (check-in: 0a678790 user: drh tags: trunk) | |
| 12:56 | Comment clarifications in wal.c. (check-in: a029be10 user: drh tags: trunk) | |
| 12:37 | Keep additional state information in the pager in an effort to reduce the number of SQLITE_FCNTL_SIZE_HINTs. (Note: This change was found to make no performance difference and so has been moved onto a side branch. Use the parent check-in instead of this one.) (Closed-Leaf check-in: 97d88a86 user: drh tags: branch-3.6.1-exp) | |
|
2010-05-17
| ||
| 20:16 | Remove an unreachable test from wal.c. (check-in: 7162c456 user: drh tags: trunk) | |
| 15:52 | An improvement to the SQLITE_FCNTL_SIZE_HINT change that invokes the hint less often and only when really needed. (check-in: a1d20ceb user: drh tags: branch-3.6.1) | |
| 15:33 | Invoke the SQLITE_FCNTL_SIZE_HINT opcode on the sqlite3_file_control() interface for database files before extending the size of the file. The VFS can use this hint to preallocate space. (check-in: 9a083711 user: drh tags: branch-3.6.1) | |
|
2010-05-15
| ||
| 01:09 | Silently ignore errors trying to set the default journal_mode while doing an ATTACH. (check-in: b9af4ad2 user: drh tags: trunk) | |
|
2010-05-14
| ||
| 20:15 | Fix a typo that (by bad luck) was not a syntax error but which caused some important lines of code to be skipped when SQLITE_DEBUG was not used. (check-in: 9ef99d97 user: drh tags: trunk) | |
| 19:24 | • Fixed ticket [dd08e5a9]: Foreign key constraint fails to prevent consistency error. plus 2 other changes (artifact: d0c360fc user: drh) | |
| 19:24 | Make sure the value of an INTEGER PRIMARY KEY column supplied to triggers and especially to FK constraints really contains the ROWID and not the NULL that is stored in the column itself. Ticket [dd08e5a988d00dec]. (check-in: 636f8609 user: drh tags: trunk) | |
| 18:20 | • New ticket [dd08e5a9] Foreign key constraint fails to prevent consistency error.. (artifact: 9f47adfd user: drh) | |
| 16:34 | Pull in all the latest changes from the trunk. Update the win32 SHM methods to work with the new interface design. (Closed-Leaf check-in: 4b69f2cd user: drh tags: wal-win32) | |
| 14:52 | Simplifications to the SHM implementation in os_unix.c, taking advantage of the removal of the LinuxThreads mess. (check-in: d1debe5d user: drh tags: trunk) | |
| 12:43 | Simplify os_unix.c by removing support for LinuxThreads. Linux systems must either use NPTL or else not share database connections across threads. (check-in: e294b696 user: drh tags: trunk) | |
| 11:30 | Change the OSTRACEn() macro to OSTRACE(()). Also rename some internal fields and variables in os_unix.c to be more meaningful and searchable. (check-in: 5fe529f2 user: drh tags: trunk) | |
|
2010-05-13
| ||
| 20:19 | • Fixed ticket [51914f6a]: nRef and owner should be #ifdef SQLITE_DEBUG plus 2 other changes (artifact: 0e16051d user: drh) | |
| 20:19 | Make debugging elements of the sqlite3_mutex object volatile and make them only appear when compiling with SQLITE_DEBUG. Ticket [51914f6acd2cb462]. (check-in: e823c60c user: drh tags: trunk) | |
| 15:44 | Allow sqlite3WalCheckpoint() to be called even if the WAL is in the SQLITE_SHM_READ state, as sometimes happens after an error. (check-in: 175b296f user: drh tags: trunk) | |
| 09:11 | Make sure xShmGet is never called while already holding the shared-memory segment. (check-in: 92ebdbc5 user: drh tags: trunk) | |
| 08:53 | The refactored of VFS SHM primitives are now working so merge the wal-refactor branch back into the trunk. (check-in: bce21c18 user: drh tags: trunk) | |
| 08:44 | • Edit [ee13c8849d234931|ee13c884]: Move to branch mistake. Change background color to "#ffc0d0". Edit check-in comment. Timestamp 2010-05-12 19:02:36. (artifact: 90e0ec7c user: drh) | |
| 08:33 | Change the xShmSize() implementation in os_unix.c so that it will only increase and never decrease the size of a shared-memory segment. (Closed-Leaf check-in: 149d2ae4 user: drh tags: wal-refactor) | |
|
2010-05-12
| ||
| 18:30 | Fix for the test_devsym.c test module for the VFS-SHM refactoring. (check-in: 49d62933 user: drh tags: wal-refactor) | |
| 18:10 | A couple simple fixes to get wal.test mostly working. (check-in: c7445812 user: drh tags: wal-refactor) | |
| 18:01 | Refactoring the VFS-SHM methods used by WAL. This version compiles and runs non-WAL test cases but crashes and burns on wal.test. (check-in: 2b00152c user: drh tags: wal-refactor) | |
| 13:50 | Remove the OP_Variable optimization of check-in [48b77b04935d894] since it can lead to malfunctions as described in ticket [26ff0c82d1e90]. (check-in: 7838163d user: drh tags: trunk) | |
| 12:12 | • New ticket [26ff0c82] Incorrect result when using unnamed "?" bindings. (artifact: 3e0dd9c8 user: drh) | |
|
2010-05-11
| ||
| 14:00 | When an attempt to change journal_mode fails due to locks, be sure to leave internal structures in a consistent state. (check-in: cf3d1e0b user: drh tags: trunk) | |
|
2010-05-10
| ||
| 19:51 | Fix an off-by-one error while constructing the name of the mmap file for the wal-index under os_unix.c. (check-in: 6e3735f7 user: drh tags: trunk) | |
| 17:29 | Fix an uninitialized variable in OSX proxy locking. (check-in: 96d6eaf4 user: drh tags: trunk) | |
| 14:10 | If an ATTACH command fails due to OP_JournalMode but still attaches the database, make sure VACUUM still detaches it when done. (check-in: 6ecdc7ba user: drh tags: trunk) | |
| 11:20 | Enhance the OP_JournalMode opcode with an ignore-errors option and use that option the ATTACH command. (check-in: 0bdea4cf user: drh tags: trunk) | |
|
2010-05-07
| ||
| 20:34 | When running a checkpoint while in locking_mode=EXCLUSIVE, be sure to move the wal-index lock to UNLOCK from READ prior to promoting to CHECKPOINT. (check-in: be114bdf user: drh tags: trunk) | |
| 20:02 | Change the xShmOpen() method of the VFS to take the database file name as its argument, not the WAL file name. Also fix some unrelated compiler warnings. (check-in: a65c2939 user: drh tags: trunk) | |
| 18:23 | Additional tweaks to API documentation. No functional code changes. (check-in: e1230782 user: drh tags: trunk) | |
| 13:57 | Updates to documentation on the C interfaces supporting WAL. No functional changes to code. (check-in: 681ba20c user: drh tags: trunk) | |
| 00:28 | Another attempt to fix permutations.test so that it excludes WAL tests from the journaltest permutation. (check-in: 58c40442 user: drh tags: trunk) | |
|
2010-05-06
| ||
| 22:21 | Remove savepoint6.test from the set of tests run by journaltest since savepoint6.test uses journal_mode=WAL. (check-in: 811b45a9 user: drh tags: trunk) | |
| 21:37 | The PRAGMA journal_mode=WAL; command now makes WAL the default journal mode for new databases added with ATTACH, so the behavior is consistent with the other journal modes. (check-in: c3520460 user: drh tags: trunk) | |
| 20:19 | Make sure to do a clean shutdown of the library upon existing the shell in order to remove WAL files. (check-in: c1762dda user: drh tags: trunk) | |
| 19:55 | Exclude all WAL tests from the journaltest permutation. (check-in: 46c97d7e user: drh tags: trunk) | |
| 19:04 | Updates to the VFS SHM locking documentation. (check-in: 9927ce42 user: drh tags: trunk) | |
| 16:06 | After throwing an error to say that one cannot change into WAL mode within a tranactions, do not then go and change into WAL mode. (check-in: 56a17dae user: drh tags: trunk) | |
| 11:56 | Remove the noop-mutex implementations of mutex_held() and mutex_notheld() since they are both unreachable. (check-in: 6767b62a user: drh tags: trunk) | |
| 11:55 | Add two text files containing pager design notes to the doc/ subfolder. (check-in: ed817fc8 user: drh tags: trunk) | |
|
2010-05-05
| ||
| 20:00 | Change the behavior of the sqlite3_wal_hook() callback. It should now return SQLITE_OK or an error code and the error code is propagated back up the stack. If a checkpoint is desired, the callback should invoke sqlite3_wal_callback() itself. (check-in: 1b14195e user: drh tags: trunk) | |
| 19:09 | Further simplifications to the SHM locking logic. Remove the SQLITE_SHM_QUERY option. Unify the WRITE to READ and RECOVER to READ transitions. (check-in: e9bfa6e4 user: drh tags: trunk) | |
| 18:46 | Do not compare page sizes on source and destination of backup until transactions are started and the page sizes are locked. This is a fix to check-in [7bd44794c4]. (check-in: ec715778 user: drh tags: trunk) | |
| 18:20 | Simplifications to the SHM locking implementation in os_unix.c. (check-in: 9de05bfb user: drh tags: trunk) | |
| 16:23 | Prohibit backup if the destination is using WAL and has a different page size from the source. (check-in: 7bd44794 user: drh tags: trunk) | |
| 04:11 | Make sure the page size of the main database is fixed following a failed VACUUM attempt. Otherwise, two consecutive failed VACUUM attempts with attempted page_size changes on encrypted or WAL databases could result in database corruption. (check-in: 208e7d5d user: drh tags: trunk) | |
| 03:39 | Do not attempt to modify the page_size when running VACUUM on a WAL database. (check-in: 58a1a59b user: drh tags: trunk) | |
| 00:22 | Get the previous mutex fix working with SQLITE_DEBUG and with the amalgamation. (check-in: df19928f user: drh tags: trunk) | |
| 00:05 | When the in single-threaded mode, the sqlite3_mutex_alloc() interface still returns a non-NULL value. The mutex doesn't do anything, but it tests non-NULL. This way, extensions (or VFSes) that use sqlite3_mutex_alloc() can tell the difference between an OOM error and mutexes being disabled. (check-in: 451fd175 user: drh tags: trunk) | |
|
2010-05-04
| ||
| 18:50 | When sqlite3PagerPagecount() is called without any locks, always return the physical file size, not the logical file size. (check-in: 4016b422 user: drh tags: trunk) | |
| 17:38 | Be sure to release all wal-index locks before closing the wal-index. (check-in: b15b67fa user: drh tags: trunk) | |
| 17:20 | Relax an over-zealous assert() in sqlite3WalUndo(). (check-in: 8f9d22d5 user: drh tags: trunk) | |
| 16:33 | Take care not to invoke the xShmClose method of the VFS with a NULL shared memory object. (check-in: 1465d384 user: drh tags: trunk) | |
|
2010-05-03
| ||
| 19:20 | Unset some global TCL variables prior to use in test where prior tests can have those same variables set to an array value. (check-in: 49bef00e user: drh tags: trunk) | |
| 19:17 | Fix a bug in the computation of the current time for the alternative CURRENT_TIMESTAMP functions used when SQLITE_OMIT_DATETIME is defined. (check-in: e7ded46b user: drh tags: trunk) | |
| 18:51 | Documentation stubs for sqlite3_wal_autocheckpoint and sqlite3_wal_checkpoint. (check-in: 31376242 user: drh tags: trunk) | |
| 18:22 | Fix a bug in the xCurrentTime() method of the os_unix.c VFS. (check-in: 551df11a user: drh tags: trunk) | |
| 17:24 | Clear global variable "seconds" before use in walthread.test. (check-in: a35551a5 user: drh tags: trunk) | |
| 16:36 | Update the crash-test VFS in test6.c to pass-through the shared-memory methods to the real underlying VFS. This fixes the walcrash.test script. (check-in: ea09ff37 user: drh tags: trunk) | |
| 16:30 | Change the VFS definition so that all methods take a VFS object pointer as their first parameter. (check-in: 43b5b07f user: drh tags: trunk) | |
| 14:32 | Use VFS method xCurrentTimeInt64 instead of xCurrentTime when it is available. Provide an implementation of xCurrentTimeInt64 for os_unix.c. (check-in: ab77b3ae user: drh tags: trunk) | |
| 14:08 | Merge the write-ahead-logging changes into the trunk. (check-in: de9ae443 user: drh tags: trunk) | |
| 13:37 | Make sure the mutex is held while calling sqlite3ApiExit() in sqlite3_wal_checkpoint(). Other cleanup of WAL logic. (check-in: 11a85b82 user: drh tags: wal) | |
|
2010-05-01
| ||
| 20:17 | Change the SHM interface so that it does not take the name of the shared object but rather the name of the WAL file and derives its own name from that. Remove the xShmDelete method from the VFS and replace it with a delete flag on xShmClose. (check-in: 94dea5f9 user: drh tags: wal) | |
| 18:23 | Remove the xShmPush and xShmPull methods from the VFS. (check-in: 69e07fdb user: drh tags: wal) | |
| 17:57 | Define an invariant to guarantee deadlock-free operation of SHM in os_unix.c and check that invariant with assert() statements. (check-in: 6af2dca7 user: drh tags: wal) | |
| 17:50 | Rework mutexes on the SHM implemention for os_unix to avoid a deadlock during WAL recovery. (check-in: 1a0f69be user: drh tags: wal) | |
| 11:33 | Fix a typo in the walmode.test test script introducted yesterday. (check-in: dcabc90c user: drh tags: wal) | |
| 11:19 | Fix the sqlite3_mutex_alloc() interface to return NULL (not segfault) when operating in threadsafe mode. (This is a general-purpose bug fix which really ought to be ported to trunk.) (check-in: 64840a3c user: drh tags: wal) | |
| 00:59 | Do not allow journal_mode=WAL if the underlying VFS does not support xShmOpen. (check-in: d1fcccec user: drh tags: wal) | |