Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
735 check-ins using file test/triggerC.test version cac41fe3
|
2010-08-18
| ||
| 00:09 | Updating apple-osx with minor source fixes, database truncate and replace private calls and a bunch of conditionalization for tests running in different environments (check-in: 5e2ee7db user: adam tags: apple-osx) | |
|
2010-08-13
| ||
| 18:41 | Add tests to test file e_expr.test. (check-in: 3fd1059e user: dan tags: trunk) | |
| 16:38 | Do not apply the flattening optimization if the sub-query is DISTINCT. Fix for [e4b8a2ba6e]. (check-in: 497aafd8 user: dan tags: trunk) | |
|
2010-08-12
| ||
| 16:36 | If an error occurs in PagerSetPagesize(), set the output variable to the unmodified page-size before returning. (check-in: 02def8f9 user: dan tags: trunk) | |
| 11:25 | Add coverage tests for pager.c. (check-in: 228c5b16 user: dan tags: trunk) | |
| 02:41 | Increase the maximum page size from 32k to 64k. (check-in: 45362437 user: drh tags: trunk) | |
|
2010-08-11
| ||
| 18:56 | Improve coverage of pager.c. (check-in: 2fa05d01 user: dan tags: trunk) | |
| 12:26 | Update an r-tree extension test case to account for recent changes to the query planner. Also fix a comment in rtree.c. (check-in: eaaca669 user: dan tags: trunk) | |
| 11:59 | Use sqlite3DbFree() instead of sqlite3_free() to free any error message reported by the parser layer while attempting to parse a CREATE TABLE statement passed to sqlite3_declare_vtab(). (check-in: 7c674aab user: dan tags: trunk) | |
| 11:35 | Fixes to tcl test files so that they work in auto-vacuum mode. (check-in: ea9eaf74 user: dan tags: trunk) | |
| 06:14 | Fix memory allocation in proxy locking so that it works with SQLITE_MEMDEBUG. (check-in: f854cbe0 user: drh tags: trunk) | |
| 06:04 | Merge experimental changes into trunk. (check-in: aa092ac9 user: dan tags: trunk) | |
|
2010-08-10
| ||
| 15:46 | Fix a bug in pager.c causing it to omit the xSync() call required following a hot-journal rollback. (Closed-Leaf check-in: 42ba43ac user: dan tags: experimental) | |
| 09:58 | Add variable pager.dbHintSize, used to limit the number of calls made to the xFileControl(FCNTL_SIZE_HINT) method. (check-in: eb3ac895 user: dan tags: experimental) | |
| 07:12 | Changes to debugging code in mutex_unix.c and mutex_w32.c to make an assert() statement threadsafe. (check-in: e82e32bd user: dan tags: trunk) | |
|
2010-08-09
| ||
| 19:17 | Modify some comments in pager.c. (check-in: 5662da6d user: dan tags: experimental) | |
| 16:52 | Merge latest trunk changes with experimental branch. (check-in: aecbd890 user: dan tags: experimental) | |
| 16:12 | Fix a memory leak in test_journal.c causing tests to fail. (check-in: f229487c user: dan tags: experimental) | |
| 15:44 | Fix typos in comments. No functional changes to the code. (check-in: 9cebaf2d user: drh tags: trunk) | |
| 14:47 | Change to tcl test infrastructure so that --malloctrace=1 works when sizeof(int)!=sizeof(void*). (check-in: c3e771b3 user: dan tags: experimental) | |
| 14:26 | Fix two comment typos that were reported on the mailing list. (check-in: 88bf9016 user: drh tags: trunk) | |
| 07:51 | Fix a problem causing the return code of an xSync call to be ignored in wal.c. (check-in: f1b2b5f9 user: dan tags: experimental) | |
| 07:07 | In WAL mode, ignore any error returned by an xFileControl(FCNTL_SIZE_HINT) call. This matches the behaviour in rollback mode. (check-in: 158a3097 user: dan tags: experimental) | |
|
2010-08-07
| ||
| 16:17 | Fix minor problems and update comments in pager.c. (check-in: 92e45637 user: dan tags: experimental) | |
| 11:46 | Merge in all changes up to the 3.7.0.1 release. (check-in: f88c6367 user: drh tags: apple-osx) | |
| 09:31 | Fix a problem wherein changing the journal-mode immediately after leaving exclusive-locking mode could lead to the database being unlocked without clearing the changeCountDone flag. (check-in: 531abc80 user: dan tags: experimental) | |
| 05:15 | Add test case 'cgt_pager_1', intended for use with callgrind to detect performance regression in the pager module, to threadtest3.c. (check-in: b5d46f1e user: dan tags: experimental) | |
|
2010-08-06
| ||
| 19:00 | Remove all vestiges of ctype.h from FTS3. This addresses ticket [991789d9f3136a] among other bug reports. (check-in: b8b465ed user: drh tags: trunk) | |
| 17:18 | Further enhancements to comments in pager.c. (check-in: 876162c7 user: dan tags: experimental) | |
| 14:37 | Fix some problems with running test scripts with the inmemory_journal permutation. (check-in: 7bd8ba08 user: dan tags: experimental) | |
| 13:53 | Merge trunk changes into experimental branch. (check-in: aef6698c user: dan tags: experimental) | |
| 13:50 | Do not run some tests in notify3.test with the inmemory_journal permutation. They do not pass as the tests assume that the database schema is not loaded until the first invocation of [db eval]. This is not true with the inmemory_journal permutation. (check-in: 698fba82 user: dan tags: trunk) | |
| 12:00 | Further updates to comments in pager.c. (check-in: 5f4c17a3 user: dan tags: experimental) | |
| 09:43 | Modify test_journal.c to work with pre-allocated databases. (check-in: 4894a5d2 user: dan tags: experimental) | |
| 06:54 | Fix a bug to do with deleting the journal file when exiting exclusive-locking mode. (check-in: 6217b607 user: dan tags: experimental) | |
| 02:10 | Change two automatic array variables into static constant arrays. Update and reformat some comments for cleaner presentation. (check-in: a7a15547 user: drh tags: trunk) | |
|
2010-08-05
| ||
| 18:53 | Add comments describing UNKNOWN_LOCK to pager.c. Improve some other comments in the same file. (check-in: 54eff6de user: dan tags: experimental) | |
| 16:22 | Merge trunk changes with experimental branch. (check-in: acd26b8b user: dan tags: experimental) | |
| 16:08 | Catch an error code that was not being propagated back to the caller. (check-in: 800f4969 user: dan tags: experimental) | |
| 15:30 | Fixes for error handling with temp databases. And for errors that occur within OS locking primitives. (check-in: f99a902f user: dan tags: experimental) | |
| 11:56 | Make the size of a Bitvec object 512 bytes on all platforms, instead of having the size depend on the size of a pointer. This makes testing easier. (check-in: ca479f3d user: drh tags: trunk) | |
| 03:21 | Do not read the database file size on a SAVEPOINT rollback any more since after checkin [65b8636ac6e5] the in-header-size field is always valid. (check-in: fbe70e11 user: drh tags: trunk) | |
| 02:52 | Fix the query planner so that when it has a choice of full-scan tables to move to the outer loop, it chooses the one that is likely to give the fewest output rows. Ticket [13f033c865f878]. (check-in: 309bbedf user: drh tags: trunk) | |
|
2010-08-04
| ||
| 21:17 | If the outer loop of a join must be a full table scan, make sure that an incomplete ANALYZE does not trick the planner into use a table that might be indexable in an inner loop. Ticket [13f033c865f878] (check-in: e7a714b5 user: drh tags: trunk) | |
| 19:14 | Fix some problems with error recovery introduced while reworking pager state. (check-in: 77eaab6f user: dan tags: experimental) | |
| 12:31 | Version 3.7.0.1 (Leaf check-in: 042a1abb user: drh tags: release, branch-3.7.0) | |
| 12:19 | Update the version number to 3.7.0.1. (check-in: 5074b859 user: drh tags: branch-3.7.0) | |
| 12:13 | Backport fix [267492d3a7eff7b] for the performance regression caused by automatic indexing and reported by ticket [8011086c85c6c4040]. (check-in: 3f367fe0 user: drh tags: branch-3.7.0) | |
| 11:59 | Backport the [65b8636ac6e5] fix for ticket [51ae9cad317a1] to version 3.7.0. (check-in: dec70c63 user: drh tags: branch-3.7.0) | |
| 11:34 | When opening a write-transaction on a database file that has been appended to or truncated by a pre-3.7.0 client, update the database-size field in the database header. Fix for [51ae9cad31]. (check-in: 65b8636a user: dan tags: trunk) | |
|
2010-08-03
| ||
| 18:29 | Merge trunk changes into experimental branch. (check-in: 15368a9f user: dan tags: experimental) | |
| 18:18 | Set the Pager.eState variable to PAGER_ERROR whenever the pager enters the error state. (check-in: 4d384761 user: dan tags: experimental) | |
| 18:06 | Fix disabled implementation-mark comments in func.c. (check-in: 57c09600 user: drh tags: trunk) | |
| 15:57 | Add comments to clarify the purpose of the pager "error state". (check-in: fde4c597 user: dan tags: experimental) | |
| 13:08 | Fix the REPLACE conflict resolution so that it falls back to ABORT when a CHECK constraint fails. Ticket [c38baa3d969eab794]. (check-in: 4e157b77 user: drh tags: trunk) | |
| 12:48 | Add state diagram to comments in experimental version of pager.c. (check-in: 16dcf5a6 user: dan tags: experimental) | |
| 06:42 | Incremental checkin on pager state refactoring. (check-in: 0a636798 user: dan tags: experimental) | |
|
2010-08-02
| ||
| 14:32 | Experimental refactoring of the Pager object state. This version is surely buggy. (check-in: 03a24051 user: dan tags: experimental) | |
| 10:59 | Modify wal2.test to disable tests requiring TCL 8.5 if the test harness is compiled using TCL 8.4. (check-in: 016486c7 user: drh tags: trunk) | |
| 10:47 | In shared-cache mode, do not allow one connection to checkpoint a database while a second connection is reading or writing the same shared-cache. (check-in: e75b52d1 user: dan tags: trunk) | |
|
2010-08-01
| ||
| 22:41 | Fix a typo in an error message of the TCL interface. (check-in: 8eadd7b8 user: drh tags: trunk) | |
|
2010-07-30
| ||
| 18:40 | If a database becomes corrupted such that an index is out of sync with its table, make sure the corruption is detected and reported back. Do not assume that indices always contain rowids for valid table rows. (check-in: 83395a3d user: drh tags: trunk) | |
| 16:54 | Fix typos in comments. No code or logic changes. (check-in: 15c294ca user: drh tags: trunk) | |
| 16:44 | Remove a test from sqlite3PagerCommitPhaseOne which is now always true after the multi-file transaction fix. (check-in: 6758f6a8 user: drh tags: trunk) | |
| 15:43 | Remove variable Pager.needSync, which was almost completely unused. (check-in: 347f22a5 user: dan tags: experimental) | |
| 14:39 | Merge trunk changes into experimental again. (check-in: 87e0f4e1 user: dan tags: experimental) | |
| 11:31 | Changes to the comments describing the Pager.setMaster variable in pager.c. Add an assert() statement to verify that two master journal pointers are not written to a single journal file. (check-in: ad78ccac user: dan tags: trunk) | |
| 11:20 | Cherry-pick the multi-file transaction fix for ticket [f3e5abed55] out of the experimental branch. (check-in: 40f7f0a5 user: drh tags: trunk) | |
| 10:09 | Add the test cases for bug [f3e5abed55]. (check-in: cbbaf8e6 user: dan tags: experimental) | |
| 10:02 | Make sure a connection has an exclusive lock on all database files involved in a multi-file transaction before writing the master-journal pointer into any journal files. Fix for [f3e5abed55]. (check-in: 50c0f220 user: dan tags: experimental) | |
| 07:26 | Merge further trunk changes into experimental branch. (check-in: fb847d70 user: dan tags: experimental) | |
| 05:06 | Add tests to check that the ICU regexp() function can only be called with exactly two arguments. (check-in: 451d9657 user: dan tags: trunk) | |
| 00:31 | Updates to the README.txt file for ICU. (check-in: d37443d3 user: drh tags: trunk) | |
|
2010-07-29
| ||
| 10:13 | Unconditionally include the pTmpSpace size in the estimate of the pager memory used. (check-in: 4b97f864 user: drh tags: trunk) | |
| 10:07 | Change the profile timer units back to nanoseconds and update the sqlite3_profile() documentation. Ticket [c43940c49b74c70a69] (check-in: 7783b98a user: drh tags: trunk) | |
| 01:50 | Correct handling of compound foreign key constraints that include the integer primary key as one of the columns. Ticket [ce7c133ea6cc9ccdc1] (check-in: 53902f7d user: drh tags: trunk) | |
|
2010-07-28
| ||
| 19:17 | Get SQLITE_OMIT_VIRTUALTABLE working again after being broken by recent changes. (check-in: 33b1e862 user: drh tags: trunk) | |
| 18:51 | Fix the dbstatus.test script so that it works correctly on 64-bit machines. (check-in: a3401d9e user: drh tags: trunk) | |
| 18:35 | Merge trunk changes into experimental branch. (check-in: aa819001 user: dan tags: experimental) | |
| 17:36 | Improve the accuracy of the Pager heap usage estimate. (check-in: ae89777e user: drh tags: trunk) | |
| 17:16 | Adjust the shell test script "shell4.test" to account for changes in the ".stat on" display format from the previous checkin. (check-in: 2f2fa7dd user: drh tags: trunk) | |
| 17:01 | Record the pcache allocation size statistics even for pcache overflow allocations. Adjust the wording on one of the stat output lines in the shell. (check-in: f9adf66a user: drh tags: trunk) | |
| 16:05 | Modify CLI to optionally display "stats". (check-in: 419ce0ed user: shaneh tags: trunk) | |
| 15:52 | Lookaside memory is not used to store schemas. Change the SQLITE_DBSATUS_SCHEMA_USED documentation to reflect this fact. (check-in: 07abfd52 user: drh tags: trunk) | |
| 15:49 | Add documentation for the SQLITE_STATUS_MALLOC_COUNT parameter to sqlite3_status(). (check-in: dbfbdb60 user: drh tags: trunk) | |
| 15:10 | Fix errors in wal3.test caused by recent modifications. (check-in: 0714aecc user: dan tags: experimental) | |
| 14:26 | Support FCNTL_CHUNK_SIZE on windows too. (check-in: a038688c user: dan tags: experimental) | |
| 02:53 | Do not allow automatic indices for the RHS of IN expressions which are not correlated subqueries. Ticket [8011086c85c6c404014c9] (check-in: 267492d3 user: drh tags: trunk) | |
|
2010-07-27
| ||
| 18:36 | Merge trunk changes into experimental branch. (check-in: 62182409 user: dan tags: experimental) | |
| 18:34 | Add experimental unix-only file-control to grow and truncate the database file by a configurable chunk size. (check-in: 7cf0e851 user: dan tags: experimental) | |
| 16:42 | Update the makefiles to prefer TCL version 8.5 instead of 8.4. (check-in: 8118de2a user: drh tags: trunk) | |
|
2010-07-26
| ||
| 19:09 | Fix a bug in the SQLITE_STATUS_MALLOC_COUNT counter. Add an ALWAYS() around a condition in the SQLITE_DBSTATUS_SCHEMA_USED logic that is always true. (check-in: 6df081ad user: drh tags: trunk) | |
| 18:43 | Add the SQLITE_STATUS_MALLOC_COUNT option for sqlite3_status(). (check-in: 8f8e442b user: drh tags: trunk) | |
| 16:40 | Increase the version number to 3.7.1 due to the API enhancement of the previous check-in. (check-in: 1d7571e4 user: drh tags: trunk) | |
| 16:24 | Add support for SQLITE_DBSTATUS_SCHEMA_USED and SQLITE_DBSTATUS_STMT_USED to the trunk. (check-in: 008368b2 user: drh tags: trunk) | |
| 15:57 | When calculating schema memory, use the actual allocated size of hash elements, not sizeof(HashElem). Also fix a bug in dbstatus.test. (Closed-Leaf check-in: e327ef37 user: dan tags: experimental) | |
| 14:47 | Add virtual table test cases to dbstatus.test. (check-in: 72b84d06 user: dan tags: experimental) | |
| 14:20 | Further fixes to the P4_MEM size measurement logic. (check-in: 934cda29 user: drh tags: experimental) | |
| 13:58 | Fix an issue with P4_MEM and the schema size measurement logic. Also fix a compiler warning. (check-in: 8166f338 user: drh tags: experimental) | |
| 12:38 | Make sure sqlite3_free() is not called for P4_MPRINTF during a size measurement. (check-in: 56f11f88 user: drh tags: experimental) | |
| 12:36 | Remove an assert() that uses a variable removed earlier. (check-in: c04907e6 user: dan tags: experimental) | |
| 12:05 | Change the way SubProgram objects are deleted so that the code is the same for deletion and measurement. (check-in: 00e55102 user: dan tags: experimental) | |
| 11:59 | Update comments to better documentation the new memory measurement functions. (check-in: 620bad03 user: drh tags: experimental) | |
| 11:07 | Make sure all memory from sqlite3DbMalloc() is freed by sqlite3DbFree() and all memory from sqlite3_malloc() is freed by sqlite3_free(). (check-in: 629e38a8 user: drh tags: experimental) | |
|
2010-07-25
| ||
| 02:39 | Fixes to prior checkins so that they compile and run even if SQLITE_MEMDEBUG is not defined. (Closed-Leaf check-in: 548bf3f7 user: drh tags: malloc-enhancement) | |
| 02:12 | Further examples of using automatic deallocation to replace "delete" methods. (check-in: da2f62c5 user: drh tags: malloc-enhancement) | |
|
2010-07-24
| ||
| 19:08 | Additional malloc sanity changes. Use sqlite3MemLink() on Index.zColAff and Table.zColAff as a proof of concept. (check-in: e5ecb159 user: drh tags: malloc-enhancement) | |
| 18:25 | Add infrastructure to support a hierarchy of memory allocations with automatic deallocation of substructure. (check-in: 48ef221c user: drh tags: malloc-enhancement) | |
| 16:34 | Make sure all memory from sqlite3DbMalloc() is freed by sqlite3DbFree() and all memory from sqlite3_malloc() is freed by sqlite3_free(). (check-in: ac1f37a6 user: drh tags: malloc-enhancement) | |
| 11:28 | Experimental code to measure memory consumed by database schemas and prepared statements. (check-in: 9aa30342 user: dan tags: experimental) | |
|
2010-07-23
| ||
| 22:26 | Fix a typo in the OS/2 vfs code. (check-in: a6bb2108 user: drh tags: trunk) | |
| 17:37 | Merge two leaves. (check-in: 54e5886d user: dan tags: trunk) | |
| 17:32 | Strenghten an assert() in malloc.c that helps to ensure that allocated memory is freed by the appropriate routine. (check-in: 80db61ac user: drh tags: trunk) | |
| 17:06 | Remove additional traces (mostly in comments) of the Table.dbMem field. (check-in: 5c58f44a user: drh tags: trunk) | |
| 15:55 | Add a test case to shared.test. No changes to production code. (check-in: bfb0dd3c user: dan tags: trunk) | |
| 15:41 | Remove the Table.dbMem variable, as it is no longer being used for its original purpose. (check-in: 6eddc6e6 user: dan tags: trunk) | |
| 08:31 | Remove the unused Schema.db variable. (check-in: 430be657 user: dan tags: trunk) | |
|
2010-07-22
| ||
| 22:40 | Add evidence marks to the where.c source file. Comment only - no code changes. (check-in: f3f9e8e5 user: drh tags: trunk) | |
| 17:55 | Make the sqlite3_db_status() routine threadsafe. (check-in: 241f7bd1 user: dan tags: trunk) | |
| 17:49 | Enhance the LIKE/GLOB query optimization so that it works as long as there is an index with the appropriate collating sequence and even if the default collating sequence of the column is different. Ticket [4711020446da7d93d99]. (check-in: 9f932655 user: drh tags: trunk) | |
| 15:44 | Add test/threadtest3.c, containing multi-thread tests implemented in C. (check-in: aad88cf5 user: dan tags: trunk) | |
| 12:33 | Try to optimize LIKE and GLOB operators when RHS contains no wildcard. Ticket [e090183531fc274747] (check-in: 613a87d6 user: drh tags: trunk) | |
| 11:40 | Tweaks to the virtual table documentation contained in comments of sqlite3.h. No changes to actual code. (check-in: f5866d47 user: drh tags: trunk) | |
|
2010-07-21
| ||
| 16:16 | Version 3.7.0 (check-in: b36b105e user: drh tags: trunk, release) | |
|
2010-07-20
| ||
| 20:23 | Added fix to os_win.c for race conditions from os_unix.c; added saving of errno in two places. (check-in: 13ed106c user: shaneh tags: trunk) | |
| 18:59 | Fix a race condition in os_unix.c that may occur when one thread is opening a connection to a shared-memory block and another is either closing or locking the same shared-memory. (check-in: 3b7330c1 user: dan tags: trunk) | |
|
2010-07-19
| ||
| 15:01 | Update the CLI test scripts for version 3.7.0. (check-in: 92fe70da user: drh tags: trunk) | |
| 12:44 | Use exit(255) instead of abort() in the tcl [sqlite_abort] test command. This stops testfixture from creating dozens of core files each time tests are run. (check-in: aec9e131 user: dan tags: trunk) | |
| 12:05 | Changes to stat.test so that it works with file-format 4. (check-in: f87bb283 user: dan tags: trunk) | |
| 11:16 | Re-introduce the prefix-search optimization of [feef1b15d6], which was lost in a reorganization of FTS3 code. (check-in: d692434b user: dan tags: trunk) | |
| 05:27 | Enable previously failing tests in e_expr.test that pass following [3e5975aa3b]. (check-in: 3d59c54a user: dan tags: trunk) | |
| 02:30 | Fix a parser bug that was causing the relative precedence of LIKE and < operators to be incorrect. (check-in: 3e5975aa user: drh tags: trunk) | |
| 01:52 | Improvements to the formatting of parse.out file from Lemon. Add the -r option to Lemon to disable the state sorting, making debugging easier. (check-in: a2eaf829 user: drh tags: trunk) | |
|
2010-07-18
| ||
| 11:35 | Add the -p option to lemon to cause conflicts resolved by precedence rules to appear in the parse.out file. (check-in: fb6a59b0 user: drh tags: trunk) | |
|
2010-07-17
| ||
| 18:44 | Add new test file e_expr.test. (check-in: cbcf8abb user: dan tags: trunk) | |
| 09:27 | Do not run journal3.test with the inmemory_journal permutation. (check-in: e1d228e9 user: dan tags: trunk) | |
|
2010-07-16
| ||
| 11:10 | Fix a problem with wal4.test caused by changes in the previous checkin. (check-in: 1218d370 user: dan tags: trunk) | |
| 10:39 | Fix a test script bug uncovered by [a121cd80c5] that was causing shared_err.test to fail. (check-in: d7b63a4c user: dan tags: trunk) | |
|
2010-07-15
| ||
| 18:38 | Previous check-in [534aab837e] accidently reverted some changes from [a121cd80c5]. This check-in restores those changes. (check-in: abff795f user: drh tags: trunk) | |
| 18:32 | Optionally support shared-memory in /dev/shm or other tmpfs directory using an unsupported compile-time option. (check-in: 534aab83 user: drh tags: trunk) | |
| 18:20 | Changes to wal.c so that SQLite can read even if the WAL file is opened read-only, provided the wal-index (shm file) is opened read/write. (check-in: 932d19da user: dan tags: trunk) | |
| 17:54 | Handle the case where xShmMap returns SQLITE_BUSY. (check-in: 75f53548 user: dan tags: trunk) | |
| 14:59 | When creating a journal file on unix, attempt to create it with the same permissions as the associated database file. (check-in: a121cd80 user: dan tags: trunk) | |
| 11:14 | Change a comment inside a block of code in parse.y from C++ to C style. (check-in: dea7d33b user: dan tags: trunk) | |
|
2010-07-14
| ||
| 20:51 | Fix a typo in a comment in os_unix.c. (check-in: e1e73125 user: drh tags: trunk) | |
| 20:23 | The expression list on the RHS of an IN operator can no longer be empty because an empty expression list is now optimized out by changes in check-in [c288ac644d0bf]. Therefore add ALWAYS() macros around tests for the expression list being non-empty. (check-in: fd130ae5 user: drh tags: trunk) | |
| 19:31 | Additional test cases and evidence marks for the empty RHS bug on the IN operator - ticket [80e031a00f45dca877] (check-in: 6851c517 user: drh tags: trunk) | |
| 18:24 | Make the result of an IN or NOT IN expression with an empty set on the right-hand side always either false or true, respectively, even if the left-hand side is NULL. Ticket [80e031a00f45dc] (check-in: c288ac64 user: drh tags: trunk) | |
| 18:10 | Fix an assert() failure in wal2.test caused by messing with the contents of shared memory. (check-in: 9f452514 user: dan tags: trunk) | |
| 16:37 | Test the libraries response to read-only or unreadable database, WAL and wal-index files. If a WAL file cannot be opened in read/write mode, return SQLITE_CANTOPEN to the caller. (check-in: 45bb84c6 user: dan tags: trunk) | |
| 14:48 | On unix, try to create the *-wal and *-shm files with the same permissions as the associated database file. (check-in: e5d180ee user: dan tags: trunk) | |
| 08:20 | Add tests to pagerfault.test. (check-in: b092f2a7 user: dan tags: trunk) | |
| 07:06 | Test that a corrupted WAL hash-table does not put the library into an infinite loop. (check-in: c73886ed user: dan tags: trunk) | |
| 06:20 | Fix a typo in the IS_BIG_INT macro used by coverage test instrumentation. (check-in: 5314ca39 user: dan tags: trunk) | |
| 01:45 | Fix the unix driver to return an I/O error if unlink fails for any reason other than the file not existing in the first place. (check-in: 90d73c66 user: drh tags: trunk) | |
| 00:22 | Remove the xShmOpen method from the VFS. Shared-memory is opened automatically by a call to xShmMap. Rename the xShmClose method to xShmUnmap. (check-in: 2b68e502 user: drh tags: trunk) | |
| 00:14 | Change the name of the xShmClose VFS method to xShmUnmap, everywhere. (Closed-Leaf check-in: c2d27cf5 user: drh tags: experimental) | |
|
2010-07-13
| ||
| 23:41 | Tweaks to the new shared-memory interface design - mostly comment changes. (check-in: 6336de7a user: drh tags: experimental) | |
| 18:45 | Fix a typo in a comment in sqlite.h.in. (check-in: 4a6c4b66 user: dan tags: experimental) | |
| 18:44 | Changes so that the xShmOpen VFS method is no longer required. Its job can be done by the first call to xShmMap. Rename xShmClose to xShmUnmap. (check-in: f4780bde user: dan tags: experimental) | |
| 14:48 | Improved documentation for the SQLITE_ACCESS_* constants that are used with the xAccess() method of the VFS. (check-in: 3d4bb65f user: drh tags: experimental) | |
| 14:33 | Add proposed interface change to sqlite.h.in. This commit breaks the build. (check-in: 52577bb5 user: dan tags: experimental) | |
| 14:22 | Fixes to the pcache10 and pcache90 permutations. (check-in: 597d40fa user: dan tags: trunk) | |
| 07:38 | Fix problems with running the async.test script. (check-in: 05ac2548 user: dan tags: trunk) | |
|
2010-07-12
| ||
| 20:46 | Updates to comments and code organization to reflect changes in os_unix.c; Updated winShmLock() with logic changes from unixShmLock(); Modified IO error returns in winShmMap() to match those in unixShmMap(); (check-in: b73fe275 user: shaneh tags: trunk) | |
| 18:12 | Fix test_stat.c so that it does not cause compilation errors if SQLITE_OMIT_VIRTUALTABLE is defined. (check-in: bf4fc088 user: dan tags: trunk) | |
| 16:47 | Fix makefiles so that they build sqlite3_analyzer again. Tweaks to comments in test_stat.c. Fix tclsqlite.c to build the sqlite3_analyzer again. (check-in: e6cd1545 user: drh tags: trunk) | |
| 12:22 | In the async-IO module, do not increment the open file-counter until after an "open file" event has been added to the event queue. Otherwise, an OOM may cause the system to increment the counter even though no file was successfully opened. (check-in: 15a190dc user: dan tags: trunk) | |
| 08:39 | Changes so that the space-analyzer script works with 3.7.0. (check-in: 86159cb3 user: dan tags: trunk) | |
|
2010-07-09
| ||
| 19:32 | Exclude a few more FTS modules from the "in memory" permutation test suite. (check-in: 4e9d69cd user: shaneh tags: trunk) | |
| 18:43 | Exclude fts3cov.test from the "in memory" permutation test suite to avoid a false positive. (check-in: 6af6794c user: shaneh tags: trunk) | |
| 12:57 | Fix warning under MSVC. (check-in: 0c32c4bb user: shaneh tags: trunk) | |
| 03:19 | Reformat WAL code for clearer presentation. Update comments for correctness. Add checks to ensure that corruption in shared-memory does not result in an infinite loop. (check-in: 40eaada7 user: drh tags: trunk) | |
|
2010-07-08
| ||
| 19:19 | Replace code that became unreachable due to the journal_mode simplification with an assert(). (check-in: bcdddba4 user: drh tags: trunk) | |
| 18:32 | Fix test case numbering in backup_malloc.test and issue when running under Windows. (check-in: aef26438 user: shaneh tags: trunk) | |
| 17:40 | Change the journal_mode pragma to remove the "default journal mode" concept. The journal_mode pragma only effects currently attached databases and does not change the behavior of future attachments. (check-in: e396184c user: drh tags: trunk) | |
| 16:50 | Merged experimental crashsql() into trunk. (check-in: 01b575ff user: shaneh tags: trunk) | |
| 16:30 | Changes to get crashsql() working on Windows. (Closed-Leaf check-in: 8a5811ea user: shaneh tags: experimental) | |
| 16:22 | Fix warning in test fixture code. (check-in: 0bfcf3bc user: shaneh tags: trunk) | |
| 16:22 | Fix test case number issue in walcrash.test. (check-in: 6a46e641 user: shaneh tags: trunk) | |
| 14:59 | Fix to lock5.test so that it runs with the inmemory_journal permutation on osx. (check-in: 948bb545 user: dan tags: trunk) | |
| 13:33 | Fixed a few tests in pagerfault.test so they work correctly on Windows. (check-in: ffbdd954 user: shaneh tags: trunk) | |
| 09:44 | Changes to test scripts so that the "inmemory_journal" permutation works with [ef126e775a]. (check-in: f553c8ed user: dan tags: trunk) | |
| 06:22 | Add tests to walmode.test. (check-in: 5aa2bdb5 user: dan tags: trunk) | |
| 03:13 | Changes to os_win.c to have it simulate IO errors like os_unix.c. (check-in: 0d53da94 user: shaneh tags: trunk) | |
|
2010-07-07
| ||
| 21:06 | Make the initial salt values in the WAL header random values, not zero. (check-in: baa5eddd user: drh tags: trunk) | |
| 20:38 | Add the write-ahead log viewer/debugger tool to the tools/ folder. (check-in: 0e4bd446 user: drh tags: trunk) | |
| 20:00 | Fix issue in mallocI test script where db handle not released. (check-in: dd59cea6 user: shaneh tags: trunk) | |
| 18:38 | Add further test cases to savepoint.test. (check-in: f825205d user: dan tags: trunk) | |
| 17:53 | When rolling back a savepoint, reset the changeCountDone flag. (check-in: fb62f4e3 user: dan tags: trunk) | |
| 16:51 | When using MSVC to build test code, suppress the popup dialog when abort is called from the sqlite_abort() test function. (check-in: 55d3d39f user: shaneh tags: trunk) | |
| 16:49 | Fix some MSVC compiler warnings in the ASYNC extension. (check-in: b951c867 user: shaneh tags: trunk) | |
| 16:23 | Merge together another accidental fork. (check-in: c41f04ed user: dan tags: trunk) | |
| 16:20 | Fix test numbering issue in nan.test. (check-in: 5bb1330f user: shaneh tags: trunk) | |
| 16:18 | Do not make the SQLITE_FCNTL_SIZE_HINT call if an error has already occurred during transaction commit. (check-in: e92de834 user: dan tags: trunk) | |
| 15:41 | Close the file handle before returning. TCL test script issue only. (check-in: f4076d85 user: shaneh tags: trunk) | |
| 14:45 | Fixed a new error introduced by last check-in of os_win.c. Updated xAccess() to support SimulateIOError(). (check-in: 8eefc287 user: shaneh tags: trunk) | |
| 14:40 | Remove two more testcase() macros that require 4GiB WAL files to hit. (check-in: 16e18f27 user: drh tags: trunk) | |
| 14:35 | Remove a testcase() macro that would require a 4GiB WAL to reach. (check-in: 15f9c271 user: drh tags: trunk) | |
| 14:33 | Fix a compiler warning in PRAGMA journal_mode. (check-in: d94269e6 user: drh tags: trunk) | |
| 14:19 | Avoid the need for a NEVER() from pager_write_pagelist() by passing in pPager as an extra parameter. (check-in: b3179379 user: drh tags: trunk) | |
| 14:00 | Merge together the accident fork. (check-in: cdcf08cb user: drh tags: trunk) | |
| 13:58 | Fix minor issue in xAccess() method for Windows. (check-in: 4bfd46f1 user: shaneh tags: trunk) | |
| 13:54 | Make sure the schema is loaded before preparing a "PRAGMA journal_mode" command. This helps it return meaningful results when it is the first command executed by a new database connection. (check-in: ef126e77 user: dan tags: trunk) | |
| 13:43 | Add testcase macros to ensure that large-file cases are tested in WAL. (check-in: 8156b57a user: drh tags: trunk) | |
| 11:43 | Run some fts3 tests as part of the "wal" permutation. (check-in: 8657455a user: dan tags: trunk) | |
| 11:05 | Change the async-IO extension to return SQLITE_IOERR_SHORT_READ when appropriate. This prevents a valgrind warning in the test suite. (check-in: d9e32879 user: dan tags: trunk) | |
| 09:48 | Fix a problem with writing to databases larger than 2^32 bytes with WAL mode. (check-in: b956ddca user: dan tags: trunk) | |
| 01:52 | Remote the SQLITE_OMIT_GLOBALRECOVER macro - it is subsumed by SQLITE_OMIT_DEPRECATED. Add support to sqlite3_compileoption_used() for SQLITE_OMIT_WAL. (check-in: 21a2db90 user: drh tags: trunk) | |
|
2010-07-06
| ||
| 20:37 | Minor changes to Makefile.in to bring it more inline with main.mk. (check-in: 5621862b user: shaneh tags: trunk) | |
| 20:34 | Changes to pager1.test to support Windows. (check-in: fce689eb user: shaneh tags: trunk) | |
| 20:33 | Modified the xWrite() method on Windows to differentiate between IO and disk full error returns. (check-in: ca4b7ffb user: shaneh tags: trunk) | |
| 11:26 | Do not do the *-closeallfiles test for notify2.test. It uses multiple threads. (check-in: fb09152d user: dan tags: trunk) | |
| 10:55 | Before calling Tcl_ExitThread() in a multi-threaded test, call Tcl_DoOneEvent() as many times as necessary to handle any queued events. (check-in: b3399b40 user: dan tags: trunk) | |
| 09:29 | Reorder variable declarations in the previous check-in to avoid putting code before declarations when not testing. (check-in: d1fe8ab4 user: drh tags: trunk) | |
| 07:36 | Ensure the correct error code is returned if an attempt to parse a database schema made by an ATTACH statement fails. (check-in: c2721961 user: dan tags: trunk) | |
|
2010-07-05
| ||
| 21:00 | Modify the VFS xAccess() method on winNT so that it returns false for an exists test of a zero-length file. This makes the windows VFS work the same as the unix VFS. (check-in: ec35f254 user: drh tags: trunk) | |
| 19:13 | Simplify the previous commit by removing the pagerCheckForOrDeleteWAL() wrapper. (check-in: a1324d12 user: dan tags: trunk) | |
| 19:03 | Allocate a buffer containing the full path-name to the associated WAL file when a pager is created. This saves having to construct a new buffer each time a new read-transaction is opened and SQLite checks for the existance of a WAL file. (check-in: 3053a4ad user: dan tags: trunk) | |
| 17:43 | When rolling back page 1 from a journal, restore the "nReserve" setting in case it has been corrupted by a prior crash. (check-in: c0d124da user: drh tags: trunk) | |
| 14:54 | Do not report an error if the open-file-count is not as it should be after running a multi-threaded test. The counter instrumentation is not thread-safe. (check-in: ea80b21c user: dan tags: trunk) | |
| 12:54 | Call Tcl_ExitThread() from within threads created using Tcl_CreateThread(). Not doing so causes notifier related errors on OSX. (check-in: 684eae66 user: dan tags: trunk) | |
| 05:54 | Add any files specified as part of the QUICKTEST_INCLUDE environment variable to the set of test files run as part of "make test". Release testing uses this trick. (check-in: a40a6e7d user: dan tags: trunk) | |
| 05:31 | Fix typos in permutations.test. (check-in: b6600ecb user: dan tags: trunk) | |
|
2010-07-03
| ||
| 19:08 | Do not run the memsubsys1.test script under the memsubsys1 permutation. (check-in: 3a1a8c77 user: dan tags: trunk) | |
| 17:13 | Remove the unused xRename() method from the sqlite3_vfs object. Add better documentation on the xCurrentTimeInt64() method. (check-in: 51ec0e54 user: drh tags: trunk) | |
| 16:37 | Further changes to test scripts so that the "inmemory_journal" permutation works. (check-in: 50f2f7df user: dan tags: trunk) | |
| 13:59 | Fix a bug in the permutations.test script. (check-in: 3b20ad03 user: dan tags: trunk) | |
| 13:50 | Fix an assert in pager.c. And various test cases that fail with the in-memory journal permutation. (check-in: 622378db user: dan tags: trunk) | |
| 13:45 | Fix an assert in pager.c. And various test cases that fail with the in-memory journal permutation. (Closed-Leaf check-in: 78fc35ff user: dan tags: mistake) | |
| 12:31 | Cherry-pick the correct changes out of the recent "mistake" branch while omitting the bugs. (check-in: 48bf3093 user: drh tags: trunk) | |
| 12:26 | Remove dead code from the pager. (check-in: 7cbe175a user: drh tags: mistake) | |
| 12:00 | Print the SQLite source_id() string when running speed tests. (check-in: 6d7640ed user: drh tags: mistake) | |
| 10:00 | Fix an assert() in pager.c added by the previous commit. And various problems with test scripts in autovacuum and in-memory journal mode. (check-in: 62a10101 user: dan tags: mistake) | |
| 08:01 | Do not attempt to open a WAL file for an in-memory or temporary database. Even if the database header suggests that it is a WAL database. (check-in: 0fd80924 user: dan tags: mistake) | |
| 05:56 | Change code in OP_Rewind to avoid a valgrind warning following an error in the btree layer. This change does not fix any bug, just a warning. (check-in: 4f62dbcf user: dan tags: mistake) | |
| 01:44 | Fix a buffer overrun in the where.c. Problem detected by valgrind. (check-in: 15bb6233 user: drh tags: mistake) | |
|
2010-07-02
| ||
| 19:49 | Changes to os_win.c to have it return same error code as os_unix.c. (check-in: 33b6f069 user: shaneh tags: mistake) | |
| 19:36 | Omit the OP_JournalMode opcode from the VDBE when SQLITE_OMIT_PRAGMA is defined. (check-in: 565ff65c user: drh tags: mistake) | |
| 19:04 | Fix a bug in test_vfs.c causing an assert to fail. Changes to test code only. (check-in: 336ce7d2 user: dan tags: mistake) | |
| 18:58 | Do not run the tests in notify3.test unless the unlock-notify API is available. (check-in: 0d7fd6fe user: dan tags: mistake) | |
| 18:44 | Take out the incomplete initializer on the constant "dummy" in sqlite3VdbeGetOp(). Add a comment that the MSVC warning there should be ignored. (check-in: 452ccaa9 user: drh tags: mistake) | |
| 18:15 | Fix a couple more compiler warnings under MSVC. (check-in: 26bc27e3 user: shaneh tags: mistake) | |
| 17:10 | Fix compiler warnings in the proxy locking code. (check-in: 26c7689c user: drh tags: mistake) | |
| 17:07 | Remove a couple of C++ style comments from pager.c. (check-in: 4f12e8eb user: drh tags: mistake) | |
| 17:05 | Fix some warnings when compiling under MSVC. (check-in: 70833877 user: shaneh tags: mistake) | |
| 16:36 | Add initializers for the xShmXXX() members to an sqlite3_io_methods structure in journal.c. This doesn't fix any real problem, just prevents a compiler warning. (check-in: dafb3577 user: dan tags: trunk) | |
| 15:35 | Remove an unused call to sqlite3PageBegin() from pager_write(). Replace it with an assert(). (check-in: 01c12782 user: drh tags: trunk) | |
| 13:49 | Run tkt-9d68c883.test along with the other pager.c coverage tests. Add a test case to pager1.test. (check-in: c6714b0d user: dan tags: trunk) | |
| 11:27 | Additional test cases to cover branches in pager.c. (check-in: eddfb2b4 user: dan tags: trunk) | |
| 01:18 | Add a NEVER to sqlite3PagerCommitPhaseTwo() because it is now no longer possible to invoke that function without holding a RESERVED lock. (check-in: 6ae76172 user: drh tags: trunk) | |
|
2010-07-01
| ||
| 19:45 | If you delete a database file but not its *-wal file, then open the database (thus creating a new empty database file) the *-wal file is automatically deleted. (check-in: 95c69dfb user: drh tags: trunk) | |
| 19:01 | Add tests to pager1.test and pagerfault.test. (check-in: c6e75950 user: dan tags: trunk) | |
| 15:09 | Add pager test cases. Change a condition in pager.c to NEVER(). (check-in: a8f6341d user: dan tags: trunk) | |
|
2010-06-30
| ||
| 10:36 | Add further test cases. Fix an assert() in pager.c. (check-in: 8e65c0e3 user: dan tags: trunk) | |
| 04:36 | Do not call pager_open_journal() from within PagerBegin() if the connection is in exclusive-access mode. It will be called from within PagerWrite() just as it is for non-exclusive mode anyway. (check-in: cdf2c5c2 user: dan tags: trunk) | |
| 04:29 | Add coverage test cases. Have sqlite3_backup_step() transform SQLITE_IOERR_NOMEM to SQLITE_NOMEM before returning. (check-in: 5e19bc36 user: dan tags: trunk) | |
|
2010-06-29
| ||
| 10:30 | Add tests to pager1.test and pagerfault.test. (check-in: 008513ee user: dan tags: trunk) | |
|
2010-06-28
| ||
| 19:04 | Add extra pager tests. (check-in: 6b7e419d user: dan tags: trunk) | |
| 11:23 | Fix some errors when compiling with SQLITE_OMIT_WAL. (check-in: 3b68cb9c user: dan tags: trunk) | |
| 11:06 | Remove debugging code from test script. (check-in: a85ae332 user: dan tags: trunk) | |
| 10:15 | Currently, if SQLite cannot find a table or index referred to by a query, it reloads the database schema from disk to see if the table or index has been added since the schema was cached in memory. Extend this behaviour to columns (which may have been added using ALTER TABLE) and fix some obscure cases related to tables and indexes (INDEXED BY, DROP TABLE etc.). (check-in: 4932f228 user: dan tags: trunk) | |
|
2010-06-26
| ||
| 22:16 | Make walIndexTryHdr() a private function. Fix an issue with SQLITE_MUTEX_NOOP. (check-in: ec65bbd0 user: drh tags: trunk) | |
| 21:34 | Suppress various compiler warnings. (check-in: e82d008e user: drh tags: trunk) | |
| 20:25 | Fix two asserts on the scratch allocator to allow for up to two outstanding scratch allocations per thread. (check-in: f149b498 user: drh tags: trunk) | |
| 20:00 | Suppress a couple uninitialized variable warnings. (check-in: 29571e22 user: drh tags: trunk) | |
| 19:03 | Add test file tkt-d11f09d36e.test. (check-in: 6e469b63 user: dan tags: trunk) | |
| 19:02 | Remove a NEVER() in pager that can in fact be reached in obscure failure cases. (check-in: 42b8bd1c user: drh tags: trunk) | |
| 17:15 | Fix a case where the doNotSyncSpill flag may remain permanently set following an IO error. (check-in: 56c7d111 user: dan tags: trunk) | |
| 15:42 | When synchronous=NORMAL, use the same journal file format as with synchronous=FULL (i.e. multiple journal headers within the one journal). Fix for [d11f09d36e]. (check-in: 2eaf5ee0 user: dan tags: trunk) | |
|
2010-06-25
| ||
| 19:09 | Further test cases for pager1.test and pagerfault.test. (check-in: bfd563c4 user: dan tags: trunk) | |
| 16:34 | Reduce the average (but not maximum) size of the allocations made as part of a checkpoint. (check-in: 4a7fd91b user: dan tags: trunk) | |
| 15:16 | Reduce the size of the large allocation (approx 8KB for every 4000 frames in the log) that occurs during checkpoint. Use the 'scratch' memory for this allocation instead of the general purpose allocation. (check-in: 29887487 user: dan tags: trunk) | |
| 14:17 | Fix up a branch in sqlite3ValueFromExpr() so that we can achieve full branch test coverage regardless of whether or not SQLITE_ENABLE_STAT2 is used. (check-in: af471ed7 user: drh tags: trunk) | |
| 12:52 | Change the name of the shared-memory file on windows from *-wal-index to *-shm, for consistency with unix. (check-in: 5995cb15 user: drh tags: trunk) | |
| 11:35 | Modify the merge-sort in wal.c so that it does not use recursion. (check-in: daea6c05 user: dan tags: trunk) | |
|
2010-06-24
| ||
| 19:16 | Add test cases to pager1.test and pagerfault.test. (check-in: 4941e437 user: dan tags: trunk) | |
| 18:36 | Revert to allowing a cache spill during writes of multiple pages within a single sector as long as the spill does not require a journal sync and a new journal header. (check-in: 7d83fbae user: drh tags: trunk) | |
| 17:37 | Modify ctime.test to work with SQLITE_THREADSAFE=2. (check-in: c6db3b30 user: dan tags: trunk) | |
| 14:52 | Disable memory-pressure induced cache spill during savepoint rollback. (check-in: a55eb4c3 user: drh tags: trunk) | |
| 13:24 | Add a coverage test to pagerfault.test. (check-in: b58db67e user: dan tags: trunk) | |
| 10:50 | Add coverage tests. Remove a NEVER macro from pager.c, as the condition can now be true in wal mode. (check-in: 7aac9ad6 user: dan tags: trunk) | |
| 02:46 | Make sure the wal-index reader detects an incorrect version number even if it had to hold a lock in order to read the wal-index. Also, expand and enhance various comments in wal.c. (check-in: 2e6a462c user: drh tags: trunk) | |
|
2010-06-23
| ||
| 22:00 | Fix and/or improve comments in wal.c. No code changes. (check-in: ee9991be user: drh tags: trunk) | |
| 19:27 | Add test case for SQLITE_FULL errors to pagerfault.test. Remove a NEVER macro in pager.c that this hits. (check-in: 3e9680c4 user: dan tags: trunk) | |
| 17:59 | Include the SOURCE_ID value in the log messages output for corruption, misuse, and CANTOPEN errors. (check-in: 1727a81f user: drh tags: trunk) | |
| 17:58 | Adjust the shared-memory locking range to account for the new version number values in the wal-index header. (check-in: a6dc0df3 user: drh tags: trunk) | |
| 15:55 | Add a version number to the wal-index header. If SQLite encounters a version number in either the wal or wal-index files that it does not understand, the operation is abandoned and SQLITE_CANTOPEN returned. (check-in: 8d0f8a7f user: dan tags: trunk) | |
| 15:18 | Fix the xCurrentTimeInt64 interface on windows. It was off by a factor of 10. (check-in: 51ef43b9 user: drh tags: trunk) | |
| 15:04 | Simplifications to the pager_delmaster() implementation. (check-in: 8bfbdec6 user: drh tags: trunk) | |
|
2010-06-22
| ||
| 21:15 | Disable code used only by the codec when the codec is not deployed. (check-in: 2c90276e user: drh tags: trunk) | |
| 15:18 | Add codec support to wal mode. (check-in: 393741eb user: dan tags: trunk) | |
| 14:49 | When trying to transition from journal_mode MEMORY to WAL, use OFF as an intermediate journal mode. (check-in: 4775b8f9 user: drh tags: trunk) | |
| 13:46 | Some changes to test scripts related to codec enabled versions of sqlite. (check-in: 85dd51a7 user: dan tags: trunk) | |
| 11:10 | Fix problem with handling of -vfs option in tcl interface. (check-in: 8f98e8b5 user: dan tags: trunk) | |
|
2010-06-21
| ||
| 21:45 | Minor tweaks to get the pager working for corner cases when the SQLITE_IOCAP_UNDELETABLE_WHEN_OPEN flag is set. (check-in: 82b38fca user: drh tags: trunk) | |
| 20:19 | Fix comment inside the pager_unlock() routine. Always close the master journal file before trying to delete it. (check-in: f820b815 user: drh tags: trunk) | |
| 18:29 | Add test cases to pager1.test and pager2.test. (check-in: cc9ddae6 user: dan tags: trunk) | |
| 12:47 | Merge the experimental UNDELETABLE_WHEN_OPEN optimization into the trunk. (check-in: ee0acef1 user: drh tags: trunk) | |
| 12:34 | Change things so that journal2.test works with ENABLE_ATOMIC_WRITE. (Closed-Leaf check-in: a64d96db user: dan tags: experimental) | |
| 07:45 | Add further pager tests. (check-in: 4104b175 user: dan tags: experimental) | |
| 06:00 | Merge latest trunk change. (check-in: f6d26e07 user: dan tags: experimental) | |
| 05:40 | Fix jrnlmode2.test so that it works on systems where UNDELETABLE_WHEN_OPEN is defined. (check-in: 59be370e user: dan tags: experimental) | |
|
2010-06-19
| ||
| 23:53 | Fix an uninitialized variable in os_unix.c. (check-in: 822a0283 user: drh tags: trunk) | |
| 19:06 | Fix an assert() failure that could occur if compiling with OMIT_SHARED_CACHE. (check-in: 3e76a9f2 user: dan tags: experimental) | |
| 18:12 | Change the name of IOCAP_SAFE_DELETE to IOCAP_UNDELETABLE_WHEN_OPEN. Have the xDeviceCharacteristics() method of the win32 VFS return this flag. (check-in: 5a5ff4e3 user: dan tags: experimental) | |
| 17:26 | Add tests to pager1.test and pagerfault.test. (check-in: f5df83fd user: dan tags: experimental) | |
| 15:10 | Change the unix VFS to always allocate shared-memory using a file in the same directory as the database. Otherwise, a chroot might cause different processes to use different shared memory files resulting in database corruption. (check-in: 2241788b user: drh tags: trunk) | |
| 11:30 | Add tests to pager1.test and pagerfault.test. (check-in: 58c0b5bf user: dan tags: experimental) | |
|
2010-06-18
| ||
| 18:59 | Add tests to pager1.test. (check-in: 582fca89 user: dan tags: experimental) | |
| 16:13 | Rearrange some code in OP_JournalMode to avoid incorrect returns from subsequent invocations of "PRAGMA journal_mode" following an IO error. (check-in: ce0a4a9b user: dan tags: experimental) | |
| 11:10 | Change the implementation of the unix implementation of xAccess() so that it returns 0 (does not exist) to an SQLITE_ACCESS_EXISTS query on a file that exists but is zero bytes in size. (check-in: 077b0e5b user: dan tags: experimental) | |
|
2010-06-17
| ||
| 17:05 | Apply [b9b11855e8] (the alternate fix to [fc62af4523]) to the trunk. (check-in: 9a949a3a user: dan tags: trunk) | |
| 16:44 | Merge trunk change [7c3a86b9c7]. (check-in: bd7bc4e0 user: dan tags: experimental) | |
| 16:44 | A different fix to [fc62af4523]. When changing from journal_mode=PERSIST or TRINCATE to some other rollback mode, delete the journal file only if a RESERVED lock can be obtained on the database file first. (check-in: b9b11855 user: dan tags: experimental) | |
| 16:08 | Fix the tkt-fc62af4523.test to work around non-randomness of the randomblob() function when in testing mode. (check-in: 7c3a86b9 user: drh tags: trunk) | |
| 11:36 | Fix bug in journal2.test. (check-in: c1e04f1d user: dan tags: experimental) | |
| 10:52 | Merge trunk updates with experimental branch. Also add tests to journal2.test. (check-in: 9f6ea1de user: dan tags: experimental) | |
| 10:42 | Do not delete the journal file in "PRAGMA journal_mode" commands. This fixes [fc62af4523]. (check-in: 1ec74591 user: dan tags: trunk) | |
| 10:24 | Add test case for [fc62af4523]. (check-in: cccd32c6 user: dan tags: trunk) | |
| 06:19 | Merge fix [f80c3f922a] with experimental changes. (check-in: 20133e9c user: dan tags: experimental) | |
| 02:13 | Bug fix: Only trust the database size number at offset 28 if the change counter at offset 24 matches the version number counter at offset 92. This prevents corruption in the case of two applications writing to the database where one is an older version of SQLite and the other is a newer version. (check-in: f80c3f92 user: drh tags: trunk) | |
|
2010-06-16
| ||
| 19:04 | Experimental change: On systems where it is not possible to unlink a file while one or more processes has it open (i.e. not unix), avoid closing the journal file each time the database is unlocked and reopening it at the start of each transaction. (check-in: bede8c8a user: dan tags: experimental) | |
| 12:30 | Add extra test cases to pager1.test. (check-in: ad320957 user: dan tags: trunk) | |
| 10:55 | Fix a memory leak that can occur in os_unix.c if an IO error occurs within the xUnlock method. (check-in: 6c5c04ee user: dan tags: trunk) | |
|
2010-06-15
| ||
| 19:07 | Rationalize a common pattern in tcl test cases into proc do_multiclient_test. (check-in: efe44564 user: dan tags: trunk) | |
| 18:00 | Fix a problem introduced into lock2.test by the previous commit. (check-in: c1c9f6fa user: dan tags: trunk) | |
| 17:44 | Add test file pager1.test, containing tests of inter-process locking in non-wal mode. (check-in: 6e43eed9 user: dan tags: trunk) | |
| 14:21 | Run extra iterations in wal3.test to ensure test coverage. (check-in: ea80cbe5 user: dan tags: trunk) | |
| 14:06 | Merge in [2c5e48a485]. Merge in [2c5e48a485]. Merge in [2c5e48a485]. (check-in: 03c0f4fd user: dan tags: trunk) | |
| 13:56 | Changes to the way tcl test scripts work. No changes to production code. (Closed-Leaf check-in: 2c5e48a4 user: dan tags: experimental) | |
| 12:09 | Minor tweaks to the interface documentation - adding hyperlinks. (check-in: 07b2fdd1 user: drh tags: trunk) | |
| 11:21 | Updates to comments and testcase() macros in wal.c. (check-in: 4d90cc0b user: drh tags: trunk) | |
|
2010-06-14
| ||
| 18:06 | Fix an error in the walfault.test script introduced by the previous check-in. (check-in: a2b9374f user: drh tags: trunk) | |
| 18:01 | Move the xShmMap method to in between xShmLock and xShmBarrier, since it seems to fit in there logically. (check-in: 58dfd83d user: drh tags: trunk) | |
| 17:09 | Merge the experimental shared-memory mmap-by-chunk changes into the trunk. (check-in: f295e7ed user: drh tags: trunk) | |
| 16:16 | Add the new xShmMap (formerly xShmPage) to os_win.c. (check-in: 13e7a824 user: dan tags: experimental) | |
| 14:07 | Remove xShmGet/Size/Release from the sqlite3_vfs structure. Change the name of xShmPage to xShmMap. Remove some code that is now unused from os_unix.c and some of the test VFS implementations. (check-in: fc0cabc1 user: dan tags: experimental) | |
| 11:49 | Update some comments in wal.c. No code changes. (check-in: 1ce9c92b user: dan tags: experimental) | |
| 11:18 | Change the interface to internal function walGetHash() to make it easier to follow. (check-in: 5e8e2e97 user: dan tags: experimental) | |
| 10:30 | Add the xShmPage method to the "crash" vfs in test6.c. (check-in: 1008f536 user: dan tags: experimental) | |
| 07:53 | Add some fault-injection tests to improve coverage. (check-in: 37b26d12 user: dan tags: experimental) | |
|
2010-06-12
| ||
| 12:02 | Fix some problems with handling IO errors on the experimental branch. (check-in: eade8bc2 user: dan tags: experimental) | |
|
2010-06-11
| ||
| 19:04 | Experimental change to the xShmXXX parts of the VFS interface. (check-in: ca68472d user: dan tags: experimental) | |
| 17:01 | Refactor and simplify the logic used to change journalmode. (check-in: 95cc3f6f user: drh tags: trunk) | |
|
2010-06-10
| ||
| 16:25 | Adding original art for the new SQLite logo. (check-in: af353bd8 user: drh tags: trunk) | |
| 14:07 | Add the SQLITE_TESTCTRL_PGHDRSZ verb for sqlite3_test_control() used to get the size of pcache headers for testing purposes. (check-in: 5d694f04 user: drh tags: trunk) | |
| 10:51 | Update the test VFS in test_journal.c so that it implements the xCurrentTimeInt64 method. (check-in: ec3b4a7e user: drh tags: trunk) | |
| 06:53 | Store the MemPage structure in memory following, instead of preceding, the page data for cached pages. This reduces the likelihood of a corrupt database page image causing SQLite to read past the end of a buffer. (check-in: 0ce42e76 user: dan tags: trunk) | |
| 01:07 | Remove a condition that must always be true. Replace it with an assert(). (check-in: 7abcd54e user: drh tags: trunk) | |
|
2010-06-09
| ||
| 19:01 | Fix test script problems causing errors in the "inmemory_journal" permutations. (check-in: ea05b7f9 user: dan tags: trunk) | |
| 16:58 | When restarting (wrapping) a log file, set all unused aReadMark[] slots to READMARK_NOT_USED instead of 0. Setting them to 0 does not cause a problem, but may cause SQLite to obtain and release a few more file locks than would otherwise be necessary. (check-in: 0797b10c user: dan tags: trunk) | |
| 15:47 | Fix for ticket [f973c7ac31]. (check-in: 6eb058dd user: dan tags: trunk) | |
| 14:45 | Shift the meaning of aReadMark[] back so that +1 offset from mxFrame is removed. Add the new READMARK_NOT_USED value (0xffffffff) instead of zero to signal an aReadMark[] that is not in use. (check-in: c576827d user: drh tags: trunk) | |
| 11:28 | Simpler fix for the race condition also fixed by [7c102c7b5f] (check-in: 3c2de820 user: dan tags: trunk) | |
| 11:02 | Fix for race condition in WAL locking code. (Closed-Leaf check-in: 7c102c7b user: dan tags: mistake) | |
|
2010-06-08
| ||
| 15:50 | Close database opened by tester.tcl when it is sourced in all.test. Because test scripts are now run in slave interpreters, this connection was not being closed by the first script run as it was previously. (check-in: b072e9f6 user: dan tags: trunk) | |
| 15:16 | Changes to wal3.test to support small default cache size settings. And builds that create autovacuum databases by default. (check-in: ac4cc257 user: dan tags: trunk) | |
|
2010-06-07
| ||
| 19:26 | In os_unix.c, call munmap() to unmap a shared-memory region prior to closing the associated file descriptor. (check-in: 95cc976f user: dan tags: trunk) | |
| 17:47 | Change all.test, quick.test and permutations.test so that they use a separate interpreter for each test file. (check-in: 7c33eb5a user: dan tags: trunk) | |
| 14:28 | Refactor some of the global variables and commands used by tester.tcl. (check-in: c2edf8e1 user: dan tags: trunk) | |
| 06:11 | Add a couple of extra coverage tests for wal.c. (check-in: cfe60254 user: dan tags: trunk) | |
|
2010-06-05
| ||
| 19:18 | Add further test cases for the logic in sqlite3WalBeginReadTransaction(). (check-in: a49713db user: dan tags: trunk) | |
| 18:34 | Clarify the purpose of a test for a race-condition in sqlite3WalBeginReadTransaction(). (check-in: c041c6a9 user: dan tags: trunk) | |
| 18:12 | Remove a condition from sqlite3WalRead() that is unreachable as of the changes to clear entries out of the wal-index hash tables on transaction or savepoint rollback. (check-in: 39420473 user: dan tags: trunk) | |
| 14:42 | Mark a condition in wal.c as ALWAYS(). (check-in: 3fe0cc78 user: dan tags: trunk) | |
| 11:53 | Add extra coverage test cases for wal.c. No changes to production code. (check-in: f9d4ae0e user: dan tags: trunk) | |
|
2010-06-04
| ||
| 18:38 | Clarify an assert in sqlite3WalExclusiveMode(). (check-in: 25585069 user: dan tags: trunk) | |
| 17:16 | Remove an unnecessary branch from wal.c. (check-in: 8e54786c user: dan tags: trunk) | |
| 15:59 | Add an English language error message to corresponding to SQLITE_PROTOCOL. "locking protocol". (check-in: ca327e32 user: dan tags: trunk) | |
| 12:22 | Add test for the code that detects an inconsistent pair of wal-index headers to wal2.test. (check-in: 157feba1 user: dan tags: trunk) | |
| 11:56 | If an attempt to sync the database file as part of a checkpoint fails, do not update the shared "nBackfill" variable. Otherwise, another process could wrap the log and overwrite content before it is synced into the database. (check-in: b813233d user: dan tags: trunk) | |
| 10:37 | Fix a problem where an SQLITE_BUSY in the checkpoint code was being treated as an IO error (abandoning, instead of just limiting, the checkpoint). (check-in: 02c4040c user: dan tags: trunk) | |
|
2010-06-03
| ||
| 19:10 | Fix another problem in test_vfs.c. (check-in: df7d5989 user: dan tags: trunk) | |
| 18:20 | Have test_vfs.c simulate IO errors in xShmLock. (check-in: fcbf7cf1 user: dan tags: trunk) | |
| 18:02 | Performance fix for winShmClose(). (check-in: ed7774de user: drh tags: trunk) | |
| 16:58 | Add extra tests for removing elements from wal-index hash tables as part of a rollback. (check-in: af3e598a user: dan tags: trunk) | |
| 12:35 | Delay opening the sub-journal until SQLite actually needs to write data to it. (check-in: c43deb33 user: dan tags: trunk) | |
| 12:09 | Remove global variables when compiled with SQLITE_OMIT_WSD (check-in: dd10a547 user: drh tags: trunk) | |
| 09:25 | Enhancements to test_vfs.c and walfault.test. (check-in: ac0de2f3 user: dan tags: trunk) | |
| 09:17 | If an error (OOM or SQLITE_FULL error) occurs while executing an SQL statement and a statement-transaction is automatically rolled back as a result, if a second error occurs during the statement rollback do a full transaction rollback instead. Otherwise the client can be left with an inconsistent cache. This can affect both WAL and rollback modes. (check-in: eb80ddc6 user: dan tags: trunk) | |
| 09:01 | If a malloc fails while allocating a savepoint object at the pager level, do not try to roll that savepoint back later on. (check-in: 91cb08ff user: dan tags: trunk) | |
|
2010-06-02
| ||
| 20:38 | When a lock fails due to an I/O error (not an SQLITE_BUSY) then the checkpoint should fail. (check-in: c6eb0a27 user: drh tags: trunk) | |
| 18:59 | Fix a problem with rolling back to a savepoint opened before the writer decided to wrap the log file. (check-in: 6b4aed6a user: dan tags: trunk) | |
| 17:15 | If an error occurs while writing frames to the log to commit a transaction, do not mark the pages as clean in the cache. Otherwise, the subsequent rollback does not roll them back (leaving the client to continue with a cache that makes it appear that the transaction was committed - inconsistent with the database on disk). (check-in: cb571c1b user: dan tags: trunk) | |
| 16:40 | Added implementation of vfslog_time() for Windows testing. (check-in: b3109f85 user: shaneh tags: trunk) | |
| 16:39 | Updated wal2.test for windows testing. (check-in: c3606f39 user: shaneh tags: trunk) | |
| 15:59 | Make sure the directory used by os_unix.c for shared-memory files is always the same, regardless of individual client permissions and environment variable settings. (check-in: f97bd520 user: drh tags: trunk) | |
| 15:43 | When walTryBeginRead() encounters an I/O error trying to set a lock (as opposed to SQLITE_BUSY) be sure to propagate that error back up the call stack. (check-in: aa2c2b67 user: drh tags: trunk) | |
| 14:45 | Changes to make WAL more robust against SHM locking failures and OOM errors. (check-in: ebf40413 user: drh tags: trunk) | |
| 14:43 | In the rowhash.test, make sure global variables are cleared prior to use. (check-in: 28efe0a4 user: drh tags: trunk) | |
| 12:58 | Undo one of the "const" markers from the previous check-in because the value needs to be changable, even if it is not actually ever changed in the current implementation. (check-in: c24ac356 user: drh tags: trunk) | |
| 05:53 | Add some 'const' markers to static data that is really constant. (check-in: e7073e23 user: dan tags: trunk) | |
|
2010-06-01
| ||
| 21:02 | The shared-memory used by WAL on linux now really is shared memory in /dev/shm. On other unix flavors, the file is in a temporary directory rather than in the same directory as the database. (check-in: fc18c4aa user: drh tags: trunk) | |
| 19:15 | Changes to the way faults are injected into xShmXXX VFS calls. (check-in: 716d99f3 user: dan tags: trunk) | |
| 17:46 | Change the OOM and IO error test cases in walfault.test so that each test case runs both types of error simulation. (check-in: b627e153 user: dan tags: trunk) | |
| 15:44 | Delay the decision to restart the log file until data is actually ready to be written to the log file (instead of at the start of a write transaction). (check-in: b1abfaaf user: dan tags: trunk) | |
| 15:24 | The incremental checkpoint feature is not perfect yet, but it is working well enough to merge it into the trunk. (check-in: 1d3e569e user: drh tags: trunk) | |
| 14:30 | Merge with [15abbc3416]. (Closed-Leaf check-in: f4b9003a user: dan tags: wal-incr-ckpt) | |
| 14:12 | If an attempt to get a read-lock on the WAL fails with SQLITE_BUSY_RECOVER, call the busy-handler at the btree level. (check-in: ce644965 user: dan tags: wal-incr-ckpt) | |
| 13:17 | Fix a bug introduced by the previous check-in but only seen if SQLITE_ENABLE_EXPENSIVE_ASSERTS is turned on. (check-in: 9c9ec899 user: drh tags: wal-incr-ckpt) | |
| 12:58 | Fix an off-by-one boundary-value issue in walCleanupHash(). (check-in: f039552e user: drh tags: wal-incr-ckpt) | |
| 11:08 | Do not hold the shared-memory mutex in os_unix.c if returning NULL. (check-in: 9622dd46 user: dan tags: wal-incr-ckpt) | |
| 10:44 | If the checkpoint fails to obtain an exclusive lock on one of the read-lock bytes, do not consider this an error. (check-in: 9e95e357 user: dan tags: wal-incr-ckpt) | |
| 07:51 | Fixes to the test cases in wal2.test. (check-in: cd5fbcbc user: dan tags: wal-incr-ckpt) | |
| 01:08 | Comment edits and cleanup in wal.c. No functional code changes. (check-in: e8e666ab user: drh tags: wal-incr-ckpt) | |
| 00:28 | Attempt to get the filectrl.test script running. (check-in: e46a8f2b user: drh tags: wal-incr-ckpt) | |
| 00:03 | Fix os_unix.c so that it will compile and build on a Mac. (check-in: bc707c83 user: drh tags: wal-incr-ckpt) | |
|
2010-05-31
| ||
| 20:28 | Fix issues with locking_mode=EXCLUSIVE in WAL. (check-in: 8deba0ce user: drh tags: wal-incr-ckpt) | |
| 18:24 | Add an "isInit" field in the wal-index header that must be non-zero for a valid header. Use this to detect an uninitialized wal-index. (check-in: a16fde19 user: drh tags: wal-incr-ckpt) | |
| 16:56 | Fix an inconsistent #ifdef in wal.c. Fix os_unix.c so that it does not allow moving an SHM lock directly exclusive to shared without going through unlocked. (check-in: 552658da user: drh tags: wal-incr-ckpt) | |
| 16:41 | Avoid dropping the checkpoint lock after a recovery run as a precursor to a checkpoint operation. (check-in: cc25cfa0 user: dan tags: wal-incr-ckpt) | |
| 16:17 | Zero the checkpoint header as the last step of successful WAL recovery. Avoid an unnecessary lock/unlock in WalBeginReadTransaction. (check-in: db3509c5 user: dan tags: wal-incr-ckpt) | |
| 16:10 | Get the new xShmLock interface design working on os_win.c. (check-in: 149a7082 user: drh tags: wal-incr-ckpt) | |
| 14:39 | Make sure WAL alway requests enough shared-memory space. (check-in: 138f1283 user: drh tags: wal-incr-ckpt) | |
| 14:28 | Remove the tests that enable tracing based on the existance of the "vdbe_*" files when in SQLITE_DEBUG mode. (check-in: cdbb4e7c user: drh tags: wal-incr-ckpt) | |
| 14:18 | Update another test case in wal.test. (check-in: 99fde69e user: dan tags: wal-incr-ckpt) | |
| 13:11 | Change WAL test cases to account for the improved concurrency in the new checkpoint logic. (check-in: 2d6f2485 user: drh tags: wal-incr-ckpt) | |
| 12:30 | Do not fail a checkpoint just because active readers prevent backfill. (check-in: 9aa4243e user: drh tags: wal-incr-ckpt) | |
| 12:15 | Add WALTRACE() macros to help with debugging and analysis. (check-in: 765c3318 user: drh tags: wal-incr-ckpt) | |
| 12:02 | Another minor fix to checkpoint on the WAL branch. (check-in: 853f1e3f user: dan tags: wal-incr-ckpt) | |
| 11:39 | Fix a bug in checkpoint introduced by [181ceb32ea]. (check-in: b499dbc8 user: dan tags: wal-incr-ckpt) | |
| 11:16 | Fix some asserts and other things in the new WAL branch. (check-in: 181ceb32 user: dan tags: wal-incr-ckpt) | |
| 06:38 | Changes to the way one of the WAL/OOM tests works. (check-in: 15abbc34 user: dan tags: trunk) | |
| 01:41 | WAL runs but quickly deadlocks. (check-in: ace58acb user: drh tags: wal-incr-ckpt) | |
|
2010-05-30
| ||
| 19:55 | Initial code for incremental checkpoint in WAL mode. This check-in compiles on unix and runs as long as you do not engage WAL mode. WAL mode crashes and burns. Consider this check-in a baseline implementation for getting the new capability up and running. (check-in: ef3ba7a1 user: drh tags: wal-incr-ckpt) | |
|
2010-05-29
| ||
| 08:40 | Add tests to fkey2.test to check that ON CONFLICT clauses do not affect SQLite's behaviour when an FK constraint is violated. (check-in: e9e5b100 user: dan tags: trunk) | |
| 06:18 | Minor changes to checksum related test cases. (check-in: 60c22bde user: dan tags: trunk) | |
|
2010-05-28
| ||
| 11:16 | Add a test to walcksum.test to stress the checksum calculation. (check-in: 778d0c17 user: dan tags: trunk) | |
|
2010-05-26
| ||
| 17:31 | Make sure the wal-index mapping is always large enough to cover the entire active area of the wal-index. (check-in: 42705bab user: drh tags: trunk) | |
| 15:06 | Change the semantics of xShmGet() such that it will never increase the size of shared memory. xShmSize() must be used to grow the size of shared memory. A shared memory segment size cannot be shrunk (except by dropping it). (check-in: 72de0073 user: drh tags: trunk) | |
|
2010-05-25
| ||
| 15:53 | Updated header comments in wal.c. No functional code changes. (check-in: 687632a6 user: drh tags: trunk) | |
| 15:23 | Add a busy-handler to a test case in walthread.test to prevent errors. (check-in: d3d348aa user: dan tags: trunk) | |
| 13:49 | Modify walcrash2.test so that it works with DEFAULT_AUTOVACUUM=1. (check-in: 77438882 user: dan tags: trunk) | |
| 13:40 | Update header comments in wal.c to correctly describe the WAL file format. Update the locking region offsets in os_unix.c and os_win.c and add assert() statement to verify that the locking region offsets are correct. (check-in: 40030c07 user: drh tags: trunk) | |
| 10:50 | If a writer exits unexpectedly in the middle of a transaction, have the following writer remove any wal-index hash-table entries left by the interrupted transaction. (check-in: ed77556a user: dan tags: trunk) | |
| 02:24 | Remove unreachable code associated with WAL from the pager. (check-in: 54c1718e user: drh tags: trunk) | |
|
2010-05-24
| ||
| 20:27 | OOM errors during an auto-checkpoint are benign. (check-in: 3d252ce5 user: drh tags: trunk) | |
| 20:24 | Remove the walmode.test case from the inmemory_journal test of permutations.test. (check-in: 27ba9c21 user: drh tags: trunk) | |
| 17:00 | Fix the wal2.test script so that it works in auto_vacuum mode. (check-in: 6a818afb user: drh tags: trunk) | |
| 13:57 | Change the checksum used in WAL files so that each frames checksum depends on the content of the WAL header and all frame headers and content up to and including the frame to which the checksum is attached. (check-in: 8a53f12c user: dan tags: trunk) | |
| 13:28 | Make sure a WAL frame of all zeros is detected as an invalid frame. (check-in: 02d99ad4 user: drh tags: trunk) | |
| 12:34 | Fix up test_osinst.c to work with SQLITE_OMIT_VIRTUALTABLE. (check-in: 51fd3815 user: drh tags: trunk) | |
| 10:39 | Change the WAL file format to support two kinds of checksums - one that is fast to calculate on little-endian architectures and another that is fast on big-endian architectures. A flag in the wal-header indicates which the file uses. (check-in: 65ba804d user: dan tags: trunk) | |
|
2010-05-22
| ||
| 08:22 | Add a couple of missing methods to test_osinst.c.. (check-in: 5c9e9c06 user: dan tags: trunk) | |
| 00:55 | Add several EXPENSIVE_ASSERT code blocks to validate the wal-index hash table. Fix the bugs that these code blocks fine. Rename walClearHash() to walCleanupHash() and simplify its interface. (check-in: 7aade899 user: drh tags: trunk) | |
|
2010-05-21
| ||
| 19:15 | Fix another bug in walClearHash(). (check-in: 40f80ffe user: dan tags: trunk) | |
| 18:24 | Comment out the SQLITE_FCNTL_SIZE_HINT from os_unix.c since it does not seem to provide any performance gain there. (check-in: 7d01309d user: drh tags: trunk) | |
| 16:23 | Correct an off-by-one bug in the previous commit. (check-in: 75a1130d user: dan tags: trunk) | |
| 15:31 | Remove entries from wal-index hash tables when a rollback or savepoint rollback occurs. (check-in: 36795c2b user: dan tags: trunk) | |
| 13:16 | Fix the wal-index header read routine so that it correctly detects a zero header as being malformed and in need of a wal-index rebuild. (check-in: 1a4eb3a3 user: drh tags: trunk) | |
|
2010-05-20
| ||
| 23:51 | Add a new xShmBarrier method to the VFS - a shared-memory fence operation. Implement the same in both unix and win32. Use it to make the WAL subsystem more robust. (check-in: 1bd011c9 user: drh tags: trunk) | |
| 21:21 | Make use of the extra information in the WAL header and frame header to enhance robustness. (check-in: 9580ecb7 user: drh tags: trunk) | |
| 16:45 | Convert the wal-header and frame-header to 24 bytes. Extra information in both headers is designed to enhance robustness after crashes, though the extra information is currently unused. This is a snapshot of a work in progress. (check-in: 66970643 user: drh tags: trunk) | |
|
2010-05-19
| ||
| 23:41 | Merge WIN32 WAL support into trunk. Still some issues with locking to resolve. (check-in: 43377663 user: shaneh tags: trunk) | |
| 19:39 | Add the SQLITE_FCNTL_SIZE_HINT to the os_win.c VFS. (check-in: 9894118d user: drh tags: trunk) | |
| 19:26 | Add the SQLITE_FCNTL_SIZE_HINT operator to sqlite3_file_control() and use it to give the VFS hints about the ultimate size of a database file when the file is growing. (check-in: 2b7e3b4a user: drh tags: trunk) | |
| 19:09 | Fix a bug in the new checkpoint computation. Also update the checkpoint algorithm in the test scripts to align with the new implementation. (check-in: 8b6056f2 user: drh tags: trunk) | |
| 18:08 | Revise the checksumming algorithm in wal.c. More variable refactoring. (check-in: 542b90eb user: drh tags: trunk) | |
| 17:49 | Refactoring some variable names in wal.c. (check-in: 1d201ff5 user: drh tags: trunk) | |
| 01:53 | Add a large comment to wal.c describing the WAL and wal-index file formats. (check-in: a71a22b5 user: drh tags: trunk) | |
|
2010-05-18
| ||
| 23:29 | Update the wal-index hash format so that hash-table space is reused following a rollback, thus preventing hash table overflows. Add assert()s to verify that hash tables do not overfill. Further refactoring of the wal-index code. (check-in: ada9a8c7 user: drh tags: trunk) | |
| 18:01 | Refactoring of the WalIterator implementation. (check-in: b5b60fdc user: drh tags: trunk) | |
| 13:27 | Mark the shared-memory in the WAL implementation as volatile. (check-in: 0a678790 user: drh tags: trunk) | |
| 12:56 | Comment clarifications in wal.c. (check-in: a029be10 user: drh tags: trunk) | |
|
2010-05-17
| ||
| 20:16 | Remove an unreachable test from wal.c. (check-in: 7162c456 user: drh tags: trunk) | |
|
2010-05-15
| ||
| 10:24 | Add a note to the documentation of sqlite3_wal_hook() to say not to return SQLITE_ROW or SQLITE_DONE. Or any other value that is not a valid SQLite error code. (check-in: 2f0b6cbf user: dan tags: trunk) | |
| 01:09 | Silently ignore errors trying to set the default journal_mode while doing an ATTACH. (check-in: b9af4ad2 user: drh tags: trunk) | |
|
2010-05-14
| ||
| 20:15 | Fix a typo that (by bad luck) was not a syntax error but which caused some important lines of code to be skipped when SQLITE_DEBUG was not used. (check-in: 9ef99d97 user: drh tags: trunk) | |
| 19:24 | Make sure the value of an INTEGER PRIMARY KEY column supplied to triggers and especially to FK constraints really contains the ROWID and not the NULL that is stored in the column itself. Ticket [dd08e5a988d00dec]. (check-in: 636f8609 user: drh tags: trunk) | |
| 16:34 | Pull in all the latest changes from the trunk. Update the win32 SHM methods to work with the new interface design. (Closed-Leaf check-in: 4b69f2cd user: drh tags: wal-win32) | |
| 14:52 | Simplifications to the SHM implementation in os_unix.c, taking advantage of the removal of the LinuxThreads mess. (check-in: d1debe5d user: drh tags: trunk) | |
| 12:43 | Simplify os_unix.c by removing support for LinuxThreads. Linux systems must either use NPTL or else not share database connections across threads. (check-in: e294b696 user: drh tags: trunk) | |
| 11:30 | Change the OSTRACEn() macro to OSTRACE(()). Also rename some internal fields and variables in os_unix.c to be more meaningful and searchable. (check-in: 5fe529f2 user: drh tags: trunk) | |
| 10:43 | Fix test_osinst.c so that it does not depend on gettimeofday() unless SQLITE_OS_UNIX is defined and NO_GETTOD is not defined. (check-in: 2a4014b7 user: dan tags: trunk) | |
| 08:39 | Add xShmXXX methods to test_osinst.c. (check-in: b8a9b37a user: dan tags: trunk) | |
|
2010-05-13
| ||
| 20:19 | Make debugging elements of the sqlite3_mutex object volatile and make them only appear when compiling with SQLITE_DEBUG. Ticket [51914f6acd2cb462]. (check-in: e823c60c user: drh tags: trunk) | |
| 15:44 | Allow sqlite3WalCheckpoint() to be called even if the WAL is in the SQLITE_SHM_READ state, as sometimes happens after an error. (check-in: 175b296f user: drh tags: trunk) | |
| 09:40 | Remerge mistaken test_osinst.c changes. (check-in: e8c10d3c user: dan tags: trunk) | |
| 09:32 | Fix mistake in test_osinst.c. (Closed-Leaf check-in: 4c3e1378 user: dan tags: mistake) | |
| 09:11 | Make sure xShmGet is never called while already holding the shared-memory segment. (check-in: 92ebdbc5 user: drh tags: trunk) | |
| 08:53 | The refactored of VFS SHM primitives are now working so merge the wal-refactor branch back into the trunk. (check-in: bce21c18 user: drh tags: trunk) | |
| 08:33 | Change the xShmSize() implementation in os_unix.c so that it will only increase and never decrease the size of a shared-memory segment. (Closed-Leaf check-in: 149d2ae4 user: drh tags: wal-refactor) | |
| 07:08 | Fix for a segfault that can follow a malloc failure. (check-in: 3cab9022 user: dan tags: wal-refactor) | |
| 06:19 | Modify the VFS in test_vfs.c to match the refactoring of the xShmXXX methods. (check-in: 25e72f81 user: dan tags: wal-refactor) | |
|
2010-05-12
| ||
| 19:02 | (Moved to the mistake branch due to compile errors in test_osinst.c.) Change the vfs instrumentation code in test_osinst.c to make it easier to deploy. Add a vtab implementation for reading the binary log file format. (check-in: ee13c884 user: dan tags: mistake) | |
| 18:30 | Fix for the test_devsym.c test module for the VFS-SHM refactoring. (check-in: 49d62933 user: drh tags: wal-refactor) | |
| 18:10 | A couple simple fixes to get wal.test mostly working. (check-in: c7445812 user: drh tags: wal-refactor) | |
| 18:01 | Refactoring the VFS-SHM methods used by WAL. This version compiles and runs non-WAL test cases but crashes and burns on wal.test. (check-in: 2b00152c user: drh tags: wal-refactor) | |
| 17:14 | Updates to WAL support in os_win.c: pulled in latest changes from src/os_unix.c; updated tracing; misc. improvements. (check-in: 76504726 user: shaneh tags: wal-win32) | |
| 13:50 | Remove the OP_Variable optimization of check-in [48b77b04935d894] since it can lead to malfunctions as described in ticket [26ff0c82d1e90]. (check-in: 7838163d user: drh tags: trunk) | |
| 06:54 | Remove a branch made redundant by the earlier exclusive-mode changes. (check-in: c501b2ed user: dan tags: trunk) | |
|
2010-05-11
| ||
| 16:29 | Have os_unix.c use the suffix "-wal-index" for wal-index files instead of "-wal-inde". (check-in: 885e854e user: dan tags: trunk) | |
| 14:00 | When an attempt to change journal_mode fails due to locks, be sure to leave internal structures in a consistent state. (check-in: cf3d1e0b user: drh tags: trunk) | |
| 12:19 | Changes so that WAL and exclusive-locking mode work together. (check-in: 71e7b1cf user: dan tags: trunk) | |
| 02:49 | Initial port of WAL VFS support from os_unix.c to os_win.c. (check-in: 111ad59f user: shaneh tags: wal-win32) | |
| 02:46 | Updates to WAL TCL test scripts to support running on Windows. (check-in: 6a563080 user: shaneh tags: trunk) | |
|
2010-05-10
| ||
| 19:51 | Fix an off-by-one error while constructing the name of the mmap file for the wal-index under os_unix.c. (check-in: 6e3735f7 user: drh tags: trunk) | |
| 18:10 | Merge [96d6eaf4d2] and [40b0a6357b]. (check-in: c67756c4 user: dan tags: trunk) | |
| 17:29 | Fix an uninitialized variable in OSX proxy locking. (check-in: 96d6eaf4 user: drh tags: trunk) | |
| 14:46 | Modify the format of the wal-index to use a hash table to index log file segments. (check-in: 40b0a635 user: dan tags: trunk) | |
| 14:10 | If an ATTACH command fails due to OP_JournalMode but still attaches the database, make sure VACUUM still detaches it when done. (check-in: 6ecdc7ba user: drh tags: trunk) | |
| 11:20 | Enhance the OP_JournalMode opcode with an ignore-errors option and use that option the ATTACH command. (check-in: 0bdea4cf user: drh tags: trunk) | |
|
2010-05-07
| ||
| 20:34 | When running a checkpoint while in locking_mode=EXCLUSIVE, be sure to move the wal-index lock to UNLOCK from READ prior to promoting to CHECKPOINT. (check-in: be114bdf user: drh tags: trunk) | |
| 20:02 | Change the xShmOpen() method of the VFS to take the database file name as its argument, not the WAL file name. Also fix some unrelated compiler warnings. (check-in: a65c2939 user: drh tags: trunk) | |
| 18:23 | Additional tweaks to API documentation. No functional code changes. (check-in: e1230782 user: drh tags: trunk) | |
| 13:57 | Updates to documentation on the C interfaces supporting WAL. No functional changes to code. (check-in: 681ba20c user: drh tags: trunk) | |
| 13:52 | Fix a recently introduced problem in wal.test. (check-in: 79b52d0f user: dan tags: trunk) | |
| 12:49 | Change wal.test and walhook.test so that they work with DEFAULT_AUTOVACUUM=1 builds. (check-in: 4cde9290 user: dan tags: trunk) | |
| 09:43 | Test another IO error case in wal.c. (check-in: 8b3b5ab8 user: dan tags: trunk) | |
| 06:59 | Fix a problem with checkpointing large log files created by an external process. (check-in: 8f94bde5 user: dan tags: trunk) | |
| 05:46 | Since walIndexTryHdr() can no longer encounter any error conditions, change tehe function signature so that it does not return an error code. This removes unreachable branches from other code. (check-in: 061a282c user: dan tags: trunk) | |
| 00:28 | Another attempt to fix permutations.test so that it excludes WAL tests from the journaltest permutation. (check-in: 58c40442 user: drh tags: trunk) | |
|
2010-05-06
| ||
| 22:21 | Remove savepoint6.test from the set of tests run by journaltest since savepoint6.test uses journal_mode=WAL. (check-in: 811b45a9 user: drh tags: trunk) | |
| 21:37 | The PRAGMA journal_mode=WAL; command now makes WAL the default journal mode for new databases added with ATTACH, so the behavior is consistent with the other journal modes. (check-in: c3520460 user: drh tags: trunk) | |
| 20:19 | Make sure to do a clean shutdown of the library upon existing the shell in order to remove WAL files. (check-in: c1762dda user: drh tags: trunk) | |
| 19:55 | Exclude all WAL tests from the journaltest permutation. (check-in: 46c97d7e user: drh tags: trunk) | |
| 19:20 | Changes to support SQLITE_OMIT_WAL. (check-in: 32a8501d user: shaneh tags: trunk) | |
| 19:04 | Updates to the VFS SHM locking documentation. (check-in: 9927ce42 user: drh tags: trunk) | |
| 18:48 | Instead of transitioning to RECOVER state from CHECKPOINT when a recovery is required, perform the recovery while holding the CHECKPOINT lock. (check-in: bb0b6021 user: dan tags: trunk) | |
| 18:27 | If recovery is run before a checkpoint, change back to a CHECKPOINT lock before performing the actual checkpoint. (check-in: dc98ee16 user: dan tags: trunk) | |
| 18:04 | Only pass -1 as the size parameter to xShmGet when the caller does not care what size mapping is returned. Only call xShmSize when the underlying allocation (not the mapping) should be resized. (check-in: 637f51dd user: dan tags: trunk) | |
| 17:28 | Fix a bug whereby an old snapshot could be checkpointed (and subsequent transactions discarded) if the last connection to disconnect from a WAL database happended to be holding an out-of-date wal-index header. (check-in: d0c0034b user: dan tags: trunk) | |
| 16:06 | After throwing an error to say that one cannot change into WAL mode within a tranactions, do not then go and change into WAL mode. (check-in: 56a17dae user: drh tags: trunk) | |
| 15:56 | Further coverage tests. (check-in: 98a9713e user: dan tags: trunk) | |
| 15:36 | Update configure scripts for WAL support. (check-in: 2edc5129 user: shaneh tags: trunk) | |
| 14:42 | Add tests to cover a couple of branches in wal.c. (check-in: 429f437f user: dan tags: trunk) | |
| 13:36 | Unset a tcl variable before reusing it in wal.test. (check-in: e83efb23 user: dan tags: trunk) | |
| 12:15 | Add tests for some lock-contention cases. (check-in: f0fcb9c9 user: dan tags: trunk) | |
| 11:56 | Remove the noop-mutex implementations of mutex_held() and mutex_notheld() since they are both unreachable. (check-in: 6767b62a user: drh tags: trunk) | |
| 11:55 | Add two text files containing pager design notes to the doc/ subfolder. (check-in: ed817fc8 user: drh tags: trunk) | |
| 11:32 | Add test cases to test the libraries handling of corrupt wal-index headers. (check-in: 9465b267 user: dan tags: trunk) | |
| 07:43 | Add tests for handling errors returned by xShm VFS methods. (check-in: fbbcacb1 user: dan tags: trunk) | |
|
2010-05-05
| ||
| 20:00 | Change the behavior of the sqlite3_wal_hook() callback. It should now return SQLITE_OK or an error code and the error code is propagated back up the stack. If a checkpoint is desired, the callback should invoke sqlite3_wal_callback() itself. (check-in: 1b14195e user: drh tags: trunk) | |
| 19:09 | Further simplifications to the SHM locking logic. Remove the SQLITE_SHM_QUERY option. Unify the WRITE to READ and RECOVER to READ transitions. (check-in: e9bfa6e4 user: drh tags: trunk) | |
| 19:04 | Test the handling of errors returned by the xShmXXX() APIs. (check-in: 72663123 user: dan tags: trunk) | |
| 18:46 | Do not compare page sizes on source and destination of backup until transactions are started and the page sizes are locked. This is a fix to check-in [7bd44794c4]. (check-in: ec715778 user: drh tags: trunk) | |
| 18:20 | Simplifications to the SHM locking implementation in os_unix.c. (check-in: 9de05bfb user: drh tags: trunk) | |
| 16:23 | Prohibit backup if the destination is using WAL and has a different page size from the source. (check-in: 7bd44794 user: drh tags: trunk) | |
| 15:33 | When closing a WAL database, if the exclusive lock on the database file is obtained and the database successfully checkpointed, delete the wal-index file from the file system. (check-in: 2ac5d96c user: dan tags: trunk) | |
| 04:11 | Make sure the page size of the main database is fixed following a failed VACUUM attempt. Otherwise, two consecutive failed VACUUM attempts with attempted page_size changes on encrypted or WAL databases could result in database corruption. (check-in: 208e7d5d user: drh tags: trunk) | |
| 03:39 | Do not attempt to modify the page_size when running VACUUM on a WAL database. (check-in: 58a1a59b user: drh tags: trunk) | |
| 00:22 | Get the previous mutex fix working with SQLITE_DEBUG and with the amalgamation. (check-in: df19928f user: drh tags: trunk) | |
| 00:05 | When the in single-threaded mode, the sqlite3_mutex_alloc() interface still returns a non-NULL value. The mutex doesn't do anything, but it tests non-NULL. This way, extensions (or VFSes) that use sqlite3_mutex_alloc() can tell the difference between an OOM error and mutexes being disabled. (check-in: 451fd175 user: drh tags: trunk) | |
|
2010-05-04
| ||
| 18:50 | When sqlite3PagerPagecount() is called without any locks, always return the physical file size, not the logical file size. (check-in: 4016b422 user: drh tags: trunk) | |
| 17:38 | Be sure to release all wal-index locks before closing the wal-index. (check-in: b15b67fa user: drh tags: trunk) | |
| 17:20 | Relax an over-zealous assert() in sqlite3WalUndo(). (check-in: 8f9d22d5 user: drh tags: trunk) | |
| 16:33 | Take care not to invoke the xShmClose method of the VFS with a NULL shared memory object. (check-in: 1465d384 user: drh tags: trunk) | |
| 15:20 | Add a test case to verify that log files containing pages that are not a power-of-two bytes in size are handled correctly. (check-in: c2bf693f user: dan tags: trunk) | |
| 14:47 | Fix problems with recovering wal files that use a page-size other than the default. (check-in: 1a391f3c user: dan tags: trunk) | |
| 11:06 | Fix a typo in walfault.test. (check-in: 232dbe8e user: dan tags: trunk) | |
| 10:36 | Test that the correct number of padding frames are appended to the log file after committing a transaction in synchronous=FULL mode. (check-in: a60104aa user: dan tags: trunk) | |
|
2010-05-03
| ||
| 19:20 | Unset some global TCL variables prior to use in test where prior tests can have those same variables set to an array value. (check-in: 49bef00e user: drh tags: trunk) | |
| 19:17 | Fix a bug in the computation of the current time for the alternative CURRENT_TIMESTAMP functions used when SQLITE_OMIT_DATETIME is defined. (check-in: e7ded46b user: drh tags: trunk) | |
| 18:51 | Documentation stubs for sqlite3_wal_autocheckpoint and sqlite3_wal_checkpoint. (check-in: 31376242 user: drh tags: trunk) | |
| 18:22 | Fix a bug in the xCurrentTime() method of the os_unix.c VFS. (check-in: 551df11a user: drh tags: trunk) | |
| 18:01 | Add a test to simulate an OOM during log recovery to walfault.test. (check-in: 7ed85e87 user: dan tags: trunk) | |
| 17:24 | Clear global variable "seconds" before use in walthread.test. (check-in: a35551a5 user: drh tags: trunk) | |
| 17:18 | Fix a couple of errors in WAL code that can occur in an OOM situation. (check-in: 9d3f3736 user: dan tags: trunk) | |
| 16:36 | Update the crash-test VFS in test6.c to pass-through the shared-memory methods to the real underlying VFS. This fixes the walcrash.test script. (check-in: ea09ff37 user: drh tags: trunk) | |
| 16:30 | Change the VFS definition so that all methods take a VFS object pointer as their first parameter. (check-in: 43b5b07f user: drh tags: trunk) | |
| 15:58 | Have sqlite3_wal_checkpoint() handle a zero-length string in the same way as a NULL pointer. Fix "PRAGMA wal_checkpoint" so that it checkpoints all attached databases. (check-in: 7fecd21f user: dan tags: trunk) | |
| 14:32 | Use VFS method xCurrentTimeInt64 instead of xCurrentTime when it is available. Provide an implementation of xCurrentTimeInt64 for os_unix.c. (check-in: ab77b3ae user: drh tags: trunk) | |
| 14:08 | Merge the write-ahead-logging changes into the trunk. (check-in: de9ae443 user: drh tags: trunk) | |
| 14:05 | If the sqlite3_wal_checkpoint() API is passed a NULL pointer in place of a database name, attempt to checkpoint all attached databases. (Closed-Leaf check-in: 27a5c09c user: dan tags: wal) | |
| 13:37 | Make sure the mutex is held while calling sqlite3ApiExit() in sqlite3_wal_checkpoint(). Other cleanup of WAL logic. (check-in: 11a85b82 user: drh tags: wal) | |
| 12:14 | Have sqlite3_wal_checkpoint() populate the database handle error message and error code (as returned by sqlite3_errmsg() and sqlite3_errcode()). (check-in: ff234cf5 user: dan tags: wal) | |
| 11:05 | Add the "PRAGMA wal_autocheckpoint" command. Rename "PRAGMA checkpoint" to "PRAGMA wal_checkpoint". (check-in: 714e5947 user: dan tags: wal) | |
| 08:19 | Merge two wal leaves. (check-in: 23c0e6c3 user: dan tags: wal) | |
| 08:04 | Add the sqlite3_wal_checkpoint() and sqlite3_wal_autocheckpoint() APIs. (check-in: 9803196d user: dan tags: wal) | |
|
2010-05-01
| ||
| 20:17 | Change the SHM interface so that it does not take the name of the shared object but rather the name of the WAL file and derives its own name from that. Remove the xShmDelete method from the VFS and replace it with a delete flag on xShmClose. (check-in: 94dea5f9 user: drh tags: wal) | |
| 18:23 | Remove the xShmPush and xShmPull methods from the VFS. (check-in: 69e07fdb user: drh tags: wal) | |
| 17:57 | Define an invariant to guarantee deadlock-free operation of SHM in os_unix.c and check that invariant with assert() statements. (check-in: 6af2dca7 user: drh tags: wal) | |
| 17:50 | Rework mutexes on the SHM implemention for os_unix to avoid a deadlock during WAL recovery. (check-in: 1a0f69be user: drh tags: wal) | |
| 16:40 | Support compile-time option SQLITE_OMIT_WAL, for building without WAL support. (check-in: 9b230c43 user: dan tags: wal) | |
| 11:33 | Fix a typo in the walmode.test test script introducted yesterday. (check-in: dcabc90c user: drh tags: wal) | |
| 11:19 | Fix the sqlite3_mutex_alloc() interface to return NULL (not segfault) when operating in threadsafe mode. (This is a general-purpose bug fix which really ought to be ported to trunk.) (check-in: 64840a3c user: drh tags: wal) | |
| 08:30 | Add test case demonstrating deadlock during recovery of very large log files. No fix yet. (check-in: 63ea318e user: dan tags: wal) | |
| 00:59 | Do not allow journal_mode=WAL if the underlying VFS does not support xShmOpen. (check-in: d1fcccec user: drh tags: wal) | |
|
2010-04-30
| ||
| 22:28 | Merge in changes from the trunk. (check-in: 76bf0eee user: drh tags: wal) | |
| 21:03 | Avoid assertion faults in queries using indices with redundant columns. Ticket [3dbdcdb14e7f41]. (check-in: 946e06cd user: drh tags: trunk) | |
| 17:47 | Change the SHM VFS logic in os_unix.c so that it does not hold an exclusive lock n the mapped memory when also holding a CHECKPOINT lock. This improves concurrency between readers and checkpointers. (check-in: 8660cda6 user: drh tags: wal) | |
| 17:28 | Remove some obsolete debugging parameters. (check-in: a012aed4 user: drh tags: wal) | |
| 17:05 | Fix a problem with resizing the wal-index mapping after the mapping has been extended by an external process. (check-in: 79d356fe user: dan tags: wal) | |
| 16:50 | Fix a problem with calculating the required size of the wal-index when appending frames. (check-in: 9526b111 user: dan tags: wal) | |
| 16:48 | In the debugging output for SHM-LOCK in os_unix.c, use symbolic names for the lock states rather than raw numbers. (check-in: 2afc33de user: drh tags: wal) | |
| 16:41 | Fix a problem in the previous commit. Both unixShm.lockState and unixShm.readLock should be set to READ when downgrading from a WRITE to a READ lock (check-in: 90119fec user: dan tags: wal) | |
| 16:38 | Fix a bug whereby upgrading from a READ_FULL to a WRITE lock, and then back to a read lock was dropping all WAL locks. (check-in: 55f5af5e user: dan tags: wal) | |
| 16:24 | Reapply commits [837d82a929] and [c05e7dca17] that were accidentally overwritten. (check-in: 598de527 user: dan tags: wal) | |
| 16:19 | Add xShmXXX() methods to the test VFS in test_devsym.test. (check-in: 1d203424 user: dan tags: wal) | |
| 16:12 | Correctly record the fact that the SHM lock reached PENDING if it did so but failed to reach CHECKPOINT. (check-in: d9250e84 user: drh tags: wal) | |
| 15:54 | Fix a couple uninitialized variables in the xShmLock method of the unix VFS. Improved debugging logic for xShmLock. (check-in: 69567c5f user: drh tags: wal) | |
| 15:49 | When closing a WAL connection, attempt an exclusive lock on the database file. If the lock is obtained, checkpoint the database and delete the wal and wal-index files. (check-in: c05e7dca user: dan tags: wal) | |
| 15:24 | If a reader attempts to upgrade to a writer, but is not reading the most recent database snapshot, return SQLITE_BUSY. (check-in: 837d82a9 user: dan tags: wal) | |
| 14:39 | Separate the concepts of underlying storage size and mapped size in the VFS shared-memory implementation. (check-in: 4cbe49f1 user: drh tags: wal) | |
| 11:43 | Add a missing walIndexUnmap() call to the checkpoint code. Change a couple of SQLITE_CANTOPEN constants to SQLITE_CANTOPEN_BKPT. (check-in: 1f9e8c5c user: dan tags: wal) | |
| 10:24 | Fix an assert() in sqlite3WalRead(). (check-in: 2e7a0050 user: dan tags: wal) | |
| 10:06 | Add missing mutexes to unixShmClose(). (check-in: a4741cb5 user: dan tags: wal) | |
| 09:52 | Fix a couple of assert() statements in os_unix.c and wal.c. Combine sqlite3WalIsDirty() with sqlite3WalUndo(). (check-in: a8f958be user: dan tags: wal) | |
| 09:32 | Add a missing walIndexUnmap() to sqlite3WalSnapshotOpen(). (check-in: 72b95fde user: dan tags: wal) | |
| 06:02 | Merge latest bugfix into wal branch. (check-in: 265e66e6 user: dan tags: wal) | |
| 05:57 | Zero the "immediate FK constraint counter" associated with a statement object when sqlite3_reset() is called. Fix for [c39ff61c43]. (check-in: f660be61 user: dan tags: trunk) | |
| 02:13 | The first 6 WAL tests now work. It's a start. (check-in: a92c1851 user: drh tags: wal) | |
|
2010-04-29
| ||
| 22:34 | Refactor wal.c to use the VFS. This check-in compiles and links and works ok as long as you leave WAL turned off, but WAL does not work. (check-in: 62db5fa3 user: drh tags: wal) | |
| 16:40 | Untested implementation of the shared-memory dead-man-switch. (check-in: 70661128 user: drh tags: wal) | |
| 15:17 | Progress towards a VFS that will support WAL. Locking code is in place but is untested. Still no support for the DMS. (check-in: 1bde41cf user: drh tags: wal) | |
| 14:58 | Close all open database connections at the end of wal.test. (check-in: 3cc55a75 user: dan tags: wal) | |
| 14:51 | Fix a bug in the WAL checkpoint code causing SQLite to use an inconsistent cache in a subsequent transaction. (check-in: d1cadeed user: dan tags: wal) | |
| 08:47 | Add tests to walthread.test. (check-in: 9e891e75 user: dan tags: wal) | |
|
2010-04-28
| ||
| 18:17 | Add a test to walthread.test for changing between WAL and rollback modes. (check-in: da229e44 user: dan tags: wal) | |
| 17:49 | Merge two "wal" leaves. (check-in: 13d2d5a6 user: dan tags: wal) | |
| 17:48 | Change walthread.test so that tests can be run with either multiple threads or multiple processes. (check-in: 25f85f68 user: dan tags: wal) | |
| 17:21 | Changes to the interface design for the xShmLock method of the VFS. (check-in: 348409de user: drh tags: wal) | |
| 14:42 | Rename the sqlite3_log_hook() to sqlite3_wal_hook(). Added comments to wal.h. (check-in: bbc38511 user: drh tags: wal) | |
|
2010-04-27
| ||
| 18:49 | Merge two "wal" leaves. (check-in: 8c2d43ba user: dan tags: wal) | |
| 18:43 | Add a test to check that a checkpointer releases its locks before returning, even if it has been prevented by a conflicting lock from checkpointing the database. (check-in: be44349d user: dan tags: wal) | |
| 14:37 | Fix a problem with identifying a corrupt database in WAL mode. (check-in: c8658da4 user: dan tags: wal) | |
| 11:49 | Add the xShmRelease() method to the VFS. The os_unix.c implementation of the shared memory logic is still non-functional. (check-in: ed715b47 user: drh tags: wal) | |
| 06:49 | Run trans.test and avtrans.test as part of the "wal" permutation. (check-in: c8893310 user: dan tags: wal) | |
| 05:42 | Fix a problem that occurs when one process causes the log-summary file to grow and then a second process attempts to read the database. (check-in: b51a5f8b user: dan tags: wal) | |
| 01:56 | Merge in recent changes from the trunk (check-in: 7a0ac682 user: drh tags: wal) | |
|
2010-04-26
| ||
| 19:17 | Optimization: Convert an ORDER BY clause into a no-op if the query also contains a GROUP BY clause that will force the same output order. (check-in: ca9d86ba user: drh tags: trunk) | |
| 17:42 | Do not attempt to set journal_mode=wal on :memory: or temp file databases. (check-in: 30d01344 user: dan tags: wal) | |
| 17:36 | Change the default_cache_size pragma to always store a positive value. (check-in: 36fb2cae user: drh tags: trunk) | |
| 17:30 | Identify the SQLite version meta-value entry in the db-header output of showdb. (check-in: 245d934b user: drh tags: trunk) | |
| 16:57 | Fixes for problems with small caches and SAVEPOINT rollback in WAL mode. (check-in: 6a944f02 user: dan tags: wal) | |
| 16:47 | Further enhancements to the showdb utility: A page number followed by "b" causes a btree decoding to occur on the page. (check-in: 2ff824e5 user: drh tags: trunk) | |
| 15:44 | Enhancements to the showdb.c utility program. Automatically detect the page size and adjust the display accordingly. Add the "dbheader" display option. (check-in: 23eb408b user: drh tags: trunk) | |
| 12:39 | Add the "wal" permutation to run existing test files savepoint.test and savepoint2.test in WAL mode. (check-in: 205e5d8a user: dan tags: wal) | |
| 10:40 | Add mutexes to fix a race condition in wal.c. This isn't a very good fix. (check-in: 3d159939 user: dan tags: wal) | |
| 00:19 | Change the names of the log.c and log.h source files to wal.c and wal.h. (check-in: 56fe5d76 user: drh tags: wal) | |
| 00:04 | Begin moving WAL-specific I/O into the VFS. This checkin contains VFS infrastructure but it is untested and is not yet hooked up to the WAL. The version number is bumped to 3.7.0 because of the VFS extension. (check-in: f5e615c2 user: drh tags: wal) | |
|
2010-04-25
| ||
| 20:58 | Remove an unreachable branch from the function initialization logic. (check-in: 064d3ddd user: drh tags: trunk) | |
|
2010-04-24
| ||
| 19:07 | Add comment explaining checksum mechanism. (check-in: 3e9ef515 user: dan tags: wal) | |
| 18:44 | Fix bugs in WAL mode rollback. (check-in: 31215969 user: dan tags: wal) | |
| 14:33 | Merge with [0291ed974d]. Merge with [0291ed974d]. Merge with [0291ed974d]. (check-in: a352f628 user: dan tags: wal) | |
| 14:02 | When commands such as ALTER TABLE and VACUUM use SQL internally, make sure they use only the built-in functions and not application-defined overrides for those functions. (check-in: 0291ed97 user: drh tags: trunk) | |
| 04:53 | Merge with [e79dac3c2f]. (check-in: 1e793d3a user: dan tags: wal) | |
| 04:49 | Reserve some space at the start of the log-summary file to apply locks to. (check-in: a031aa1f user: dan tags: wal) | |
|
2010-04-23
| ||
| 19:15 | Fixes and tests for backup of a WAL database. (check-in: 480d12db user: dan tags: wal) | |
| 14:29 | Merge of notify.c changes from experimental. Reset stored blocking connection when registered unlock_notify callback is cleared. (check-in: e79dac3c user: shaneh tags: trunk) | |
| 11:44 | Add very simple test cases for backup and VACUUM of WAL databases. More to come. (check-in: 1077d813 user: dan tags: wal) | |
|
2010-04-22
| ||
| 19:14 | Create a version of the log checksummer that works on big-endian platforms. Remove the 512KB size limit on the log-summary. (check-in: 5d6d4423 user: dan tags: wal) | |
| 06:27 | Further tests and changes related to switching between WAL and rollback modes. (check-in: 12363184 user: dan tags: wal) | |
|
2010-04-21
| ||
| 18:37 | Tests for (and changes to) the code to switch between WAL and rollback modes. (check-in: 9f4f933f user: dan tags: wal) | |
| 11:43 | If, after obtaining a SHARED lock, there exists a *-wal file in the file-system, use WAL mode. This is necessary to recover from a crash that damages the first page of the database file. (check-in: 33cabf27 user: dan tags: wal) | |
| 06:19 | Minor changes to test cases to account for the fact that databases with read/write versions of 2 are now understood. (check-in: 278ed41e user: dan tags: wal) | |
|
2010-04-20
| ||
| 18:53 | Use the read and write version fields of the database header to mark a database as operating in wal-mode. (check-in: 96bef18c user: dan tags: wal) | |
|
2010-04-19
| ||
| 18:03 | Add the sqlite3_log_hook() interface for scheduling checkpoints. (check-in: 9bda6014 user: dan tags: wal) | |
|
2010-04-17
| ||
| 18:50 | Add some comments regarding file-locks to log.c. (check-in: 9d51c3b7 user: dan tags: wal) | |
| 17:34 | Do not sync any files in wal mode if "PRAGMA synchronous=off" is set. If files are synced, pass either SQLITE_SYNC_FULL or SQLITE_SYNC_NORMAL to the xSync() callback as configured by "PRAGMA fullfsync". (check-in: 0ae91b00 user: dan tags: wal) | |
| 16:10 | It is possible for sqlite3.pUnlockConnection to be non-NULL when sqlite3.pBlockingConnection is NULL, as the notify1.test script demonstrates. (Closed-Leaf check-in: 95ff76ef user: drh tags: experimental) | |
| 15:45 | Merge with trunk commit [3e646e3f4c]. (check-in: 43463970 user: dan tags: wal) | |
| 15:42 | In synchronous=normal mode, do not sync the log after every transaction. In synchronous=full mode, sync the log and add any extra frames required to avoid blast-radius related problems after each transaction. (check-in: 9bc9b684 user: dan tags: wal) | |
| 12:53 | Change sqlite3_step() so that it automatically calls sqlite3_reset() instead of returning SQLITE_MISUSE when invoked on a prepared statement that previously returned any value other than SQLITE_ROW. (check-in: 3e646e3f user: drh tags: trunk) | |
| 12:31 | Enhancements to wal-mode locking scheme. (check-in: 8549c286 user: dan tags: wal) | |
|
2010-04-16
| ||
| 22:05 | Changes for branch coverage of notify.c. Fixed quirk of unlock_notify() where it would still think it was blocked after a callback was cleared (even after the transaction on the blocking connection was closed). (check-in: c54e8dad user: shaneh tags: experimental) | |
| 13:59 | Change the log file format to include a small (12 byte) header at the start of the file. (check-in: 9865d14d user: dan tags: wal) | |
| 11:30 | Fix bug in log recovery (last frame in log was being ignored). Also remove an incorrect assert statement. (check-in: 67d2a89e user: dan tags: wal) | |
|
2010-04-15
| ||
| 23:24 | Disable query flattening when the outer query is a compound SELECT and the inner query has a LIMIT clause. Ticket [02a8e81d44]. (check-in: f96782b3 user: drh tags: trunk) | |
| 16:45 | Allow writers to write dirty pages to the log mid-transaction in order to free memory. (check-in: ecd828f9 user: dan tags: wal) | |
| 13:33 | Merge two leaves on the WAL branch. (check-in: c9ed66cc user: dan tags: wal) | |
| 13:29 | The query planner fix of check-in [33b1f584ef] should have been on the trunk. (check-in: f538d759 user: drh tags: trunk) | |
| 12:36 | Fix a problem in the result set size estimation logic of the query planner - a problem introduced by the two previous changes. (check-in: 33b1f584 user: drh tags: wal) | |
| 10:58 | Change the way checksums are calculated. (check-in: 84955c2e user: dan tags: wal) | |
| 02:37 | Bring over the recent query planner enhancements from the trunk. (check-in: 82969f27 user: drh tags: wal) | |
| 01:04 | Further refinements to table order selection on join query planning. (check-in: defaf0d9 user: drh tags: trunk) | |
|
2010-04-14
| ||
| 19:01 | The query planner uses non-indexable WHERE clause terms to reduce the estimated number of output rows, then uses the estimated number of output rows as a tie-breaker when choosing table order. (check-in: b87cb0c2 user: drh tags: trunk) | |
| 18:50 | Add tests and fix bugs in WAL locking mechanism. (check-in: c18077f2 user: dan tags: wal) | |
| 18:06 | Add tests to check inter-process WAL locking. (check-in: 9435f313 user: dan tags: wal) | |
| 15:49 | Improve the logLockRegion() function in log.c. (check-in: 5e9dd3bd user: dan tags: wal) | |
| 11:23 | Fixes for locking issues in WAL mode. (check-in: a9617eff user: dan tags: wal) | |
|
2010-04-13
| ||
| 19:27 | Add experimental locking scheme. (check-in: 3f958e87 user: dan tags: wal) | |
| 15:30 | Fix an uninitialized variable in readDbPage of pager.c. (check-in: f4e1150f user: drh tags: wal) | |
| 11:56 | Remove old code to interpret an argument (no longer used) to "PRAGMA checkpoint". (check-in: 27dc5977 user: dan tags: wal) | |
| 11:45 | Fix other problems in the WAL test scripts. (check-in: dcb31181 user: dan tags: wal) | |
| 11:35 | Fix test script issues preventing walthread.test from running. (check-in: d90b1dde user: dan tags: wal) | |
| 11:18 | Fix a pager bug introduced by the wal code. (check-in: 4a0b29dc user: dan tags: wal) | |
| 06:20 | Sync wal branch with [012cf101bf]. (check-in: 9d690f24 user: dan tags: wal) | |
| 06:18 | Test that the rollback-hook is invoked if a commit-hook implementation returns non-zero (causing a rollback). Remove documentation comment that says otherwise from sqlite.h.in. (check-in: 012cf101 user: dan tags: trunk) | |
|
2010-04-12
| ||
| 20:54 | Add e_fts3.test to the set of tests excluded from the inmemory_journal exclusion list, since it does simulated OOM errors which trigger I/O errors and SQLite is unable to recover from I/O errors without a persistent journal. (check-in: e7e7127f user: drh tags: trunk) | |
| 19:44 | Recent changes cause the xSync method of the memory journal implementation to be used, so remove the assert(0). (check-in: 1f2cb940 user: drh tags: trunk) | |
| 19:43 | Clear a global variable in e_fts3.test before it is used. (check-in: ae89dfd2 user: drh tags: trunk) | |
| 19:32 | Remove duplicate secure_delete pragma implemention. (check-in: c15fda14 user: drh tags: wal) | |
| 19:05 | Add "log.h", which should have been part of the previous commit. (check-in: 8de9f010 user: dan tags: wal) | |
| 19:00 | Import experimental write-ahead-logging code. (check-in: 409d61ba user: dan tags: wal) | |
| 17:08 | Fix a problem where a process in exclusive mode could delete a hot-journal file without rolling it back from within sqlite3_close() or DETACH. This problem was introduced by commits from the past few days; it is not present in any release. (check-in: 51a61395 user: dan tags: trunk) | |
| 14:51 | Reset the simulated device in the test harness to its default configuration whenever it is restarted. (check-in: 562d20e6 user: drh tags: trunk) | |
|
2010-04-10
| ||
| 17:52 | Fix issues and clarify the operation of pager_playback_one_page(). A block comment in pager.c identifies 13 invariants on the pager subsystem. Ticket [9d68c883132c8]. (check-in: 09065976 user: drh tags: trunk) | |
|
2010-04-09
| ||
| 23:05 | Add a test case for the OOM-fault corruption issue. Ticket [9d68c883132c8]. (check-in: 0a64a937 user: drh tags: trunk) | |
| 15:34 | Candidate fix for a pager bug associated with sqlite3PagerMovepage(). (check-in: 8c046eb6 user: drh tags: trunk) | |
| 09:14 | Avoid unnecessary calls to sqlite3_step() with null prepared statements while parsing the schema. (check-in: ae04d2d1 user: drh tags: trunk) | |
|
2010-04-08
| ||
| 17:35 | Fix a typo in a comment. No changes to code. (check-in: 332cb551 user: drh tags: trunk) | |
| 17:28 | Fix code coverage problems in where.c. (check-in: b04a5282 user: drh tags: trunk) | |
| 16:30 | Additional automatic index tests. (check-in: 99d8e325 user: drh tags: trunk) | |
| 15:01 | New test cases for automatic indices. New testcase() macros associated with column-used bitmasks. (check-in: e1aa48ac user: drh tags: trunk) | |
| 15:01 | Fix the computation of the number of rows in a table during automatic index generation. (check-in: edeab06a user: drh tags: trunk) | |
| 14:38 | Fix an integer overflow bug in the automatic index logic. The bug was detected by the testcase() macros added in the previous check-in. Also add some more testcase() macros, since this issue points up their importance. (check-in: af97b488 user: drh tags: trunk) | |
| 14:15 | Add testcase() macros to the automatic index logic to insure that boundary cases are tested. (check-in: 72865478 user: drh tags: trunk) | |
| 11:35 | Make sure F_OK, R_OK, and W_OK are defined in test_demovfs.c. Define them manually if they are not. This is necessary to get the module to compile on some systems. (check-in: 7c8afc32 user: drh tags: trunk) | |
| 01:16 | Merge automatic index changes into the trunk. (check-in: bf7b8d86 user: drh tags: trunk) | |
| 00:40 | When constructing automatic indices do not include the same column more than once. (Closed-Leaf check-in: d067d9f7 user: drh tags: experimental) | |
|
2010-04-07
| ||
| 20:32 | Pull over the latest changes from the trunk. (check-in: e388fe8b user: drh tags: experimental) | |
| 20:29 | When rolling back a savepoint to the beginning of the transaction, make sure to initialize the database size in the btree layer correctly even if the database size field of the header is zeroed. (check-in: a3540c6a user: drh tags: trunk) | |
| 19:32 | Add an interface to the SQLITE_STMTSTATUS_AUTOINDEX status information to the TCL bindings. Add some simple automatic index test cases. (check-in: 1f404412 user: drh tags: experimental) | |
| 16:54 | Wrap all automatic index changes inside SQLITE_OMIT_AUTOMATIC_INDEX. Add the automatic_index PRAGMA to turn it on and off. (check-in: a811a47f user: drh tags: experimental) | |
| 14:59 | Make sure that all automatic indices are covering indices. Otherwise, the table and index might be used together in a query but the table could get out of sync with the automatic index through out-of-band changes. (check-in: 23643131 user: drh tags: experimental) | |
| 14:33 | Enhance comments on the SrcList object definition to better explain the operation of the SrcList.a[].colUsed field. No changes to code. (check-in: c0f67ea1 user: drh tags: experimental) | |
| 14:32 | Fix the trace output of the OP_Function opcode to show the correct register numbers. (check-in: 064c283e user: drh tags: experimental) | |
| 07:57 | Add file test_demovfs.c, containing a simple VFS implementation that demonstrates how writes to the journal file may be safely buffered by the VFS layer to improve performance on some embedded systems. (check-in: af3b72d9 user: dan tags: trunk) | |
|
2010-04-06
| ||
| 22:33 | Veryquick.test is now working. The SQLITE_STMTSTATUS_AUTOINDEX counter added. (check-in: abbf16e5 user: drh tags: experimental) | |
| 18:51 | Runs quicktest without hitting an assert now. Some tests get unexpected results still and there is a memory leak. (check-in: a8224448 user: drh tags: experimental) | |
| 18:28 | Progress toward getting automatic indices to work. Still failing in corner cases. (check-in: ac6d0fba user: drh tags: experimental) | |
| 15:57 | Automatically generate transient indices for tables in joins that would otherwise have to use a full table scan. (check-in: 1b2a0412 user: drh tags: experimental) | |
|
2010-04-05
| ||
| 15:11 | Minor comment changes to the OP_OpenEphemeral header. No changes to code. (check-in: 8e1d7ef4 user: drh tags: trunk) | |
|
2010-04-03
| ||
| 13:08 | Silently abandon a rollback if the journal has been truncated. (check-in: 7626f6c9 user: drh tags: trunk) | |
|
2010-04-02
| ||
| 13:25 | Check for a failure in the call to sqlite3PagerPagecount() from within sqlite3PagerWrite(). (Error discovered by valgrind.) (check-in: d64d181c user: drh tags: trunk) | |
| 12:55 | Take care to avoid a buffer over-read when adding a KEYINFO structure to the P4 parameter of an opcode. (check-in: 937b931a user: drh tags: trunk) | |
| 12:46 | If the size of the database according to the header is larger than the actual database file size, report that the database is corrupt. (check-in: 8eb1f244 user: drh tags: trunk) | |
| 03:39 | Pager changes for code coverage testing. (check-in: b04a45ea user: drh tags: trunk) | |
|
2010-04-01
| ||
| 18:33 | Disable the corruptE.test script when ENABLE_OVERSIZE_CELL_CHECK is on. (check-in: 1dc4f9fe user: drh tags: trunk) | |
| 16:15 | Zero the filesize-in-header word for bigfile.tcl. Remove bigfile.tcl from the journaltest permutation. (check-in: 63610c71 user: drh tags: trunk) | |
| 13:41 | Do not journal the content of freelist leaf pages. This restores an optimization that was accidently undone by check-in [12f7346c13] on 2009-01-20. (check-in: b1e7a1a6 user: drh tags: trunk) | |
| 02:47 | Remove a NEVER in sqlite3PagerPagecount() that can in fact be true. (check-in: 8f005337 user: drh tags: trunk) | |
| 02:22 | Restore the size information in the BtShared structure when a transaction rolls back. (check-in: 802aeb30 user: drh tags: trunk) | |
|
2010-03-31
| ||
| 23:20 | Make sure an OOM error on sqlite3PagerPagecount() is detected and reported out to the interface. (check-in: 8aecf302 user: drh tags: trunk) | |
| 20:29 | Report corruption if a database contains a reference that is out of range according to the filesize-in-header database size. (check-in: a91db0b1 user: drh tags: trunk) | |
| 17:47 | Clarification of the implementation of SQLITE_STMTSTATUS_FULLSCAN_STEP. No logical code changes - just commenting and layout changes to improve readability. (check-in: 06b9ca32 user: drh tags: trunk) | |
| 15:02 | Clear the column cache before populating aggregate accumulator registers. Fix fo r [883034dcb5]. (check-in: ffc23409 user: dan tags: trunk) | |
| 13:57 | Documentation enhancements for the sqlite3_log() interface. No functional changes to code. (check-in: ba13a111 user: drh tags: trunk) | |
| 11:52 | Include shell.c and sqlite3.def in the amalgamation ZIP archive. Ticket [e063139eb3f8] (check-in: 0077ed5c user: drh tags: trunk) | |
| 02:31 | Increase test coverage following the introduction of the new filesize-in-header logic. (check-in: dbc2c3c0 user: drh tags: trunk) | |
|
2010-03-30
| ||
| 22:58 | Continuing refinements to the filesize-in-header enhancement. (check-in: 79e22b95 user: drh tags: trunk) | |
| 15:51 | Add a NEVER macro around a test in btree.c that can not longer be true. (check-in: c117f992 user: drh tags: trunk) | |
| 12:40 | Do not crash when compiling an "INSERT INTO tbl DEFAULT VALUES" when tbl has either BEFORE or INSTEAD OF triggers attached to it. Ticket [f3162063fd]. (check-in: ca359a3e user: dan tags: trunk) | |