Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
Comment: | Fix the VACUUM command so that when the MAIN and TEMP databases have identically named tables, content from the TEMP database does not accidently overwrite MAIN database content. Ticket [d82e3f3721296e905d7e8c9dee718f71a826b0eb]. Note that this bug could potentially lead to database corruption. |
---|---|
Downloads: | Tarball | ZIP archive |
Timelines: | family | ancestors | descendants | both | trunk |
Files: | files | file ages | folders |
SHA1: |
0bbd8d72ec66cbe11c2548a04ad47820 |
User & Date: | drh 2009-10-20 15:01:59.000 |
References
2009-10-26
| ||
08:30 | • Ticket [d82e3f3721] VACUUM corrupts database when MAIN and TEMP table names overlap. status still Fixed with 1 other change (artifact: f9ff61b459 user: rogerb) | |
Context
2009-10-20
| ||
15:27 | Clarify the use of sqlite3_shutdown(). Ticket [f9af981dd2a2]. Comment changes only - no changes to code. (check-in: b2aa48b52f user: drh tags: trunk) | |
15:01 | Fix the VACUUM command so that when the MAIN and TEMP databases have identically named tables, content from the TEMP database does not accidently overwrite MAIN database content. Ticket [d82e3f3721296e905d7e8c9dee718f71a826b0eb]. Note that this bug could potentially lead to database corruption. (check-in: 0bbd8d72ec user: drh tags: trunk) | |
14:23 | Remove all mention of sqlite3_next_stmt() from the documentation of sqlite3_close(). (check-in: f494ed38a8 user: drh tags: trunk) | |
Changes
Changes to src/vacuum.c.
︙ | ︙ | |||
185 186 187 188 189 190 191 | if( rc!=SQLITE_OK ) goto end_of_vacuum; rc = execExecSql(db, "SELECT 'CREATE UNIQUE INDEX vacuum_db.' || substr(sql,21) " " FROM sqlite_master WHERE sql LIKE 'CREATE UNIQUE INDEX %'"); if( rc!=SQLITE_OK ) goto end_of_vacuum; /* Loop through the tables in the main database. For each, do | | | | | | | 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 | if( rc!=SQLITE_OK ) goto end_of_vacuum; rc = execExecSql(db, "SELECT 'CREATE UNIQUE INDEX vacuum_db.' || substr(sql,21) " " FROM sqlite_master WHERE sql LIKE 'CREATE UNIQUE INDEX %'"); if( rc!=SQLITE_OK ) goto end_of_vacuum; /* Loop through the tables in the main database. For each, do ** an "INSERT INTO vacuum_db.xxx SELECT * FROM main.xxx;" to copy ** the contents to the temporary database. */ rc = execExecSql(db, "SELECT 'INSERT INTO vacuum_db.' || quote(name) " "|| ' SELECT * FROM main.' || quote(name) || ';'" "FROM main.sqlite_master " "WHERE type = 'table' AND name!='sqlite_sequence' " " AND rootpage>0" ); if( rc!=SQLITE_OK ) goto end_of_vacuum; /* Copy over the sequence table */ rc = execExecSql(db, "SELECT 'DELETE FROM vacuum_db.' || quote(name) || ';' " "FROM vacuum_db.sqlite_master WHERE name='sqlite_sequence' " ); if( rc!=SQLITE_OK ) goto end_of_vacuum; rc = execExecSql(db, "SELECT 'INSERT INTO vacuum_db.' || quote(name) " "|| ' SELECT * FROM main.' || quote(name) || ';' " "FROM vacuum_db.sqlite_master WHERE name=='sqlite_sequence';" ); if( rc!=SQLITE_OK ) goto end_of_vacuum; /* Copy the triggers, views, and virtual tables from the main database ** over to the temporary database. None of these objects has any ** associated storage, so all we have to do is copy their entries ** from the SQLITE_MASTER table. */ rc = execSql(db, "INSERT INTO vacuum_db.sqlite_master " " SELECT type, name, tbl_name, rootpage, sql" " FROM main.sqlite_master" " WHERE type='view' OR type='trigger'" " OR (type='table' AND rootpage=0)" ); if( rc ) goto end_of_vacuum; /* At this point, unless the main db was completely empty, there is now a ** transaction open on the vacuum database, but not on the main database. |
︙ | ︙ |
Added test/tkt-d82e3f3721.txt.
> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 | # 2009 September 2 # # The author disclaims copyright to this source code. In place of # a legal notice, here is a blessing: # # May you do good and not evil. # May you find forgiveness for yourself and forgive others. # May you share freely, never taking more than you give. # #*********************************************************************** # This file implements regression tests for SQLite library. # # This file implements tests to verify that ticket [d82e3f3721] has been # fixed. # set testdir [file dirname $argv0] source $testdir/tester.tcl do_test tkt-d82e3-1.1 { db eval { CREATE TABLE t1(a INTEGER PRIMARY KEY AUTOINCREMENT, b); INSERT INTO t1 VALUES(null,'abc'); INSERT INTO t1 VALUES(null,'def'); DELETE FROM t1; INSERT INTO t1 VALUES(null,'ghi'); SELECT * FROM t1; } } {3 ghi} do_test tkt-d82e3-1.2 { db eval { CREATE TEMP TABLE t2(a INTEGER PRIMARY KEY AUTOINCREMENT, b); INSERT INTO t2 VALUES(null,'jkl'); INSERT INTO t2 VALUES(null,'mno'); DELETE FROM t2; INSERT INTO t2 VALUES(null,'pqr'); SELECT * FROM t2; } } {3 pqr} do_test tkt-d82e3-1.3 { db eval { SELECT 'main', * FROM main.sqlite_sequence UNION ALL SELECT 'temp', * FROM temp.sqlite_sequence ORDER BY 2 } } {main t1 3 temp t2 3} do_test tkt-d82e3-1.4 { db eval { VACUUM; SELECT 'main', * FROM main.sqlite_sequence UNION ALL SELECT 'temp', * FROM temp.sqlite_sequence ORDER BY 2 } } {main t1 3 temp t2 3} sqlite3 db2 test.db do_test tkt-d82e3-2.1 { db eval { CREATE TEMP TABLE t3(x); INSERT INTO t3 VALUES(1); } db2 eval { CREATE TABLE t3(y,z); INSERT INTO t3 VALUES(8,9); } db eval { SELECT * FROM temp.t3 JOIN main.t3; } } {1 8 9} do_test tkt-d82e3-2.2 { db eval { VACUUM; SELECT * FROM temp.t3 JOIN main.t3; } } {1 8 9} finish_test |