Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
50 most recent check-ins tagged with "mistake"
|
2024-04-15
| ||
| 14:29 | Merge from wrong branch. Bedrock should be updated from wal2, not from trunk. (Closed-Leaf check-in: 4c23cad9 user: drh tags: mistake) | |
|
2024-03-12
| ||
| 10:47 | First attempt at version 3.45.2, but failed to set the version number correctly in the source tree. (Closed-Leaf check-in: 78bed2b0 user: drh tags: mistake) | |
|
2024-02-28
| ||
| 19:44 | Put NEVER() on a branch in STAT4 that appears to be unreachable. (Closed-Leaf check-in: 0ca35e92 user: drh tags: mistake) | |
|
2024-02-27
| ||
| 15:56 |
| |
|
2024-02-07
| ||
| 19:09 | Checked into the wrong branch. (Closed-Leaf check-in: 81bd7aee user: drh tags: mistake) | |
|
2024-01-04
| ||
| 16:15 | Testing code left in by accident. (Closed-Leaf check-in: 90e8a233 user: dan tags: mistake) | |
|
2023-11-23
| ||
| 11:59 | Fix a incomplete assert() statement in sqlite3SubqueryColumnTypes(). (Closed-Leaf check-in: 844e05ed user: drh tags: mistake) | |
|
2023-11-13
| ||
| 17:26 | Mistaken creation by a Fossil expert-to-be-maybe. (Leaf check-in: 2e3e98a4 user: larrybr tags: mistake) | |
|
2023-10-21
| ||
| 19:51 | Check-in contains stray edit. (Closed-Leaf check-in: cbea52e9 user: drh tags: mistake) | |
|
2023-10-09
| ||
| 12:10 | In the VDBE trace output (available under -DSQLITE_DEBUG only), identify register values that hold a refernce-counted string. (Closed-Leaf check-in: 53d5c504 user: drh tags: mistake) | |
|
2023-09-29
| ||
| 15:18 | Bad edit (Closed-Leaf check-in: c794aeb3 user: drh tags: mistake) | |
|
2023-07-26
| ||
| 18:13 | Make sure jsonReplaceNode() always leaves the JsonParse in a consistent state even if an error is encountered. (Closed-Leaf check-in: 29c7b1cb user: drh tags: mistake) | |
|
2023-05-18
| ||
| 23:16 | Incorrect fix. (Closed-Leaf check-in: 81b1bce7 user: drh tags: mistake) | |
|
2023-04-24
| ||
| 19:14 | Mistake → branched off of the wrong branch. (Closed-Leaf check-in: 491bd51d user: drh tags: mistake) | |
|
2022-08-31
| ||
| 00:44 | Checked in the wrong change by mistake. (Closed-Leaf check-in: 984a07d7 user: drh tags: mistake) | |
|
2022-07-01
| ||
| 12:09 | In the sqlite_stmt virtual table, add two ALWAYS() macros on branches that have been come always true due to the [84a91c255e3d7772] optimization. REVISED: Dbsqlfuzz found a case where the ALWAYS() is false. (Closed-Leaf check-in: bf34eddb user: drh tags: mistake) | |
|
2022-01-19
| ||
| 20:38 | Mistaken branch creation. (Closed-Leaf check-in: 03548c25 user: larrybr tags: mistake) | |
|
2021-04-20
| ||
| 00:09 | Add two ALWAYS() macros for branches no longer reachable due to the previous check-in. Later: Dbsqlfuzz quickly found ways to make both of these ALWAYS() conditionals false. (Closed-Leaf check-in: 8f339f43 user: drh tags: mistake) | |
|
2020-12-29
| ||
| 16:48 | Add an ALWAYS on an always-true conditional in the cursor renumbering logic of the UNION ALL flattener. Edit: turns out this change is incorrect and the conditional is reachable after all. See the nearby trunk check-in for test cases. (Closed-Leaf check-in: 5774318e user: drh tags: mistake) | |
|
2020-07-23
| ||
| 20:37 | Turns out this is an aliasing bug in SQLite, not a GCC bug. Was: Work-around for what appears to be another GCC bug - this one for GCC 8.3.0 on ARM. See the SQLite forum post for discussion. (Closed-Leaf check-in: 40c44d38 user: drh tags: mistake) | |
|
2019-04-19
| ||
| 18:10 | Mark two branches as unreachable. Oops - one of those branches was reachable via fuzzcheck tests. (Closed-Leaf check-in: 9b888fcc user: drh tags: mistake) | |
|
2019-02-25
| ||
| 15:43 | This was originally intended to be the 3.27.2 release, but then I realized that I left out an important patch. (Closed-Leaf check-in: 6c5e5e2e user: drh tags: mistake) | |
|
2018-12-05
| ||
| 23:25 | Bungled checkin. Ignore. (Closed-Leaf check-in: 9b6e9a6e user: drh tags: mistake) | |
|
2018-01-10
| ||
| 13:44 | Checked into the wrong branch. (Closed-Leaf check-in: 55116dc3 user: drh tags: mistake) | |
|
2017-12-26
| ||
| 14:12 | Add options to speedtest1.c and speed-check.sh for testing performance of floating-point computatations. (Closed-Leaf check-in: b3c61051 user: drh tags: mistake) | |
| 14:11 | Fix crashes that could occur if SQL NULL values were passed to the built-in FTS5 snippet function. Edit: breaks amalgamation builds. (check-in: 553a3ad3 user: dan tags: mistake) | |
|
2017-10-27
| ||
| 23:28 | I was a little concerned about this check-in. Though I could not generate a failure myself, I thought it was risky. I checked it in for further testing. Then, overnight, OSSFuzz found a failure case for me. So the change is now moved out into a deadend branch. Was: Use OP_SCopy rather than OP_Copy to transfer results from a co-routine to its consumer. This undoes an earlier fix for ticket [98825a79ce] by check-in [ec6a06246e] because that problem no longer occurs due to WHERE clause push-down. (Closed-Leaf check-in: 0926df09 user: drh tags: mistake) | |
|
2017-08-22
| ||
| 19:44 | mksourceid still does not work right. (Leaf check-in: ca5dcb4a user: drh tags: mistake) | |
|
2017-02-15
| ||
| 16:04 | Bummer. Checked this in as a branch off of the wrong branch.... Was: Add the companion "carray_asc" table-valued function to the carray extension. (Closed-Leaf check-in: 396b9d99 user: drh tags: mistake) | |
|
2016-09-02
| ||
| 17:27 | The previous commit could miss an SQLITE_NOMEM error. This commit catches it. (Closed-Leaf check-in: 3a9f4750 user: dan tags: mistake) | |
|
2016-05-11
| ||
| 18:20 | Remove a redundant condition from pcache.c. Add an OPTIMIZATION-IF-TRUE comment to another condition that requires it. (Closed-Leaf check-in: 4533ed35 user: dan tags: mistake) | |
|
2016-04-05
| ||
| 18:24 | Oops. Branched from the wrong baseline. Ignore this one. (Closed-Leaf check-in: 8f1f300c user: drh tags: mistake) | |
|
2015-09-29
| ||
| 17:51 |
This condition was not always true after all.....
Change an always-true condition in the virtual table transaction interface into an assert(). (Closed-Leaf check-in: 3e15dea5 user: drh tags: mistake) | |
|
2015-09-02
| ||
| 12:52 | This change is not correct for the boundary case of nCellKey==0. Was: Small performance gain and size reduction in sqlite3VdbeIdxKeyCompare(). (Closed-Leaf check-in: 6e0298cd user: drh tags: mistake) | |
|
2015-04-28
| ||
| 13:11 | Oops - the deephemerialization needs to occur before the move, not after. Was: Rather than try to keep track of the parent of an ephermeral register when the register moves, just deephemeralize all registers touched by the OP_Move opcode. (Closed-Leaf check-in: 091cfe8e user: drh tags: mistake) | |
|
2015-04-16
| ||
| 12:09 | Checked in the wrong fix. (Closed-Leaf check-in: 4b0f4484 user: drh tags: mistake) | |
|
2014-11-22
| ||
| 16:14 | Unintentional edits mistakenly checked in. Was: Remove an obsolete and incorrect comment from the whereLoopOutputAdjust() routine in the query planner. No changes to working code. (Closed-Leaf check-in: e1f893c6 user: drh tags: mistake) | |
|
2014-08-29
| ||
| 12:29 | Contains a fault. Was: Avoid an unnecessary OP_Move operation for expression subqueries. (Closed-Leaf check-in: 462f42af user: drh tags: mistake) | |
|
2014-03-11
| ||
| 14:44 | Forgot to change the VERSION file. (Closed-Leaf check-in: 04caffce user: drh tags: mistake) | |
|
2013-01-07
| ||
| 13:26 | Do not raise an error if an unknown SQL function is found in a CHECK constraint while parsing the schema of an existing database. This version causes a run-time error when processing STAT3 tables. (Closed-Leaf check-in: 0a1207c8 user: dan tags: mistake) | |
|
2012-12-04
| ||
| 05:21 | Add a test to ensure that the fix in [b0c1ba655d] has worked. (Closed-Leaf check-in: 59c23394 user: dan tags: mistake) | |
|
2012-09-18
| ||
| 17:32 | This change generates incorrect code when there are two or more IN operators in the WHERE clause that are both used by the same index. Was: Omit an unnecessary OP_IfNull that immediately follows an OP_Rowid. (Closed-Leaf check-in: 2be661a4 user: drh tags: mistake) | |
|
2012-08-21
| ||
| 13:08 | Update the spellfix virtual table so that all OOM errors are reported out to the application. ERROR: A single edit was missed in spellfix1 which means that this particular check-in won't build "make test". (Closed-Leaf check-in: c2cf4985 user: drh tags: mistake) | |
|
2012-05-20
| ||
| 20:14 | Check-in included unrelated debugging code by mistake. Was: Fix a test case in the shell1.test script so that it works even for very long pathnames. (Closed-Leaf check-in: 0c0a0398 user: drh tags: mistake) | |
|
2012-03-28
| ||
| 15:44 | This change turned out to the code slower. Side track it. Was: Tweaks to the OP_Column opcode for clarity of presentation. (Closed-Leaf check-in: 4d516240 user: drh tags: mistake) | |
|
2011-09-22
| ||
| 03:13 | Merge the cache-stats enhancement into trunk. (Closed-Leaf check-in: 646db971 user: drh tags: mistake) | |
|
2011-05-13
| ||
| 17:11 | Rather than document goofy behavior, it seems better to make the behavior less goofy. (Was: Updates to the sqlite3_last_insert_rowid() documentation - to make it clear that the function does not work for virtual tables.) (Closed-Leaf check-in: f88dfac3 user: drh tags: mistake) | |
|
2011-05-10
| ||
| 14:52 | Provide the ability to specify an alternative mutex subsystem at compile-time. - This check-in should have gone on the trunk, not on the 3.7.6 branch. (Closed-Leaf check-in: 489c453d user: drh tags: mistake) | |
|
2011-02-23
| ||
| 13:53 | The robust_flock() fix that accidently included some unrelated, though harmless changes. I should follow my own checklist! (Closed-Leaf check-in: e701efbd user: drh tags: mistake) | |
|
2011-01-28
| ||
| 17:02 | Bogus release candidate. (Closed-Leaf check-in: 38ca1daa user: drh tags: mistake) | |