Overview
| SHA1: | b5a8f3160b5dc1397312add3c5410e7e0a12b75e |
|---|---|
| Date: | 2012-12-20 00:32:49 |
| User: | drh |
| Comment: | Remove an unreachable branch operation from the foreign_key_check pragma. |
Tags And Properties
- branch=foreign-key-check inherited from [01c980e9]
- closed added by [a54566a7] on 2012-12-20 02:38:33
- sym-foreign-key-check inherited from [01c980e9]
Context
|
2012-12-20
| ||
| 01:15 | [e408dc90] Add PRAGMA foreign_key_check. Name the child and parent tables as part of a "foreign key mismatch" error. (user: drh, tags: trunk) | |
| 00:32 | [b5a8f316] Closed-Leaf: Remove an unreachable branch operation from the foreign_key_check pragma. (user: drh, tags: foreign-key-check) | |
|
2012-12-17
| ||
| 22:32 | [25411f83] Added test cases for PRAGMA foreign_key_check. Fixed a bug that appears when the column order of the child and parent differ. (user: drh, tags: foreign-key-check) | |
Changes
Changes to src/pragma.c.
1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 |
pIdx = 0;
aiCols = 0;
x = sqlite3FkLocateIndex(pParse, pParent, pFK, &pIdx, &aiCols);
assert( x==0 );
addrOk = sqlite3VdbeMakeLabel(v);
if( pIdx==0 ){
int iKey = pFK->aCol[0].iFrom;
if( iKey>=0 && iKey!=pTab->iPKey ){
sqlite3VdbeAddOp3(v, OP_Column, 0, iKey, regRow);
sqlite3ColumnDefault(v, pTab, iKey, regRow);
sqlite3VdbeAddOp2(v, OP_IsNull, regRow, addrOk);
sqlite3VdbeAddOp2(v, OP_MustBeInt, regRow,
sqlite3VdbeCurrentAddr(v)+3);
}else{
sqlite3VdbeAddOp2(v, OP_Rowid, 0, regRow);
|
> | |
1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 |
pIdx = 0;
aiCols = 0;
x = sqlite3FkLocateIndex(pParse, pParent, pFK, &pIdx, &aiCols);
assert( x==0 );
addrOk = sqlite3VdbeMakeLabel(v);
if( pIdx==0 ){
int iKey = pFK->aCol[0].iFrom;
assert( iKey>=0 && iKey<pTab->nCol );
if( iKey!=pTab->iPKey ){
sqlite3VdbeAddOp3(v, OP_Column, 0, iKey, regRow);
sqlite3ColumnDefault(v, pTab, iKey, regRow);
sqlite3VdbeAddOp2(v, OP_IsNull, regRow, addrOk);
sqlite3VdbeAddOp2(v, OP_MustBeInt, regRow,
sqlite3VdbeCurrentAddr(v)+3);
}else{
sqlite3VdbeAddOp2(v, OP_Rowid, 0, regRow);
|